From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A569D816F8 for ; Fri, 13 Nov 2026 19:57:41 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJtTwF019606; Fri, 13 Nov 2026 22:55:30 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJtTwF019606 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="NU25xdIN" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJtM6G019584 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:55:22 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJtM6G019584 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a70b42bab0so8763335e9.1 for ; Fri, 13 Nov 2026 11:55:22 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEzqP6e/Unb5bt0hi1s/awwqaFSIibFTUgu8BQpfr6zmETdCXlovhSANJJXGJzGEIdcnRSqfg==@openvz.org X-Gm-Message-State: APuU4Z8AoOtAFtXwy17ldldtMpm2/LRRXDjG15rggc47XisAaPoqfQMN Wv5sT5nwMw0u8zaKfWzAiPAaXM2oZN5Ga0InSkb+LfjqPKENau4EwK0biMLr0EcaU4sWzBU+Zrh fV82G6kETOMrRDvQC7tHMrmNl0ZBDL5mCEzMQvAfpt98fk86btVGAAA== X-Gm-Gg: AYBFou1YTotRlni/t9aOAcz6hZmRct9i7grx4yMT6JL1k/YzTFWdTUcrBWNhbNPWf4H 9Gf7IIXDro7Zb4Jz/oVKiz0m9JkorBFIYbEKSzowEAB6pOo/WGZtEAEIt7q34CJTDE8Gbd91cf1 MBUxK3jXfsT5MYx5O1VJkkWmxnLPhyaUp5CBOtYbKQ/i0sb1YZo3SVIAhe+6ltzD0CHQREoCgrP EW1KHi/7OAR7Im/FdVYIraSu47UPLXQr+2lesvTVCQHFVHZ5c86qlqouhog8X0+lOJm5ys0kT7Q UDC3aP3xIrprPAabTyyXI24Vug3Bg8EgB1zzI3c8HJPaU2Ya6CD/OSrkYtexXbuQEvS2roH2DT9 9dbwazI75FLP3iN6zAA== X-Received: by 2002:a05:600c:4343:b0:4bb:5e8a:7c9c with SMTP id 5b1f17b1804b1-4bb5e8a7cc5mr23092915e9.7.1794599722443; Fri, 13 Nov 2026 11:55:22 -0800 (PST) X-Received: by 2002:a05:600c:4343:b0:4bb:5e8a:7c9c with SMTP id 5b1f17b1804b1-4bb5e8a7cc5mr23092725e9.7.1794599721974; Fri, 13 Nov 2026 11:55:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794599721; cv=none; d=google.com; s=arc-20260327; b=ZMfCT9kA9zDonGGgvHacw7HALhXCz4bOqEvQVipWjcaZgRAJDNzL0WfHe4sPt1TtX+ 1hu2ShjdE3D/LD2R4NKgpv+yX2xH4Ygee1HCjHzo8iPGfea7YbJ1zLak+wdNb6hcbBD8 QbymeDY8ZjMG1CWBVnBKJ2//2S8tQNTa1BW8SlAQly/V6lAP40J4ADX6vkRVbaA/Yha3 qSJ4sDUqxFJYed03f8Z4qg+cSCR2y5vRV0eraEAZN9Tlw01SN5lN5fY4ITmYaTZKCHh5 gTMDqsnNTYGew9/+RJY1svYbC+YLAi04AkVqphPr1lcxl/4S/ZKTzqJWn+zylY0S/mY0 Hm1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=NVDdY5qAR+igQmSFmN3/UQ2+zCau+GNGqVzSn4dTjJA=; fh=YDx/sgeCfUIZ9eyfBjqETg92hV70ladS2omuMPCV2do=; b=LyEYFkyCM7oXUw7OaAKJS0LmKLajHtxnacOix3Vy3q5upDxU44KcwFYlOopprfHA0P 2l9rqHHlzggdftd/wC08B+WsBQNJ1cNUSP4u6c/wn1Ju/KVt9uLh2yqrn2xa+yXxAkN6 0gynkUxzITh17TgZfuLEaW/vchkcytjMo1ypru/DEPH2MC5YYtGXWRmQgQml7tlS6dBo IGi/mee1it0K1R9B+m50/MkshsfMLaqrnTpkyebk6/k3ALhGCzjwxAE0JOLuca9liCDy 99NUNoNtnN1rNSzaPK2Q6nXtX3BIDkA1SwEh6TD9Jgcf+ZjK4r1PrkRBzXe3ComSVtLV FFCw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NU25xdIN; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c650cbfd6si7046138f8f.486.2026.11.13.11.55.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:55:21 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NU25xdIN; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=NVDdY5qAR+igQmSFmN3/UQ2+zCau+GNGqVzSn4dTjJA=; b=NU25xdIN3Rkq pcXN7sAkmRDfVGr9/omTw70w+fq6ir/GTsnVK0KHMKhixuWNwByTtprzlfB5GgTCtj9JgnDZTVSzd njshYAA9TROjkLyLoH5IMhbV+e/FSd75V2icn8K1T9/q9Iq2Vhi9vLyys5RGJnE8bGRpvoh3Ww/9k 43CquewmNNBjbPm26ufhkL+arwQxnb3vOwaklqlcHoqnWg1HGc24Ud6Y8vFf+DQ4eAc/koge7eNlv iP2ahtbii4Bc8y243wo4+eoHRDaWRiD8lvm8O8GDmGUoC0sKZEv2QssDdmAehBUavUXynJhexDqJ1 O2+BpGGc+fmCDOalPoYdMA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRxIc-00GcGq-2p; Fri, 13 Nov 2026 20:55:17 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261113082744.2334476-3-alexander.ivanov@virtuozzo.com> References: <20261113082744.2334476-1-alexander.ivanov@virtuozzo.com> <20261113082744.2334476-3-alexander.ivanov@virtuozzo.com> Date: Fri, 13 Nov 2026 20:55:17 +0100 Message-Id: <179459971758.57567.10368092256511275343.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1119; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=LlRpD3M92QOZPmxbEg4l/hDFlJEPWR5cQNDHVAi7Tns=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92so2cwX8li1Xgg96UDNfLhrmU71iPo9cFVNR 0R4pAFmKuyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdrKAAKCRBRlgpH+WFc KrkZD/9B6MRDyr3GHAQs6OkxTDa3lW4GyOOVV2DFq63+182MbZ5W0ml1tpnMH7AEBNzt2VaASdp pdI0fPNSt0zcDOtGwbELGUnk/haU9tAFeYQfzSkdS2EtLgqjC9aEpAZ5Vh91CeMvk3uk7f/EeiH FvpGFfGjvucdqOZqNx1XLJtJhA5VWfn1PsqAqRsz7k3gkofy3T5o+32iAnc+V7rtVVNy3O1knIL 14GViTHb6cPpou2Ht4jGv6cSPDOz0POv+0EH+YN+Vlm2XIVksFQDxMgL1VO+R8tcXqpAVE3fEM8 4BLjomH74L9HglMsClyVxYJWROYIZwCXYsd6KAzCgOyBc5HT09bk4E8T61EvBQHHP8WNZSpPZVs QDOHydr4kIjVYfRe+mypEzNJMWbHdSzbYJ30N+vtl6g2WK9bqCY1oqSfcC5UK5cNuVN5nXDVBTl zv4IRiADbc4As9tW3hw63wTBmYumKJ7PukkSxrF5zYgfuSOvXtxeEobiAIJal2BbqHiJd2V3mfY ziPJmFYK37N0wHt3BHOyGntOgkyN6nyXxhB4F8M0+BOlcK8fdhkudJHbxrWz+iLKQPW+UrFIpCU f2zgXwLozv8UURaqhBfl86xKSfkrzw/gi/mNsuasTz5CJPEw9Xv9fM+0sE2bylyzN4MZNlcIduY kl2b93nbfbBgAdA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 2/2] drivers/vhost/blk: support VIRTIO_BLK_F_WRITE_ZEROES X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I can apply it with these fixes on my side: - the VMM paragraph says what a large max_write_zeroes_sectors costs and that our QEMU does not advertise the feature yet On Fri, 13 Nov 2026 09:27:44 +0100, Alexander Ivanov wrote: > The VMM must advertise blk_size equal to the backend logical block > size, max_write_zeroes_sectors aligned to it and at most 8388607, and > max_write_zeroes_seg = 1. Added: "A request is zeroed one chunk at a time and holds vhost_blk_flush() until its last chunk, so a small max_write_zeroes_sectors keeps vhost ioctls short on backends without WRITE ZEROES. Our QEMU does not advertise the feature yet." Why: dm-qcow2 and dm-ploop have no WRITE ZEROES, so a 4 GiB request is a long row of 4 MiB zero-page chunks, and every generic vhost ioctl QEMU sends, SET_FEATURES among them, waits uninterruptibly in vhost_blk_flush() until the last one. Only the VMM can bound that. The v1 reply also asked to say that QEMU has to follow: its "write-zeroes" property is off and it fills no write-zeroes config field. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel