From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E8DF8803F6 for ; Fri, 13 Nov 2026 19:57:39 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJtRQB019599; Fri, 13 Nov 2026 22:55:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJtRQB019599 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="BjtU1y0I" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ADJtMrF019582 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 13 Nov 2026 22:55:22 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ADJtMrF019582 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a4654add56so11039055e9.2 for ; Fri, 13 Nov 2026 11:55:22 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEUSRtAblc7hgMbbfyQM/pRqpGPfA0dbYl48iUkL3ZnLk9VxBBAMaiRoamiyVVxSvEqBPArGQ==@openvz.org X-Gm-Message-State: APuU4Z9Kl+vP745Gh6bhaJGaVX5di9XmM0nnYCgoV0vttsP5XCP5iH1B p3Cjt6GiaTv7v7qKdmy0b7D6noL65wySrbNSqR+7XKvYrhCISU9F3gHQ3aewWxXzSTudyqX4Bmm +4gqhKcR360XmoiFrfvnfLI9V1yoOEcf3KZ52sMi40uCep/Xu66pGLQ== X-Gm-Gg: AYBFou2IRn48yEKPYXKHsis6PjLdVBXLwB1rziBtwcQEzjpq3MeyoX9dEcxnNVY1caL FMOJsBhB8jEu4igJ7FVukHUjIeeAKVw6jINO+jCMP3ssP1157suSElMOKr7ytv9oaRuy83/WCvZ aCwSQAAk8pAk0kcc/SndJWgRJi/hG3exlK8mFszqC4aWDqXXHUK8ukQUWewTz0jEExakQXxhs8I NVP0qmVDUcH+Hkg8PE75PlPinZ8m1p824TB7hbjcVhGIC1yYz4rHjw83z263F7B25gI2b6KFjn1 TD+OWxEGMjiMYIWuNL8upZUHyDakCldBcixoTz3GID7plG8cpwWitcAuAfpcmo/mQIxt8VBudkw WM192ix3TiOG/GEa0/w== X-Received: by 2002:a05:600c:484:b0:4ba:493b:3401 with SMTP id 5b1f17b1804b1-4bb55a5d628mr55826385e9.9.1794599722330; Fri, 13 Nov 2026 11:55:22 -0800 (PST) X-Received: by 2002:a05:600c:484:b0:4ba:493b:3401 with SMTP id 5b1f17b1804b1-4bb55a5d628mr55826195e9.9.1794599721835; Fri, 13 Nov 2026 11:55:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794599721; cv=none; d=google.com; s=arc-20260327; b=OrKofED4NbCtuws8k4kNLorQKbvjFy/Gd90A/90IR2OAgpIc9WH7gvOXDbNAS5m0jC Pm3feleHbVsj05JOJG5xiI2NFjuhpHl47+ukTnvYSVvnx4FHiCN/CBY+apwIhHFtHLiK cTKqaV5NluXlDMqOxe+Z55EK+xqzCIEy2iUj6SJDjmZxalXYrB65nsjJKyqoU0EE/HAu 6E46/dGPdN/E2j964nFokD0xTAyFQVg8s9hkgzEAxVqcoh3lEaGb9Zkxm6zf8xxhtBhI CrXwlSHmGFwsZvAPYCNTJijDK4B7cMKJ71AVi+UKMi7hwzaAfRyTKNDXexoDo32dz8KO Kobg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=WNSbMJnnbZ5rc1G7X5nTzzIQ9fEaZOwrLx4VVAbgaWs=; fh=YDx/sgeCfUIZ9eyfBjqETg92hV70ladS2omuMPCV2do=; b=TYB4n66PnnsUU3AtA+tz+dH1pI0B+yIB7lssJWpxhUWydVdiO2gwYlngv1BV2/rRCc RDPWQADUmhl0+peAsf5KEwD/bvwXPupr7b5iFvaK1TYgPzl/CdZ2o5ZXQ7BC1cZ+IF1M 2AGZ2Eh4qF/WgXYcfK/75qr+ZVGwqHSCo9GWGFLpcUDsMlyUKMVlZlQYtOUbos1mGSGL vY5Mc2Xl2f+8t3/jnYKBfLWPVkFp9O77tDQfEQo2UX8BoLN4hgO9qya307vwWM8HlDuD N5mmlEMAznDDESSVyX8CmTl/tPoidouYuvL8V2VwfgwoKgOjBPvmJ0RclpRwp7SQdyuR OA5Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=BjtU1y0I; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63e986c7si7085965f8f.262.2026.11.13.11.55.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 11:55:21 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=BjtU1y0I; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=WNSbMJnnbZ5rc1G7X5nTzzIQ9fEaZOwrLx4VVAbgaWs=; b=BjtU1y0IR5+A HgAbP5NjKhdbtEPXE3CQYu+G6LSsQoDaRVTj5soZVdQNAGccLl41vslZBsxO//rUwJVgjQDjdpMKd 2pWv3SaELrg+0q7fz3YjYQwUfYFjEpRudHGGpChq8G29fo0X0WRlvXe26dmFc0H1qyBlLPucTI7ao 7AKOqXdYRLDiE7Xt04EkuLPRcTajFPuin2DRWOkkkMM6igSizfJMVGQKt1e8xy25LN5mlspvyQK0A bgO9+Ydq3n8ivZJgVnMxzrOZZatfrcYYe4/gawwFyUenL1sCkuwPVcSHjsCIRdLepPu1+JYeg6htP FllR64zbb5nxmMlJuIl8Rg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRxIc-00GcGq-2D; Fri, 13 Nov 2026 20:55:17 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261113082744.2334476-2-alexander.ivanov@virtuozzo.com> References: <20261113082744.2334476-1-alexander.ivanov@virtuozzo.com> <20261113082744.2334476-2-alexander.ivanov@virtuozzo.com> Date: Fri, 13 Nov 2026 20:55:17 +0100 Message-Id: <179459971758.57567.10597992512423170818.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1717; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=P6gWiCELVcZ3qCL9qFoTpJgjNZkFFIVeGu7P/CvfhcI=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq92snicv9V5XGxQ2JcwxTC7Z/cEDObEY2UJYVX kOCSy8rohiJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavdrJwAKCRBRlgpH+WFc KqTND/907ygcfvQOtO+PtqGtVOMtbBzxlqA25m1JrOlVBfmHQxuNacSdk75eQfo30e/vosbWTTf UNt46LVWlCiidWv0+UcA5HuejHbSuNkn4NF53HA5errfg9TQ8bHl/8IJ+W954rGimsaH2I/4SIq HHp4k2P+8a1oqc2iDbBnrWnFGXtp3qZIquHkX0eiYPitmf2XKnVOUyTNmvIx9Ng3jyEXsAh/CWt g4GlVlpcOoSf94xWXZgX0cvbmjllQhsZpfrqQ48R3ucB2d1GQpFNaubo3mfWtE0A37ketfaIE9y LMqANqyL8UmEBaHXKgHWZFWQ/GN60Jr53E0BCbW+wtGF1GN8PiP0VsT/N4xl6QmekWqZGx74zrB QQi0zTDRTF3EmpZGM3wS6Q+PjB8Cq0Rh8JWg3xnoM2+N7G7rFY8A9mf6WWCX/OBD8cd2t96f7JY ot+EZGXYGTlwbqc3H55/P1CtaKs4Yv0j5jb7/fyxylwvlSimcme8SvX/gpjGOt5yg9G7PtagJMA xbGFe0y6B1lP3M8PzQ7q2edlTVdRY4nLM6r6gxkJ5e51/Y/TvwF0e9Be//SX+VwpDwNa+H0noj+ z5TqFoHx2feqzkuRkoaHzulILglD3+2Kv+mep3qKPbRropujn742zQNdnfPN4ifgj60jIViJ8Fx DHBP9OBaAvLqHvQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 1/2] drivers/vhost/blk: fix a flush hang on requests completed after worker kill X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I can apply it with these fixes on my side: - the first sentence says the hang needs vhost_task workers - the work item is needed because releasing a request takes vq->mutex and flush_lock, not because of kvfree() - dropped the sentence about VHOST_RESET_OWNER On Fri, 13 Nov 2026 09:27:43 +0100, Alexander Ivanov wrote: > When the owner is killed, vhost_worker_killed() detaches the worker > from the virtqueues and runs only the work already queued. Changed to "With vhost_task workers (not the default kthread ones), killing the owner makes vhost_worker_killed() detach the worker ...". Why: vhost_worker_killed() exists only for vhost_task workers. Our kernel defaults to kthread workers (fork_from_owner_default), and our QEMU does not ask for a vhost_task. A kthread worker is not killed with QEMU and completes the requests, so the default setup does not hang. > completion may run in interrupt context, where forget_request() and > the kvfree() of the request buffers are not allowed. Changed to "where a request cannot be released: that takes vq->mutex, and flush_lock with plain spin_lock()". Why: kvfree() is allowed there, vfree() defers itself when in_interrupt(). > requests. Flushing there rather than in release also keeps a stale > drop work from releasing requests of the next owner after > VHOST_RESET_OWNER. Dropped. Why: the drop work is queued only after the owner was killed, and then nobody passes vhost_dev_check_owner(), so no VHOST_RESET_OWNER can follow. The flush is in vhost_blk_drop_backend() because the requests are freed right after it, which the sentence before already says. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel