From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 2/3] selftests: cgroup: mark the pages cold before numa_migrate starts
Date: Fri, 13 Nov 2026 20:57:56 +0100 [thread overview]
Message-ID: <179459987635.57567.10949628177365894811.b4-review@b4> (raw)
In-Reply-To: <20261113042331.517488-3-eva.kurchatova@virtuozzo.com>
Applying with these fixes on my side:
- "as soon as 85% of the pages" -> "as soon as about 74% of the pages"
- "and up to the 15% that verify_stats() tolerates can stay behind" ->
"and more of them can stay behind than verify_stats() tolerates"
On Fri, 13 Nov 2026 06:19:59 +0200, Eva Kurchatova wrote:
> before they madvise(MADV_COLD) them. The parent starts the migration as
> soon as 85% of the pages are inactive on the source node, while the
Why: wait_src_node_stat() uses values_close(a, b, 15), which compares
the difference with 15% of the sum, so it passes once the source node
holds about 74% of the pages.
> that become inactive later are not scanned, and up to the 15% that
> verify_stats() tolerates can stay behind. The slower a kernel
Why: the test fails when more pages stay behind than verify_stats()
tolerates, not up to that much.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-13 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 4:19 [Devel] [PATCH hci-8.1 0/3] selftests: cgroup: fix test_numa_migrate, inactive_disk_file Eva Kurchatova
2026-11-13 4:19 ` [Devel] [PATCH hci-8.1 1/3] selftests: harness: run the fixture teardown after a failed ASSERT Eva Kurchatova
2026-11-13 4:28 ` no-reply
2026-11-13 19:57 ` Konstantin Khorenko
2026-11-13 4:19 ` [Devel] [PATCH hci-8.1 2/3] selftests: cgroup: mark the pages cold before numa_migrate starts Eva Kurchatova
2026-11-13 4:27 ` no-reply
2026-11-13 19:57 ` Konstantin Khorenko [this message]
2026-11-13 4:20 ` [Devel] [PATCH hci-8.1 3/3] selftests: cgroup: populate the inactive file with read faults Eva Kurchatova
2026-11-13 4:28 ` no-reply
2026-11-13 19:57 ` Konstantin Khorenko
2026-11-13 19:57 ` [Devel] [PATCH hci-8.1 0/3] selftests: cgroup: fix test_numa_migrate, inactive_disk_file Konstantin Khorenko
2026-11-13 19:59 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179459987635.57567.10949628177365894811.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox