OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v2 3/3] sched: drop task_lock from sched_show_task()
Date: Mon, 16 Nov 2026 17:31:13 +0100	[thread overview]
Message-ID: <179484667333.843601.6453093491811982866.b4-review@b4> (raw)
In-Reply-To: <20261116134445.438480-4-den@openvz.org>

Applying with these fixes on my side:
- dropped the dump_cpu_task() bullet
- the paragraph after the list now also covers a report that
  interrupts the CPU holding task_lock

On Mon, 16 Nov 2026 14:44:45 +0100, Denis V. Lunev <den@openvz.org> wrote:
>   - dump_cpu_task() shows the current task of a stuck CPU from the
>     RCU stall and CSD lock reports; when that task is stuck holding
>     its own task_lock, the report spins forever instead of printing;

dump_cpu_task() calls sched_show_task() only when
trigger_single_cpu_backtrace() returns false, and on x86_64 and arm64
it always returns true. This report never gets there on our kernels.

> An interrupt or softirq on the CPU holding task_lock that needs
> rnp->lock or pool->lock closes a lock cycle, and the node locks up
> hard in the middle of reporting a stall.

sysrq-t takes neither lock: it locks up when it interrupts the CPU
that holds task_lock, and so does the RCU stall report from the tick.
The paragraph now reads:

  A report run from an interrupt on the CPU holding task_lock spins on
  it, and an interrupt or softirq there that needs rnp->lock or
  pool->lock closes a lock cycle. Either way the node locks up hard in
  the middle of reporting a stall.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-16 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:44 [Devel] [PATCH hci-8.1 v2 0/3] sched: fix hard lockups on task_lock taken under scheduler and diagnostic locks Denis V. Lunev
2026-11-16 13:44 ` [Devel] [PATCH hci-8.1 v2 1/3] sched/stats: fix a hard lockup on task_lock in update_sched_lat() Denis V. Lunev
2026-11-16 13:50   ` no-reply
2026-11-16 16:31   ` Konstantin Khorenko
2026-11-16 13:44 ` [Devel] [PATCH hci-8.1 v2 2/3] ve: free ve_name together with the ve, not at cgroup offline Denis V. Lunev
2026-11-16 13:49   ` no-reply
2026-11-16 16:31   ` Konstantin Khorenko
2026-11-16 13:44 ` [Devel] [PATCH hci-8.1 v2 3/3] sched: drop task_lock from sched_show_task() Denis V. Lunev
2026-11-16 13:52   ` no-reply
2026-11-16 16:31   ` Konstantin Khorenko [this message]
2026-11-16 16:03 ` [Devel] [PATCH hci-8.1 v2 0/3] sched: fix hard lockups on task_lock taken under scheduler and diagnostic locks Vasileios Almpanis
2026-11-16 16:31 ` Konstantin Khorenko
2026-11-16 16:31 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179484667333.843601.6453093491811982866.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox