From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id AF0C08017D for ; Mon, 16 Nov 2026 17:14:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHDfqu029136; Mon, 16 Nov 2026 20:13:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHDfqu029136 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Yf0/+QCn" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHDbgk029117 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:13:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHDbgk029117 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e0389d6f9so2051233f8f.1 for ; Mon, 16 Nov 2026 09:13:37 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFBvxMC7dptbP0ouFh00P7fTBfi8kelLlOH3Ydctyi6sm4k9Wg6G5U3BiROWLhivSP9aQF+JQ==@openvz.org X-Gm-Message-State: APuU4Z9oA4jRz0rGNXgta4RRmYyTk0X9MT1Ksj4chHKiM24kRVpfOt39 B9bA8AFnUqcJIMn3iaa/RpFM3faJG7ivGma0o5wwRbor9fqgj7DUkiGmoS9QaZM5lDKQu5TrA9x BYRcnXKhKHsJnknygAuoMyV+JZgweVFS2F/QAdeEuexSQZgsBxKavAw== X-Gm-Gg: AZFdTZenjMkrBfgI+k0fiTNX5N1/QuPRJvMywm+9ddx8yav0y9+sYBSy8ZfDlaH700Z fVo7lhDB88RA/tRWDp+CUWKASc7I92Cj2E/tAdqBIZGwDMF3QkLZjE1ED4KE4mhYu6mZno5VrEr kjr1LKNyEFI/5fQ+OdH0fbpgkjdSXlz7IUrFHk+G8/IFHJB1VDKcNZY2mjZcQZJ0wcVINJIZS81 YMrV4bDAMW/A8UamyEPC2Yo6uPlX75w1uXIGaOip1mhXr8AgN8KJ3x5XckYA+NKMcXSRt2wcDW2 1itKBFDT7oJAEPWrNmSebPcs2appn/HH6CveFVLGCkVKuHM9YsqQMwvmVO6x87ia+jmaUIzHUoT SiNEpNt2jObtJCfuQQw== X-Received: by 2002:a05:6000:268a:b0:49a:fbfd:92c4 with SMTP id ffacd0b85a97d-49c73a04ebemr25154869f8f.29.1794849217229; Mon, 16 Nov 2026 09:13:37 -0800 (PST) X-Received: by 2002:a05:6000:268a:b0:49a:fbfd:92c4 with SMTP id ffacd0b85a97d-49c73a04ebemr25154790f8f.29.1794849216642; Mon, 16 Nov 2026 09:13:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849216; cv=none; d=google.com; s=arc-20260327; b=pK1XEdcBdqGG1KrvMUX7inMiJYUB6IExV8/MgBHXR0I3bkU8U7FzkiFVqNE18xux9U efZR9xfS89I1LXnO7s7yjkWbp/UKVoA1FkaLg1JYc8niGDK+BUNia+BiVGzUdHrtA5K/ 6Z9oPuPJIlYx2AfNA4HEXc4Z9h4H6sbKoFOohEaPTeSsIs7WSytdbroHbhJukAl0PhnA /W+IVsY/P8A27Lza+Dt2bCgic+ma5Q3zG3aSWtCI0Fon9YF2r/dUzBm4RblmmY//onVU NgeQRhZrKEKPzb4LAQAvEvCeflk53/CMeX4v0p6Xzrbm6uVnrWrBYDCYbf0mnkHr4VR7 DYog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=HXktWkJ2114rizS/W11oGeLhhCm9O1frLY2MA+lsoRo=; fh=e1cf8n77z2da+N1ymO/d91hfoJ+J/34ch9kWx7ws6zY=; b=OyS4gtu/bHxddGrgRfHTKSLu5xRCPnFkaPjFijpAqCMaVnZEZQXj8BMtXmxqJvA0nS CcYf+pJIrV0f3/b7rPEjglmtUflzIqlruzeM0g/Mq1haKWP9rJfkJB34z39n/SSGE5T3 dZdkajYR6AptwR5sZ1fUsp3/k66W+mcWSEUSgtMvRRcOAQ61eaARpyEx7xJlczAV2ZDE 131/4wthpq/Lm+rcUqeo/FgleDMUtQ8ijpNb4TGwWHRddFo/ONcgr2fuQ5N+Nsz88G7R 9gXGFsrNvTArHY4rNvHwW+XFKljY7zZWmbG1mD8upoE30BvsgXVDo9KLGRslYbCuSjU6 tb6w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Yf0/+QCn"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63da392csi21990870f8f.246.2026.11.16.09.13.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:13:36 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Yf0/+QCn"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=HXktWkJ2114rizS/W11oGeLhhCm9O1frLY2MA+lsoRo=; b=Yf0/+QCnn6g/ JpxoH8Hq5dwoxDDCSwXm6AlzbKQEm+GI0PezHnygx+eu9857mhc0xR2CGAobktkZIZTgada/mPei8 Psvii2UH41WC8XFxTyBbl+PJtXORa/xKGure90+c2JJwNQFgKY9+c1dlMFqGhqlwsJh618ZzEFn8t tWXDOdXoxD7ThfOQmpkjSZHcPdcAeb9IL/gWh9EJaK8gCdTw+DQFku8XpP8cqIXPT/islOq/QmsGN m46dnr6Sde+aCpNjCJrFA9eFwR4YufXPYeaoaVi9FAnC2AX0P/w8KISbaPvygn52heoI+BbxhiKOd FF89hfslf/KnXLXUPSSMjQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT0Cf-007dR4-0P; Mon, 16 Nov 2026 18:13:27 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Mirian Shilakadze In-Reply-To: <20261116061256.54472-2-mirian.shilakadze@virtuozzo.com> References: <20261116061256.54472-1-mirian.shilakadze@virtuozzo.com> <20261116061256.54472-2-mirian.shilakadze@virtuozzo.com> Date: Mon, 16 Nov 2026 18:13:33 +0100 Message-Id: <179484921365.861498.8601646536402367093.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1225; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=8Kc3zIgQbs/HOB3K9k+G0URpvtVZeqU81uhx1sJsUDM=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq+zm/3/kMiecKnELbhGum8/30utgB5PlQYw5+u WApYChQ7T6JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavs5vwAKCRBRlgpH+WFc KosiD/sFnSj2ezh/ie6ShZf/jK4hNgktmE6aB2O8eijr1Hkv+A5lP/PdrmYeuxnIXjqcYgxImwm Oqx9PJCBaYg38OJ3RWLOmJMKmEQTQctxEpEuyDMtSPCdyFDfPsryHR/2DcAcOgdLBAsBtdkubqW K23YSXCfbB/lDqGZENpZTgnfUv1IGLSatf7SP0EO5/qipQunVGjUvAe4WiOEOTsV5T7s3zbbHdt 9zrBOUSqyBKOUGlJOnfK+oOh3BqDx5P/jTx+mZmREz2FtWUgj1zBx/K4fKclyeOcWo4Fr/2ex8E IBuUGQLUbWZs9blVsVS30FEEIKgSqbpvuA/kTkneeMBQkCwhkrAvj3te4buYbrXo8pWhvhojdEn c8LcfWK0x1+MmpvikR7KLddvEsf4g3IuNzG1Cy4mXKh6zVTfUTZ7Y5rmYT4xBrgxGPIvjLqvzTQ DouOJVn0JFWSXhtu3X7hyFcNqkZ3Jaf9PG3JLdMj0ajVYDolNhf0EowAn67VZStFkokh4J5UkKJ ihnVLNOhU74hkvWyC/jbI2ijsGpNu4BX8/xhac3XoY8EB0HnrDPUKiIa9eHyeYyuHpGZvs93M1L fyA/84mjkYDQnHxFw1d/z8LCPkFWukzlklM3Z4KUKFGNDVZKixPwhARTvhN0B0cJe8CAklo24WD BNymvuHt7ztUTHw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 v2 1/3] fs: let the protection flags of a mount be locked from userspace X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Mon, 16 Nov 2026 10:12:52 +0400, Mirian Shilakadze wrote: > + kattr->lock_flags = (attr->attr_set | attr->attr_clr) & > + MOUNT_SETATTR_LOCK_FLAGS; > + if (kattr->lock_flags && !capable(CAP_SYS_ADMIN)) > + return -EPERM; > + if (attr->attr_clr & MOUNT_ATTR_VE_LOCK) > + return -EINVAL; > + if (kattr->lock_flags && kattr->recurse) > + return -EINVAL; Item 5 of the cover letter reply: give the reasons for the two choices here in the message. - The ve0 test: in the v1 review I asked to keep it. Dropping it is fine now that a lock cannot be dropped: host root that joined a container's ve can only add restrictions. One sentence says so. - AT_RECURSIVE: only the s_umount of this mount's superblock is held, submounts on other superblocks would reopen the remount race. Sashiko's point that a lock bit on an unset protection returns 0 and locks nothing needs no change: the message and the UAPI comment say a lock stands only where its protection is set, and MOUNT_ATTR_VE_LOCK relies on that to lock whatever is set. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel