From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1628A803F6 for ; Mon, 16 Nov 2026 17:19:12 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHHuct029221; Mon, 16 Nov 2026 20:17:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHHuct029221 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="FsgH9g/t" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHHtHM029197 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:17:55 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHHtHM029197 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-49d8ce126f6so2290146f8f.1 for ; Mon, 16 Nov 2026 09:17:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGL/DdFSxkp1IdRpqQjEugnDKfjLvApYZXjXhrQA4Ou5cv/xIl5y+YIV3fzpudJY1WRLrzRmA==@openvz.org X-Gm-Message-State: APuU4Z/9lzF3/LLr+l4p0Nhr5YnG3RE0MY5Jyxf7//x4UNga1HIs6ELW kEIPU3BkrtgQzMNnJHsjSsy+tK2POC57KcytzdgnoO5e0EubH+GAqHn121fy+pdvWfuRqHSkmqu VZw5SzSFwJBwBQGeiDz1qhplisVgftDS6+tE8WeCcjl/BOlyd98/CDA== X-Gm-Gg: AZFdTZdGVriApTYmQh4W+pFAKBSyNgaXMTrUTpdA749b4nSlZok3uQfUjC39KxfGBQs mV5REKPVPJUBdjeM1sKCs97ck932t2lgWmct/T1f7uA9xKpf5n8hZG6/i4+PEc20udJ/YmDQFNb vB2xesnedSEcYXZziPwypQL5f5WgS5yDz31/Kfo++P7unH/NBj5sQoqsoCCrZ/qBbGoEDq8CrJJ mlg5y+CCWIsOTCdaY0S7GPOVWgmGFLpVCLuLzz9wjb9YFNfH8+xVVNZGkT6Q0nM1RgIm+Ib6CUC BG9/Ks3PVEekL3o0HiaguB4hdomP053lGdrH+bytXWr8VMvAq2dWdhKldBUduP594vCg0IlEhI9 YDYqeTZpTBsDccDq4rQ== X-Received: by 2002:a05:6000:2886:b0:490:6e0f:a02e with SMTP id ffacd0b85a97d-49c70b05145mr25101142f8f.17.1794849474836; Mon, 16 Nov 2026 09:17:54 -0800 (PST) X-Received: by 2002:a05:6000:2886:b0:490:6e0f:a02e with SMTP id ffacd0b85a97d-49c70b05145mr25101084f8f.17.1794849474284; Mon, 16 Nov 2026 09:17:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849474; cv=none; d=google.com; s=arc-20260327; b=DOJxthWuOnagqdUBAINhIweRINwiZ9YJAlNSbVap8qPP1E/9G4v/mWT5TOG6i2/QKR AEZb3EhgbmybjukXgl7RGGSquBikotsxOoCuY0vB1lOnRyEfHcX48vNu01wts4XRAnRs 84JJc8hEOAGVAq+jWj3W+w37uoIrf4km99xoien9jAwszhmj2ViJEqd/QZUujjsSbF04 JJ3OfgpPUoiwvrVCZg7ObBBLaqX/2oISkG+cmc1cgcCE/tgEeTLEN4bZBHib7V984jBM Dhq31/wqY1/4tRDOQQ4U+K4FRI1nmHubk97A1HivaVU1D13yDUkbAtWz+WUveayJgNi1 eLNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=nK1XVB68RK3jd2FwwteUoOd0E7Zs6ILCRu7Dm7rqlwA=; fh=e1cf8n77z2da+N1ymO/d91hfoJ+J/34ch9kWx7ws6zY=; b=qXEOOMWIEY+DTf0mahI0bhHmoaSpX0ad1OJF5f1iQ+sSfrucTCDjSeARQjE9goCTcl Q9IaZXh6nt0///kxIGYDo1CjZ6YEON/0NEYz5puSL21G1dc5RA1vQqqbpNruw355Ch1f 2C+pr7Dr+wYCLt0LmhAcwPoCYRNDQaEHGw2fVBaNtWZPEvEWAsCDSFHerfLrvxS34t+c 01f84EVn+0I+G+5FFJuHc6nlbtCCgwaZIwYxygrHWQzoMrN8nZbBh/xVL01tUY2oQS/m s+hrJnyqqx+ETThRq+TOJR5RjKODBwehJeB/Xx2Fzw+n6sUYf7cLu9MmdaXzG1rOKXyF wZdA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="FsgH9g/t"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6473605esi23096541f8f.333.2026.11.16.09.17.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:17:54 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="FsgH9g/t"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=nK1XVB68RK3jd2FwwteUoOd0E7Zs6ILCRu7Dm7rqlwA=; b=FsgH9g/tKW05 T1DmFgx0PpMg+ZM9JcX2xLO9byfT1+eZ1AyKQ8QK2qwx8tnOB1NN/YSf5Z8Wq201ypPoN6oBAa/jP m9fBetF+nczft27fw/SaTTkXBox7JzdtcgOgpQForZkHOFqbbL4AlZpuITyqGslXnpC/KdX5+IH0V iUWzUNXHbWyFFugk77ds346Q7a110GwtqqcgnPBFzT5uhXRmG+G46GhTAWzvHn0kl9MRGMp7Cpdn1 jMBTFbGe4TgMN94jBw6w6WnH+Qa5H0aX5yzNU9JbFYTsH3vQT6RAzdicIvDTSZ7J4k9cJILMPFvy2 lihDFXTXVZ7U41NCs1oDvw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT0Go-007jJv-1r; Mon, 16 Nov 2026 18:17:45 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Mirian Shilakadze In-Reply-To: <20261116104552.102938-1-mirian.shilakadze@virtuozzo.com> References: <20261116104552.102938-1-mirian.shilakadze@virtuozzo.com> Date: Mon, 16 Nov 2026 18:17:50 +0100 Message-Id: <179484947038.861498.10218103446625210481.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2486; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=L7sh9qkbPPx+i3+Rl0jGqHOxF7F+M810VhDduWHZoME=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq+zq/8Djg2a7At7qaIjXKCRy8UQJbhFSH33zC9 kiDCG098XKJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavs6vwAKCRBRlgpH+WFc KpXGD/0boQ6PGfbmwjYeobv14mVUBEWW1CHoaZUv8zWAZmDou2dDBz1PlfFe6XxdS4bEZ5zTiiL XRYsq+3YqxCj5Y+KmN2XqErkk+WrA/6+m5o+CoITt1txrgdC6bmBh3qndBWLuzEc3z8p7XHEiOg 8vuu8uKu3YJz/dAwtdG3MXTZ5cQffwaDjdRKSCFQymxM2Zax30+kM5js/O1QG+g3Mibhl+Z1tap 2P13/T6D/9LCzo5h6TWULRHqh2azlrKv3e1rAr3vWj061dUoxzYm4gwL1Aj3meEfYwk63Nsrsg3 fy59aQ9ho5H5mWwqn6aPs3bGNa9Bb7GgnagA2fkH63mooEIf6oUJGrYKoIRnkKhUraEy7HCWbDn 8n1GgG0JVabtaYAmIQL82ftO2jXX+TjUZbndeBD12RaX3uQwF8j2/wtDgh1kgjlmNEEWnwY4s5j KTRB710uemIuofCj17MV4W0WKtCv2d7lUjviva6GEFJ1COBr8mvju/gkVt+A7lA+39jyanMmXGb 8tauRTQiUAlECH8bsRm6Jyz+MZo7Ef6C/8tN/OofHutMA09hS18rQ7W7rgI0YlHy76/flT1Rhh6 FzgX4Tfww8pHHjgag5tTRTjSU3/se9HDOrpr/B6A+GxLrzxivFXsVbb9vGuRtuIqomTPK+uBtXN vBLJ0K0dzwttGDw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Mon, 16 Nov 2026 14:45:43 +0400, Mirian Shilakadze wrote: > Mirian Shilakadze (6): > ve: tell ve_setup_task() which VE the task comes from > ve: hide only the tasks the host sends into a VE > ve: hide the tasks that set up a starting VE from the rest of it > cgroup: give the CT root file writes and hidden roots only to setup > tasks > fs: give the mount relaxations of a pseudosuper VE only to setup tasks > ve: give the remaining pseudosuper relaxations only to setup tasks The design holds: the setup mark reaches only what vzctl and CRIU run before an exec, every way into another task's fds goes through task_still_dumpable(), and no ve0 caller loses a relaxation. What to change for v2: 1. Patch 2 (and 3), code: a host task that moves from a starting VE straight into a running one keeps VD_VE_SETUP_TASK and is visible there. Keep it hidden, as it was before the series. Do not key this on the mm mark alone: CRIU-restored processes keep VD_VE_SETUP_TASK for life. 2. Patch 2, commit message: say why a container task must not get VD_VE_ENTER_TASK, and that a task entering its nested VE is no longer hidden there. 3. Patch 3, comments: the VD_VE_SETUP_TASK comment in mm_types.h says setup tasks are the only ones with the pseudosuper relaxations, which patch 5 makes untrue; the ve_current_is_pseudosuper() kernel-doc leaves out that it is true for ve0. 4. Patch 4, comment: the comment above ve_pseudosuper_write() still says dropping pseudosuper is allowed from any context. 5. Patch 5: do what Sashiko asked (the subject says "only to setup tasks" while the mount limit also lets VD_VE_ENTER_TASK through; a helper next to ve_current_is_pseudosuper() instead of the open-coded host_entered), and update the "In case of @is_pseudosuper set" comment in ve_devmnt_process(). 6. Patch 6, comment: devcgroup_legacy_check_permission() still says everything is allowed in pseudosuper state. 7. Cover letter: "vzctl and CRIU need no change, the vzctl start path was already fixed under VSTOR-151174" is two sentences glued with a comma, and the series also works with older libvzctl. Say what VSTOR-151174 changed or drop the clause. Put blank lines around the "- 1/6" list. Details are in the replies to the patches. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel