From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 17DED81835 for ; Mon, 16 Nov 2026 17:19:12 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHHx85029228; Mon, 16 Nov 2026 20:17:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHHx85029228 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="NBBYKebz" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHHtqx029199 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:17:55 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHHtqx029199 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-490d2ac331bso3488564f8f.0 for ; Mon, 16 Nov 2026 09:17:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErH1FiwqQ/wp/7REOPqkKlz0Pbwo6LROFaH+00DgUkQYm2UOfPnoam4MYtpgaaorjoKhVIoYpw==@openvz.org X-Gm-Message-State: APuU4Z8IeS9HdSE1j54GXEBlOws/sVQJZBQcXTYjkilmJ40JneZJTdQl KqAVnA0LaR+JivqK8RvIpKWtkzCZPtxhr0C3feXMn+GlR30zaye6Q4M982CFxqY4uEK+vJVerbF O5hdLXMzpWOH57AmlHv8C7Ltwj51tOSxJR4g/KZMdbFemQd0EPvvD+w== X-Gm-Gg: AZFdTZdWmEehBUbO92ogRYsA/r+L0LhiDVZ2UpXcZW+3YOlxw1OWFFHxgIilCyYU0HR /yR9X0SZXVJEN0QlloLJJ60Ndp3+8eJedMdskNau+f2Pi+8nbTnldM8O4INXzsag54B6xD/636+ fgJ/ycHBiryhzuIwWE76oL7TaV3g0JurWAtdtq/bKt48ce/4RnayBnYWcEerLWxOe/C/bg8h5zx JsTFumgqv2aBvML7g8myKcq3BnA+tBIcRaZA0GSNc73YK2nHcAaqlWVsP23CJQuD/weon+BKO8H yLIStSo497HpC+snQsnxRriYbMQgdb4deLto7K3vCc6k8qW9LKb9P0dbn209emUUoMUkMWBstXD 7X646OpTck5tYu9ER X-Received: by 2002:a05:6000:29d3:b0:499:3450:5b4c with SMTP id ffacd0b85a97d-49c72c9c7b4mr17032022f8f.51.1794849474814; Mon, 16 Nov 2026 09:17:54 -0800 (PST) X-Received: by 2002:a05:6000:29d3:b0:499:3450:5b4c with SMTP id ffacd0b85a97d-49c72c9c7b4mr17031976f8f.51.1794849474302; Mon, 16 Nov 2026 09:17:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849474; cv=none; d=google.com; s=arc-20260327; b=jWnMQzJfJKHwkwP06JfR3HNsa+82t/Y0Qn8b/zi7jM6vxfHq9PE2vweUlSs/cdQOGy gasmkEJCMPqepLhtE4m10KYYoiZjrY9I1sO7dbyHgntW3IPSdBlG5elQfVCeDrkqFA3C PQ/9vbPr0fMjdHJUGRSaqgw6eGCAHja4JDtrJYNkVmV/ZbeR7sv5QOkMGpsfF9ZQP0H/ er39TRTzj3CUSxrrzioWJDKxJ9egLYsW4GTihtn2bIkcFS3Oan5fvsJfk09DRNnlAt/t D8omeCeoOj+vU1sYmhG36a+RUn1mOnZQ5+enG0ZQdAsUQZpmfTdUtXaG/zWx+RqxFSaa ivhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=zD7+l0Fd1pooNxXE8PDxNhC4lw7Up2AzbxTvW3enKuY=; fh=e1cf8n77z2da+N1ymO/d91hfoJ+J/34ch9kWx7ws6zY=; b=C7Vr3j2YSiLOOb0edir8NypCFGQOFlFm3J5neq1SJKCAJPKtbWybUoAHdt+W0sKZtz tTfAae0dqrLono7KQh81/aKBKVG0M7i0WcSoRNj1zNYgeNLy2Zg4bZUAH2+0C+bp2w1n VOEQgDMrS5+jGfLsr0+sWqfVxOjWyVk/VRrNBrQRo4/3EEOJT5APxDEEq5PVCjmQyCIL RzA/k37idhFfUng8vMZxqTUAdJlFRX7UoO+yOjR5Vc+83TKkBFEfhPfPZi/iGj+lNbvV 7YbWJvalgi5ZL19+cTKJgJCJj5w5peWMSWs1wGOUWA8DwnByCjywLWBD3N6nbDioSfpu z/zA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NBBYKebz; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64a15805si24482416f8f.376.2026.11.16.09.17.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:17:54 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=NBBYKebz; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=zD7+l0Fd1pooNxXE8PDxNhC4lw7Up2AzbxTvW3enKuY=; b=NBBYKebzLFcU aMZVnsSSioFZjcLzXIBA279Z9cSrkpn+LMZSrljDf7H2boeVQXsE6v1RZQwWf3WsBNqIzWSIoGn1S JEmmKPuuEVPWcTBbwiYd2iVtIKjx+1CqeqFWCJh+lDdofp+ubQO9nALv12Ca0SC1cOsDXQVJvCGKu QMpoMSg0OZ+CPbfSHAwQaARRC0UaxY4lkGJUMikIaLBOZnMemHaJ76Yf8N1W9K17CMs+lhx9i9n6N HPzNLfcPCqcsz4O/QCrbbBNVFcJic47Xef+KtDmZqF5Z14jdezzzPJbr0fLPhIEqEppQONvUThmhD eosKQ6XTVx0zS6KgIK1xmQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT0Go-007jJv-2V; Mon, 16 Nov 2026 18:17:45 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Mirian Shilakadze In-Reply-To: <20261116104552.102938-3-mirian.shilakadze@virtuozzo.com> References: <20261116104552.102938-1-mirian.shilakadze@virtuozzo.com> <20261116104552.102938-3-mirian.shilakadze@virtuozzo.com> Date: Mon, 16 Nov 2026 18:17:50 +0100 Message-Id: <179484947038.861498.9006081141204598287.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1288; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=KgqGVOL29LFwxSx9R2OT51buJn6fRuzdTFQZVhmgJ/I=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq+zq/PITKMmwNDfxcw5g//a6yKSg84k1el4srF +4X/EP5aiuJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavs6vwAKCRBRlgpH+WFc KjsNEACdocxQanOc7OQJX+eiIYS6dyuQI9gHyobtKbveE0NgdHN+kQhrFxmhncZVz1JNbszpZfN fgXGKyEu3dd+BhnNE0JZwARj5E4A03LJ/wQ9piU+cqCiofl6IqiP+Y2Lb3EU0Nx2nwrUv9sMlM9 8xFJQuo6yq0O7XZJsmlgUBtJFsQksyLRK2085UtnykzOzUPztbSQNbu3Cl1DZ8iyUPUhsD3vkFZ Kj0nghLi2IcDW6lcSXOc1cyvbAxAssMpaIfNEWnKH63jcJ2MzGWjjihykxt5c3YTClCHfR4UCyi X2dEgiAP6Vqs5ayr/mg/TUUik+2efC6bN9aNXi2Of3FHhqjwnmX/y+lIRlqxnfv27Nfo0dU0sK4 LsPXCNq0DH0qtY2Lu69cL8fD28ylk3MK2XWsYv6qSh+0panu967NlPa2FXIURnjLEdYo+fHZOFx jc3JshG6672v2s65az5HoftzrcEJnyuGXaubGN0xxc/96pbnwOr5tpzui8j5yN1oIjmGPVUn14S tN/oxCIawgEPBL0mPiGgxafecpRULlsWi1YvC+ubKV4Bm1O2Fk5fJFmtsihUkRctVYm51Y1s1eB UUzx02pzEQ0WmwFPDrKE0Ssl+OCNT7dzP6PW4UFfDeC8c0FjFDbZVQHQ4cN0bZ1sk89xn8xUZm3 5JPxy8XEo/dyslQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 2/6] ve: hide only the tasks the host sends into a VE X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2. On Mon, 16 Nov 2026 14:45:45 +0400, Mirian Shilakadze wrote: > + if (task->mm && ve_is_super(old_ve) && ve->state != VE_STATE_STARTING) > task->mm->vps_dumpable = VD_VE_ENTER_TASK; Item 1 of the cover letter reply: keep a host task hidden when it moves from one VE into another. Why: setns() into a VE needs CAP_SYS_ADMIN only, so a host task in starting VE A can setns() into running VE B. old_ve is then A, not ve0, so the mark is left alone. With patch 3 the mm stays VD_VE_SETUP_TASK, B is not pseudosuper, ve_vps_dumpable() returns VD_PTRACE_COREDUMP, and B's root can ptrace the task and read its fds. Before the series it got VD_VE_ENTER_TASK on entering B. Only a hand-made flow does this, vzctl and CRIU always enter from ve0. > A > container task gets the mark too when it setns()es into its own VE, and > the mark goes to the mm, which it may share with another task. Item 2 of the cover letter reply: say why a container task must not get the mark, and that a task entering its nested VE is no longer hidden there. Why: the reader sees what changes but not what was wrong with it, and the nested VE case changes behaviour without a word. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel