From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9C63B8017D for ; Mon, 16 Nov 2026 17:25:52 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHOcXS029825; Mon, 16 Nov 2026 20:24:39 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHOcXS029825 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="vpGT0H6f" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHOb88029806 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:24:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHOb88029806 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4bb67b2c00cso262595e9.1 for ; Mon, 16 Nov 2026 09:24:37 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFe/Ssjbkk3hinLrlf1Km35CEnn6u7O8gqJJynuwGHi86gKK5n0zyU1v0F6AVWdSBl2BciiXg==@openvz.org X-Gm-Message-State: APuU4Z+Z5+78WEynb8sE/QfoVarSg0Xbfvr0I+K0n0XVT9QPNrZJ0KhX dyEsjaY4pUx9JiLvbd4bIALHY261fRh049E6SOIt4Fxc8WG1wIRWlvUYtuXA2RMH270Edu2xJm0 82HeX9jBNJGjQsKNNJzUvbzlQFag+0vKV2Ctrcn+2DuszkpxTpjJrTQ== X-Gm-Gg: AYBFou0yC4t/BuQHkkaC7WTpJCGZGzRaSs0RMzy8WDgh+v7Z4v+Kaqt+omNMXFnyFKz 5bKchgzuY4uPpwhIUJQAZPZSprpX6uXCFWMtJSSS5tycmKc5knvbehF2I2rLH2qfFaHKDsc90rY qxUdT+XIixaAG9l8Crz2TaDfFflbyYFPHYMpEbOK8yRyD8drj4wVsakbF9d6WydadZ1BqKGLInf uOCBG/RrsMJr7EembOE08RJ1LvTKmZ7p+hi6rJBl++lIDyi7O2mH0CaiaAf1Hx8P4SDv5lvUrFI ZMip20kpLbW7df7UAxtSYmTtFTH4BOE2FiCIwvvUq23e6Iwx9uZZDsWpe3Gimg6vYS2sxflklAL Ihd3T8YlVWKb8bKPB X-Received: by 2002:a05:600c:3ac6:b0:4ba:7a0:7b67 with SMTP id 5b1f17b1804b1-4bb783aeb29mr3796875e9.3.1794849877247; Mon, 16 Nov 2026 09:24:37 -0800 (PST) X-Received: by 2002:a05:600c:3ac6:b0:4ba:7a0:7b67 with SMTP id 5b1f17b1804b1-4bb783aeb29mr3796435e9.3.1794849876835; Mon, 16 Nov 2026 09:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849876; cv=none; d=google.com; s=arc-20260327; b=aGwL2ClssMizFxmPPflBdyTbj3O9sXNf+alDO2aROLQeQXufB3Fh8r2GC4QYZCg+xX CvrMVsShaaRTqvCwcAw0oMwzccKKOSI2MwpVwjDTWgumlDxZIZnvivkbsN9MUPhgBMVC hSY00A6Gq4QWvmm1IVGWk7aXHXAGOaYRwH/XYR7eY5oAxkukYu6bi/i+ynmGdq+4l1Fl YGls6acu3XP5XgPFQUCoVi32gcJ2P2L41RIPhD8zs19xYFP4RWS3IwUX97rIBRpS2/WX 6PqF4L5Iulz2SlHrDAmeTqCNerBmA3AecID/60RxANYYXSUw8JC+eIRcrMj/2TR+E77S O6rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=KkWmuJpfqaPsZjuuSAQ0NC1FoWEUuD18FKFXq0EaZ7c=; fh=YDx/sgeCfUIZ9eyfBjqETg92hV70ladS2omuMPCV2do=; b=e66CdBu5dzCpzuBlnL/8zf9UnRkpRKZ0bK9rgXLWiZSApTTrfxHispUpCBF5848/bn w5+yZQutzLs04SLQTF60/5EYiJLUDRBaUcUbjssn9gfyQYm9QG9i5JSE1p7xv+9Nz7XM FV7AEelaLNFyrCiVHjNUxBhWSpCTHXXmQRINU4yrGh2+uM0J2HOowROYJxoQksS6xD5g 8pSnG3BePnMpwBEZawgr3dFNuMfxeOfk3YjFlzlPAT3wSxmVwGkF3a97fT+72b2WoZUz 61iGnSZGthRu293Mo+yOHKfFvRT6xzLM1GMHr6jsybpwKnG0wDnkWQNNS+UOPgO46nDF WdWA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=vpGT0H6f; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c7f8dff3bsi22878563f8f.166.2026.11.16.09.24.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:24:36 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=vpGT0H6f; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=KkWmuJpfqaPsZjuuSAQ0NC1FoWEUuD18FKFXq0EaZ7c=; b=vpGT0H6fQPIl XakRnYEofXQRI8lclrSb0mCoL4eZ2DM/sLYdzkhHasC2MVxnNkc4zFHVRApdqnbs4aV3a/IAc4YQe EUlD3SoqG1vxMG+zFFZZYTFbFT3roHoZcSNGeIFGlYkzISbrJzi71UdgXE06tE8kO6pJubtxIilSo KJh37EuI1+ORdX67nDLSXaTW7IA3dbB2vhcQzGTUzjt2LXhb54efKrjehHk1D5N/rX8i17JzQ9mOH nadRLgx46PiwPTTBFYlx1/Zv304SjPcq9BI5FY1aC1wL1t0uSFosQDx3V3sSXywUpisG52FjJuXzv vNiflUEaoAU8hn9oQRgpPA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xT0NJ-007qNV-0N; Mon, 16 Nov 2026 18:24:27 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261116154119.2979718-1-alexander.ivanov@virtuozzo.com> References: <20261116154119.2979718-1-alexander.ivanov@virtuozzo.com> Date: Mon, 16 Nov 2026 18:24:27 +0100 Message-Id: <179484986789.861498.9914296104181809603.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2304; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=9rRx2WXbwqyEl/Jvv5yXCe4eiuqLJXGShdWxI9uRyOs=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq+zxRHMvHpk/suLkudYsexeeYbHabRym4fZFpB ZW8alCBY+CJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavs8UQAKCRBRlgpH+WFc Kj79D/9yjnrfiHYFxPUwBggDW5pOY9GWF7m1TRMYRUNWUn/E7zDP9/aSM3qQ2behhXIdNXTgdFD ZlAiWpFF+XxDE1RoXwrCFs67zoLt0e1R5iiC7oSHODprPUQ0vQN+AVtR8N45lKVYnuSShPLalox t94d/MctvsD0DXPc9GOXiulacAdcSHSWAUSxCtJDNbowBBgfv6utFIN7Wn4x1MD6fcn14ZgBrAA 7kSoahls4zNI3vqJEiwwMk4f5lOakirYeqAPdEt7qR3YsJIsqtzFu4adnjMxQvTnWtENYPUDWt9 2htmBpPjmuKPHMlBIXk0G8rpj8PwKyWRwW5iMEW4yXvXmzUL+bVW0TGyAh5yBGkVtpi0Q5BfhO3 Xgghl+CJ39eOENCVX9mvw2/xA8i3rNwh8KhKfdstgMzxXGMOMHaHcZ8uKPXMRZhAgEfitKxwfeH TH8lwfYLjU0dKGw0vDP4fi6QcqgPJWquy+DmZsr9vxIi+dQtroj3Tb90RJn+R6WgtU5ZBsN15NK OzIrN0PRlgm6UPRQcV5cRj6wQ9I5lgAt8uu5UST/mmDxM4UaMCEySV39wwzOdqyLkB+U1iGVlTC IWcEzo0qi0gJI0myGdx6oFB3Hq4fMBw4obWucz1NU0139IqgImdUtVzyz9vOnpEa3LlN7z7/nEJ 5O5NqZ5+62AqSsw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 0/9] dm-qcow2: support the werror/rerror policies for vhost-blk disks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v2 with the changes below. On Mon, 16 Nov 2026 16:41:10 +0100, Alexander Ivanov wrote: > Patch 8 requeues held requests to the dm queue on a noflush suspend, > so a table reload or a snapshot of a paused VM does not deliver the > error to the guest. The kernel side holds up: the locking, the timer and suspend handling, and the vhost-blk release fix all trace correctly. What is missing is the part that makes the series usable from userspace: 1. Series: QEMU's pause cannot work with held requests. On PAUSED and FINISH_MIGRATE vhost_blk_vm_state() calls vhost_blk_stop(), which detaches the backend; in the kernel that is vhost_blk_drop_backend() -> vhost_blk_flush(), which waits for every in-flight request, held ones included, with the BQL held. So the pause the IO_ERROR uevent is meant to trigger, virsh suspend and a migration all hang until resubmit or fail_held, and a timer retry that fails again holds the request again. Say how QEMU is to pause such a VM, and link the QEMU and libvirt series. 2. Cover letter and patch 8: ploop suspends with a flush suspend for a snapshot and for grow (ploop_suspend_device(), cmd(..., 0)), so with today's ploop a snapshot of a paused VM still delivers the error. Also dm_reload_imglist() does not pass error_policy, so any ploop reload resets the policy to the default. Name the ploop changes this needs, or drop the snapshot claim. 3. Patch 5, message: at this patch ENOSPC reads are still held (patch 3 keeps them), so "Only ENOSPC writes and flushes are held" and "reads are not held" are wrong until patch 7. 4. Patch 5, message: say that every dm-qcow2 device, CT disks included, now sends the uevent and gets a udev probe every 20 seconds while it stays full. 5. Patch 7, message: under the enospc policy only ENOSPC is held, so drop "whatever the error" (Sashiko). 6. Fixes tags: patch 1 and patch 4 6e2ec304689f ("dm-qcow2: Pause IO and notify about ENOSPC events"), patch 2 2f9926b51be7 ("dm-qcow2: Rename MERGE_QIOS_MAX"), patch 9 c57a98d65796 ("drivers/vhost: vhost-blk accelerator for virtio-blk guests"). -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel