OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v4 0/2] drivers/vhost/blk: add support for worker ioctls
Date: Mon, 16 Nov 2026 18:29:05 +0100	[thread overview]
Message-ID: <179485014529.861498.6648753358313571967.b4-review@b4> (raw)
In-Reply-To: <20261116085139.2848797-1-alexander.ivanov@virtuozzo.com>

I'm ready to apply this series, but only after the series
"drivers/vhost/blk: support VIRTIO_BLK_F_WRITE_ZEROES": its 1/2,
"drivers/vhost/blk: fix a flush hang on requests completed after
worker kill", is the hang fix I asked for on v1.

Then applying with these fixes on my side:
- patch 1 message: says that vhost_dev_flush() skipped these workers
  (attachment_cnt 0) and now waits for them; the use-after-free is
  tied to vhost-blk getting the worker ioctls in patch 2, since
  CONFIG_VHOST_SCSI is off in our kernels; the first paragraph split
- patch 2 message: VHOST_SET_FORK_FROM_OWNER before every
  VHOST_SET_OWNER, VHOST_RESET_OWNER goes back to kthread

On Mon, 16 Nov 2026 09:51:37 +0100, Alexander Ivanov wrote:
> Alexander Ivanov (2):
>   drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers
>   drivers/vhost/blk: add support for worker ioctls

The two series apply cleanly on top of each other in this order.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-16 17:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:51 Alexander Ivanov
2026-11-16  8:51 ` [Devel] [PATCH hci-8.1 v4 1/2] drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers Alexander Ivanov
2026-11-16  8:57   ` no-reply
2026-11-16  8:51 ` [Devel] [PATCH hci-8.1 v4 2/2] drivers/vhost/blk: add support for worker ioctls Alexander Ivanov
2026-11-16  8:57   ` no-reply
2026-11-16 17:29 ` Konstantin Khorenko [this message]
2026-11-17 14:40 ` [Devel] [PATCH hci-8.1 v4 0/2] " Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179485014529.861498.6648753358313571967.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=devel@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox