OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/3] mm/memcontrol: drop the unused update_lru_sizes()
Date: Tue, 17 Nov 2026 09:40:53 +0100	[thread overview]
Message-ID: <179490485331.1839806.10229568787094815941.b4-review@b4> (raw)
In-Reply-To: <20261028-b4-prep-khorenko-vstor-152197-numa-migrate-cleanup-v1-1-aa959eecd3fd@virtuozzo.com>

> It has had no caller since commit 3c6e0c1ac1d6 ("mm/memcontrol: use
> lruvec_del_folio() in memcg_numa_isolate_pages()"), and being static
> __always_inline it never drew a warning.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-152197
> 
> Feature: mm: interface to migrate memory between NUMA nodes upon userspace request

Should it also have:
Fixes: 810e6836a6dc9 ("mm/memcontrol: use lruvec_del_folio() in memcg_numa_isolate_pages()")

> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d8a87913ace37..a82d5e7bc8694 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3497,24 +3497,6 @@ static struct folio *memcg_numa_migrate_new_folio(struct folio *old_folio,
>  			     ms->target_nodes);
>  }
>  
> -/*
> - * Update LRU sizes after isolating pages. The LRU size updates must
> - * be complete before mem_cgroup_update_lru_size due to a santity check.
> - */
> -static __always_inline void update_lru_sizes(struct lruvec *lruvec,
> -			enum lru_list lru, unsigned long *nr_zone_taken)
> -{
> -	int zid;
> -
> -	for (zid = 0; zid < MAX_NR_ZONES; zid++) {
> -		if (!nr_zone_taken[zid])
> -			continue;
> -
> -		update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
> -	}
> -
> -}
> -
>  /*
>   * Isolate at most @nr_to_scan pages from @lruvec for further migration and
>   * store them in @dst. Returns the number of pages scanned. Return value of 0

Reviewed-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>

-- 
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-17  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:49 [Devel] [PATCH hci-8.1 0/3] mm/memcontrol: tidy up the memory.numa_migrate code Konstantin Khorenko
2026-10-28 13:49 ` [Devel] [PATCH hci-8.1 1/3] mm/memcontrol: drop the unused update_lru_sizes() Konstantin Khorenko
2026-11-17  8:40   ` Pavel Tikhomirov [this message]
2026-10-28 13:49 ` [Devel] [PATCH hci-8.1 2/3] mm/memcontrol: say where the numa_migrate code comes from Konstantin Khorenko
2026-11-17  8:40   ` Pavel Tikhomirov
2026-10-28 13:49 ` [Devel] [PATCH hci-8.1 3/3] mm/memcontrol: memory.numa_migrate MAX_SCAN counts folios Konstantin Khorenko
2026-11-17  8:40   ` Pavel Tikhomirov
2026-11-12 18:04 ` [Devel] [PATCH hci-8.1 0/3] mm/memcontrol: tidy up the memory.numa_migrate code Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179490485331.1839806.10229568787094815941.b4-review@b4 \
    --to=ptikhomirov@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox