From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0F96F803F6 for ; Tue, 17 Nov 2026 11:41:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHBeZ1D009176; Tue, 17 Nov 2026 14:40:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHBeZ1D009176 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="MFiNT1t5" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHBeSvl009159 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 14:40:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHBeSvl009159 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4915ba023d4so2052381f8f.0 for ; Tue, 17 Nov 2026 03:40:28 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFXhJIhjE6bfsNiJqMRsLEcpyhznuFsvKmx6ItE8tfWrdEewfVtSqwYiHSoy0N4jYE7ai4tgg==@openvz.org X-Gm-Message-State: APuU4Z/3xvm8aNcVW8vOXdMNwzlv3qXe8Do1Dlv7QxuevNFkG85YS3FW 1pFZIid6AQOIK6miLrI5oQUxez/Q5teQuxEP9nEMT1q6wTa03WtQp4UUDIO3OKv642U6s/6oR1b +zKmd775mfTXujPfowPczAruAxEpTpuk5w11bycXflJtKIyeARsIYdQ== X-Gm-Gg: AZFdTZe/ZGVbRyXafGVK24f4sJBfDk78NrS4ss+dXtcSwvilCp/W5GZZ/2RkHKlDlpv xiFl0RXkZuzCLP2/Fv5PEHXQn0PYVuTnl6ebLoduN+NKns9YTP5W/M0X/XJ9n/BSuIz2Bpewv57 1VYw66u1SZqcepjz1MwG2O3ITrheyqzM3CoenKkwMsjHQ+xB6pX4nlbdh/CoAVP0AkWtHGXB2Ko mjT2Yz3VVJbRu8d/6N5oB+6O00sCc847NbKv656iEs7miHh0G34HMVBfc28IR3N28b5iYNFnZX7 uQaCNyY5q1Z9+nU7cHTzjnSiFI+Hr/yoetmXh9edMSBPElYnpBTb6xE+E4VARTyYqRhyRqd5ALK MmmXzU2AG7hGfEG4IvQ== X-Received: by 2002:a05:6000:2288:b0:49c:6a45:ca33 with SMTP id ffacd0b85a97d-49c70ed923amr30261966f8f.9.1794915628476; Tue, 17 Nov 2026 03:40:28 -0800 (PST) X-Received: by 2002:a05:6000:2288:b0:49c:6a45:ca33 with SMTP id ffacd0b85a97d-49c70ed923amr30261912f8f.9.1794915627958; Tue, 17 Nov 2026 03:40:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794915627; cv=none; d=google.com; s=arc-20260327; b=N1oX0+GAtShvDyJUbGlLo+YtFV6qNAxgfnB2SyUnYuIhWPkRZC8ocJTbh7nN+RyngH PfnJrGyKqptDrqiW+htyCYXsjMO93Ukz3G7m8eNo6LxqNk/lf+PG1y/hVzKJP2m2dTok xlaNp5hHnamUQRiQc+kmHqzJWxCfT/6YipkLY4xsiBj22VyJZdJ9vGHlM7swq8o9L0pk wsPPJ6/X19jesOg+P9uB05NuLj5UbRWeInOKxcwnS8UhFejpKs/1h4K/pVPZwgvfu7gX fin/l8PrUMe4bEAv9KbFrB2kHzXsDer3s662dn72mX4s/Y2UsCZCBZkav6h0LN811h6/ 0O4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=04VcxjPDrxj7PFH1L+Vby15po4FeEhUpJEMDLXXmhKA=; fh=e1cf8n77z2da+N1ymO/d91hfoJ+J/34ch9kWx7ws6zY=; b=qe/1i4hbJcNH3/VEsVFI+Wt4VTcKFukVMiI/bVMnYLKunq3JMzj/UKTawj9WE3G5nv j8tfCa9wpxDoSjVr3I7u3c6JFzK8m94fYwgN4NM0d0GYPMHwe+7mnswEWt3BepC3w3oO 8HuLLQgKSqt13ygS4DnNhCSpu9Xc3mGdIHaJ+OEzTPJdEG4Uuk2RM0QuL9IlwO1459Dl bs4ZgUuiqmrXYOtSohAC55yanT8IevczK0MtjwhoxUvu9tkOdfdXXChNSYVB9bcQ0CQx OV1q+D8R8UnyF8PtH2IramwEL8lKC+TVQn71sXTJlGOt8eI9gutSnX5iIlUVNSdLj6Kq fOdw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MFiNT1t5; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c72ab133esi26439633f8f.335.2026.11.17.03.40.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 03:40:27 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MFiNT1t5; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=04VcxjPDrxj7PFH1L+Vby15po4FeEhUpJEMDLXXmhKA=; b=MFiNT1t53w71 n2hMgZlF1dJS6UbECfshMfZRDNSlFC+4pw+9vx/0h+xh7/WvMrzua/2BujbSOS88oCw8bpeTT+FIF g/8EK60EucA8/HkEQPuKKReSl9UD4Le7SWKSBbifRmPPiy9kPyDXUjnjWuvuVenq2UEW5d07TgBC+ MZhTaNww7De0TOIXw9Ds+AhkHg4VgX7tn13ShOpcRADpJ2/7BB7nRC8r/cEBAFOgMM3bcccG7uraL NJw5uYvzCFc8opXvrO4aUnr+tHxU1CEUVA/+QXwP4ImrMkmVXiqTVTpMzkjsDbVNX1NsEIBt/ai9d 2A8ZI9IIi/AjdPyMJNM+QA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTHTn-00B0jZ-0F; Tue, 17 Nov 2026 12:40:17 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Mirian Shilakadze In-Reply-To: <20261117101329.225854-1-mirian.shilakadze@virtuozzo.com> References: <20261117101329.225854-1-mirian.shilakadze@virtuozzo.com> Date: Tue, 17 Nov 2026 12:40:25 +0100 Message-Id: <179491562519.122512.7751819793782686092.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1650; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=nCKkD23rtP5Md3CB8L6EoXWlzYW9SU1reS+Tvcy/coo=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq/D0pqcJC/gZTNU9+WuXL0AMEKMdL9L1RA97YM GPRUGCEteCJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavw9KQAKCRBRlgpH+WFc KuYAEACNWNw3Iy7L/++xt4L1BvPy2DP18U9Xr+VOl94cdSmCTMx/PHNaFRBZj6qAlIxK5R8aCgS k45ccm68HO5sM9lkzxSQV9HpHehX5l8z6mk6kK/K8jtiEd/e3LBoWoRYBWPLKdcwwPneZI+PxGF QodbkslomuaXc2mDAPAC28RHiiP0mbnAvz0x06z65FafGPUKwrnCg5cse06d8guYN/e3hiautki zPpoB6uFqJowSffsoqU9SvE/gaQD9eWfwDZFlKZF69AEM6zIVfgGGukpHGPOx24nw/w3d3ptuLj Mda24zXi8gr2ab9O9ASSG4JfHYdC2tzjjkPNL7kiV/a1DFJ7iS0xyx38coHpiH6oCTnE/gbtjQx tqE+aGGpUUOMmcNPANBjv3H3g4nLhm3GB+WTTn1DixB+OBiKdhxvDaJINxeBY/1c6Sg7enmkpbV /crr+v33feF17ODckMytryupQxXPl4ArnR97bGJEx+Eux7h4qndnhJnqblkLbIHE0sMAT3NcKbW HTfv1aqPoDdWsIayk1FluOm1vZQdobcmKKSwp0SO6mIYN36GmAtG3b3JEByNCKFAaW/NaXBG7li 4G3RgIhNfpMNunKyBJ2OpPe9p1VXgTeHntq75jJBkVobvFxbZcHKPNUokdmOTfI3b1EHKNaLSeK hvzVtVvDWTZPoZw== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.2 v2 0/6] ve: give the pseudosuper privileges only to the tasks setting up a VE X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v3 with the changes below. On Tue, 17 Nov 2026 14:13:20 +0400, Mirian Shilakadze wrote: > This series marks the tasks the host sends into a starting VE as setup > tasks. Fork keeps the mark, exec drops it, and only a task coming from > the host gets it. All seven v1 items are done, and the 1/6 reordering of ve_setup_task() and the namespace put is right. What is left: 1. Patch 3, code: a host task that entered a starting VE and moves on to a running VE only after the first one cleared pseudosuper is no longer hidden there. ve_vps_dumpable(mm, old_ve) is then VD_PTRACE_COREDUMP, so nothing marks the mm, and the root of the running VE can read the task's fds. Before the series it got VD_VE_ENTER_TASK. Your test hops before the clear. Either close it or say in the 3/6 message that this case is not covered and why. 2. Patch 5, code: ve_try_reserve_mount() still checks ve_is_super(ve) in front of ve_current_is_host_task(), which is already true for ve0, and the comment below still says "pseudosuper cases" (Sashiko asked too). 3. Small text fixes: the second paragraph of the 3/6 message has five sentences, put the new one about tasks leaving a pseudosuper VE in its own; "one have to be" -> "one has to be" in the 4/6 comment; "ve0 never leaves it" in the ve_vps_dumpable() kernel-doc reads as the opposite of what the code does with ve0. 4. Cover letter change log: "a task that setns()es into its own VE keeps its mark" is not new, v1 kept it too. Thanks. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel