From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Vladimir Riabchun <vladimir.riabchun@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v8 0/6] Fix kernel crash in overlayfs
Date: Tue, 17 Nov 2026 15:49:00 +0100 [thread overview]
Message-ID: <179492694070.994824.11702311984402867249.b4-review@b4> (raw)
In-Reply-To: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com>
Applying with these fixes on my side:
- Feature lines: "ve: ve generic structures" on 1-3, "ve: CRIU
support" on 4 and 6 (instead of "ve/overlayfs", which does not
exist), "fix ms/overlayfs" on 5
- patch 2 message: "ve_capable and friends" -> ve_capable() and
ve_capable_noaudit(), plus one sentence that override_ve() refuses a
CT task any VE other than its own with -EPERM
- patch 3 message: init_cred == NULL means the VE was never started
- patch 5 message: the two mainline commits cited by 12-char sha and
subject instead of GitHub links, first paragraph reworded
- patch 6 message: the compile-error sentence limited to
ovl_override_creds() callers, with the ovl_creds() users named;
"returns" -> "saves", "would be handled further" -> "will be
handled"
On Mon, 16 Nov 2026 20:20:38 +0100, Vladimir Riabchun wrote:
> Vladimir Riabchun (6):
> ve: Remove STOPPED state
> ve: Introduce override_ve/revert_ve helpers
> ve: Defer ve creds drop until ve is completely destroyed
> ovl: Keep creator VE in overlayfs superblock
> ovl: Fix leaking fd references in ovl_copyfile
> ve/overlayfs: Override VE together with creds
The code is fine: the rebase onto the ve_name fix, the plain
ve_name(new_ve) print, the out_put_real label in ovl_copyfile() and
the "true" from ovl_lower_positive() all hold. The texts above are
what was left from my earlier rounds.
I did not add the Reviewed-by of Vasileios Almpanis: he gave it on v5,
and patches 2 and 6 were redesigned in v6. Vasileios, if you are fine
with v8, please reply with it.
The comments "ve isn't started" in kernel/capability.c and
net/netlink/af_netlink.c stay as they are; "ve was never started"
would be more exact, but it is not worth another round.
Thanks.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-17 14:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:20 Vladimir Riabchun
2026-11-16 19:20 ` [Devel] [PATCH hci-8.1 v8 1/6] ve: Remove STOPPED state Vladimir Riabchun
2026-11-16 19:25 ` no-reply
2026-11-16 19:20 ` [Devel] [PATCH hci-8.1 v8 2/6] ve: Introduce override_ve/revert_ve helpers Vladimir Riabchun
2026-11-16 19:27 ` no-reply
2026-11-16 20:05 ` Vladimir Riabchun
2026-11-16 19:20 ` [Devel] [PATCH hci-8.1 v8 3/6] ve: Defer ve creds drop until ve is completely destroyed Vladimir Riabchun
2026-11-16 19:27 ` no-reply
2026-11-16 19:20 ` [Devel] [PATCH hci-8.1 v8 4/6] ovl: Keep creator VE in overlayfs superblock Vladimir Riabchun
2026-11-16 19:28 ` no-reply
2026-11-17 14:49 ` Konstantin Khorenko
2026-11-16 19:20 ` [Devel] [PATCH hci-8.1 v8 5/6] ovl: Fix leaking fd references in ovl_copyfile Vladimir Riabchun
2026-11-16 19:28 ` no-reply
2026-11-16 20:03 ` Vladimir Riabchun
2026-11-16 19:20 ` [Devel] [PATCH hci-8.1 v8 6/6] ve/overlayfs: Override VE together with creds Vladimir Riabchun
2026-11-16 19:36 ` no-reply
2026-11-16 20:03 ` Vladimir Riabchun
2026-11-17 14:49 ` Konstantin Khorenko [this message]
2026-11-17 14:49 ` [Devel] [PATCH hci-8.1 v8 0/6] Fix kernel crash in overlayfs Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179492694070.994824.11702311984402867249.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=vladimir.riabchun@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox