From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.2] fs: forbid freezing and thawing file systems from a Container
Date: Tue, 17 Nov 2026 15:55:46 +0100 [thread overview]
Message-ID: <179492734654.994824.1573117257144276960.b4-review@b4> (raw)
In-Reply-To: <20261117-ct-fsfreeze-v1-1-23272094ba36@virtuozzo.com>
Applying with these fixes on my side:
- "CRIU can neither ptrace attach nor freeze them" -> "CRIU can
neither stop them under ptrace nor freeze them": PTRACE_SEIZE
itself succeeds, the task just never stops
- "most file systems a Container sees are not freezable at all" ->
"the only file systems a Container can freeze are ext4 and XFS it
mounted itself": the root disk is ext4 too, it is only mounted by
the host
On Tue, 17 Nov 2026 13:59:28 +0000, Vasileios Almpanis wrote:
> Nothing vital inside a Container is known to need it, and most file
> systems a Container sees are not freezable at all. So keep the
> existing check and return EPERM for FIFREEZE and FITHAW when called
> from a Container.
One more reason, no need to add it: before this patch a Container
could also FITHAW a file system mounted inside it while the host held
it frozen, e.g. during a dm suspend with lockfs for a snapshot.
A heads-up for tests: LTP df01 calls tst_fsfreeze on xfs. Where a test
suite runs it inside a Container on xfs, it now gets EPERM there.
Thanks.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-17 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:59 Vasileios Almpanis
2026-11-17 14:02 ` no-reply
2026-11-17 14:08 ` Pavel Tikhomirov
2026-11-17 14:55 ` Konstantin Khorenko [this message]
2026-11-17 14:55 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179492734654.994824.1573117257144276960.b4-review@b4 \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox