OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Alexey Kuznetsov <kuznet@virtuozzo.com>
Cc: azaitsev@virtuozzo.com, devel@openvz.org, kui.liu@virtuozzo.com
Subject: Re: [Devel] [PATCH hci-8.1] fs/fuse/pcs: fix problems in logging
Date: Tue, 17 Nov 2026 16:06:27 +0100	[thread overview]
Message-ID: <179492798753.994824.6796451394598992855.b4-review@b4> (raw)
In-Reply-To: <avxV5vl8EDa1S/OF@mops2>

Applying with these fixes on my side:
- message: a list of what changes in the logs, after the first
  paragraph
- "Affects: #ASUP-3693" -> the tracker URL; "Feature: vStorage" added

On Tue, 17 Nov 2026 21:25:58 +0800, Alexey Kuznetsov wrote:
> These fixes were done in user space long ago,
> but we forgot to do them in kernel: print correctly
> formatted client ID and show correct origin of
> error.

The message did not say what changes in the logs. I added:

  - NODE_FMT prints an id with PCS_NODE_ALT_MASK set (the kernel
    client, the origin of every XID) as "K<id>" instead of 2^63 plus
    the id.
  - The IO error line in cs_response_done() adds the id of the CS the
    request was sent to and the chunk uid, and drops the ireq pointer.
  - The cs_stats id column prints the raw id itself, since NODE_ARGS
    now expands to two arguments.

The code is fine. Sashiko's remark on the (unsigned long) casts does
not apply: vz10 builds no 32-bit kernels.

Thanks.

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  parent reply	other threads:[~2026-11-17 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:25 Alexey Kuznetsov
2026-11-17 13:30 ` no-reply
2026-11-17 15:06 ` Konstantin Khorenko [this message]
2026-11-17 15:06 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179492798753.994824.6796451394598992855.b4-review@b4 \
    --to=khorenko@virtuozzo.com \
    --cc=azaitsev@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=kui.liu@virtuozzo.com \
    --cc=kuznet@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox