From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A2728803BB for ; Tue, 17 Nov 2026 15:17:43 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHFGTvn010391; Tue, 17 Nov 2026 18:16:30 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHFGTvn010391 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="LkdVZUg6" Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHFGRGA010386 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 18:16:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHFGRGA010386 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-c42888c50c4so135893966b.0 for ; Tue, 17 Nov 2026 07:16:27 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGTDlyjDHtPZHY4nqkc9X/hUlKyZjVOJb3rz8IAiyXIa5x8s1QXBblxZIzezxyp8qKnfmg4bw==@openvz.org X-Gm-Message-State: APuU4Z9ADr/QBGHUqWVpMTmyTxbx0KNwdbBBu6Iv3Jnnkmc44YD/lch/ DIiKXGJ8xr+74SZ6XRZXOq8eS0aSsWMWoEEr7f6u1LULoMWwMMgMRM9wgrzMACNCx+2GZnvzXxn S043gSB7a2BI6dAcHwxiRiJP64U8RFOuAIiqRRocjyiXzYWv1Xtzxsw== X-Gm-Gg: AYBFou3V/nx1b2/tzfB9z3q/ILIuoCrkLsvpfch2rfnzFoCamMnEhQcWl3m07YWvev/ YSuA43YaN7AS3LIvqJx1XYGYoNogNzrB3u50I/6shKby5GTRSNq1xz5qiXJ6buV0vW4oU2eHyg0 VKOG4XzuXbU5G5/xasDKAgbyh5lw8SkKo4YRYa/sQxEziayrfbxnplWed472TlMQdZd+Kdh54D3 /6NLNoNZLPKA48ZoCRY1KmRV7yWINjz70gicVjBPLxfKnmWoIffDe5p0WM3DHNQOkSYA+FxRYCS cKdBIFXV1q4/v4vRjDubtlulRIPfuUFr1vFUCzveNpYFltKGg0cP6ytnI+nnu4fZ5iF+FJhfJcD 0aKfOOFjzJ78aaAw1oQ== X-Received: by 2002:a17:907:ea8d:b0:c50:8d2b:4391 with SMTP id a640c23a62f3a-c50963d4702mr1134589766b.37.1794928587228; Tue, 17 Nov 2026 07:16:27 -0800 (PST) X-Received: by 2002:a17:907:ea8d:b0:c50:8d2b:4391 with SMTP id a640c23a62f3a-c50963d4702mr1134585566b.37.1794928586626; Tue, 17 Nov 2026 07:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794928586; cv=none; d=google.com; s=arc-20260327; b=CYmABpRncw52r4srOrg1RLG5JZ+gKvkISIPpU42SbP7MzyJZUO/HNLpb2pK+M2o5l0 FE2c4SOxJDS/1VUp26Sn5QObP9GZ1wXBais6bHLWrrdGcmS+rGYzbJNB1CCNydsfqENu kpXU8C2vmiYf5Re3gL8+o7VH8YVcUWlAI9j7KouZjqnBt/PNnVetgg+TkS9paSyMvTZR DOTLuBcTsngQCV6fYzZ6wuBb7usju9f49NeRrkGBoLVmLK6fIiYIbFXeP0yrJcXtYdIt sYO8Wwdj4Q1aFL5thA3u0jPwCk8w99Y336/Nc3/EM1lrqN/eSPSduS24g22pLMJ0Mh4p kAjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=8vM70/dYpnKXbB/WgvJFOa81J+z7EEkQY+/1ysjwNrM=; fh=CTF2GHyV+XdzB5TROrdG4fdLri6JSHNOBC+LNuNq5bA=; b=hw+z7BiIcmou4JaLGXFQMrF5Fu+L17+wCcdo3dUTzLGpZl/rod4G96BISPtipI9bSr eMb/A/BcIlQltbjUTIENlWHgHwf2lRrwJX9tb5O1hGuhqGXfOOkA6VmkAjjVaStK5zER YwJXky9lo5hInib6t7SWOJJCypwzvHja8Bl+7wd1r2zMBYcfRhgBUoHJrmfVnoJTKHeM IZPAZtPuEe8wDCVNClaCY3qHP1kkDrwjEM/voO50vcjFOjaLlrA2kEHAUwt3s0BT6Esb dHH+puVjp9wUx4CuZ5I7uUTxl2b3Yo8oGid3DVaMYto9G9aiDyPji+KWhxZgu5YFXQEY tLfg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LkdVZUg6; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4a5c9043857si775684f8f.53.2026.11.17.07.16.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 07:16:26 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LkdVZUg6; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=8vM70/dYpnKXbB/WgvJFOa81J+z7EEkQY+/1ysjwNrM=; b=LkdVZUg68kIa M+/ZLoDzGad7d+WFqxaLU8nNdUEn/erxokXTFXpalLu3NUClbXkIiVqS/lzq4AlcQoicPJiHWBlxF lY9+woG9hoSNHFAcZ0TME5qE9l9pmlp7f0Nzn2eQqCImZoIpXh8UZSHWPJzuE56Se09mykQlgULCm /sbFjXDzvCL/c3R1jKfNGOjqISg2pIumPU+wUOLyaERxll/fugVrVtGl5xtGyAEJuU2DFFzpiVkdo /4ZITx12U9+JmGD/yfOu+cwwY5NJSy8fcvB86u6RFHdO0czwjbrb4DD3JWIQAarYwiEI4WuB4FiXE EQHe/gwPg0F9B/jeuHD9ow==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTKqn-00F6Kj-2K; Tue, 17 Nov 2026 16:16:16 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Eva Kurchatova In-Reply-To: <20261117055049.810192-1-eva.kurchatova@virtuozzo.com> References: <20261117055049.810192-1-eva.kurchatova@virtuozzo.com> Date: Tue, 17 Nov 2026 16:16:24 +0100 Message-Id: <179492858457.994824.7876765289087346628.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1307; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=Yq9+3MNZ2IPSrWeLLZvSwaDfe+bGkqn99dlWlzmdNiY=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq/G/JwWywUGRuA75VdABMys4nP8FAuaP/MyBrQ esPGEZF7oyJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavxvyQAKCRBRlgpH+WFc Kjp/D/wOys9EckU1S5xnIJOsjk+AvyhR5VrbnZnHOpeLSj0jLXTvzlFd8tjU2hdOZogiJtF9dBm ZNYaSPT0i1DmIR41wLIGA2FDrilPeY3dgqjCRKFblLHZJ+HnDdh56epVTqzoaVlDHRo4Z2ZrmMj TjiMM+I5N11sjOvMNSZURAGA/0sTMH3/JImJPK0BFgrASGKbzR5yVlDNgvMytLEh3kGWYIC0RQy Nk8PuYGS9jSRQckUmXqT671dyNbzfFqIam3nT4n2FaL6QfU2oILYlce0j2AAjPOntcndOx+Vn8e v4kUmxkIqsXl6Ays2zfnqkwjq+kuIEXm16s5NQgACwqMglCJggML9B41ZPuJ7AmKipek5d/GsMx 2YOCS13MyH1JItsppHM0LUMhaYGb8272fgn6f2v4RcziTflh9757G4bonpg87+ZbyQ33ghW3clM 9n9/IEWbT+ZM6uel+b18rqsI434Tbwxd5aq0WsE1XrSSaCoa6REOD57CMYGDzvXoEj6DSOvum3h 4HiL+fVTl8YIoj7ljgkfmQ/ic7N8s3GPtuozRsFn71xoIX/JORU3d/CeHb4kA9q0pyplfi1S9TV mUoGDgQ4yQQGb93PSTg4p340s7JNUGnrcYqHjnDWa+eW2d6s00YYI1tvwbOSHofpctvBnNDWmj9 iWG1FuYpz1TVpcQ== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] ms/tracefs: fix a leak in eventfs_create_events_dir() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Applying as is. On Tue, 17 Nov 2026 07:50:39 +0200, Eva Kurchatova wrote: > If we have LOCKDOWN_TRACEFS, the function bails out - *after* > having locked the parent directory and without bothering to > undo that. Just check it before tracefs_start_creating()... The backport is the 6.12.y commit as is, and the leak is in our tree. Separate patches, not needed for this one: 1. The other fix of VSTOR-155413, 14f7f52629d91 ("tracefs: Fix default permissions not being applied on initial mount"), is still missing: tracefs_fill_super() does not apply the mount options, so the tracefs root comes up 0755 instead of 0700. Please send it too. https://virtuozzo.atlassian.net/browse/VSTOR-155413 2. Same in mainline: on lockdown eventfs_create_events_dir() returns NULL, create_event_toplevel_files() checks only IS_ERR(), and removing that instance calls eventfs_remove_events_dir(NULL), which dereferences it in get_root_inode(). Before this patch the case hung on the leaked lock, now rmdir oopses. It needs root and a lockdown change racing with the instance creation. To be fixed upstream first, I created a task for it: https://virtuozzo.atlassian.net/browse/VSTOR-155526 Thanks. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel