From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 7D38681AC3 for ; Tue, 17 Nov 2026 18:24:35 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHINKL9011982; Tue, 17 Nov 2026 21:23:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHINKL9011982 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Bjdsgz/2" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHIN6MW011943 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 21:23:06 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHIN6MW011943 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-492b5408dedso31575f8f.3 for ; Tue, 17 Nov 2026 10:23:06 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEwapVk3kApLGIeNT2SRO1yM9GXeYLxB3EFdojJdDIWD7iZTaIKfbYturEycQ927Xf6Bhn4pg==@openvz.org X-Gm-Message-State: APuU4Z9IDLiARZ1TKVWnjE9FNOoQXO6f2qJ17sXzEo1OOsGaMSH14LWa GACMUl63xpWfT4wiaHeTINUs1kNY7PTo7IJrMyW1wOP+RuP2mDM3nQbFf/OoAxcS6jSIUnlZhz1 giu6Euq3umC70LEkqhTPnGmq/FKeK2hoaBlPZ20V+VAu/cVmWyhIhKg== X-Gm-Gg: AZFdTZcibxnqiTyGcm3oGB+3r7kvWGGNp7mKJziNxlYtGaEqt2WtseFybzsumJT4BdJ 605KsdMDP2hI8BZAD7TLFYcziLS9neT7jW1sUUSsbD8EgJPvB/v3k01yt8uDHtxrpoHAyTQ2O/U MWiM2MtFWpB1uqfwirAqTHmDOV96wsBVE6ELSUOjE8/4lBYUKEqHO31y4H2PKn8moGwAz1uJO+U AqkCpSHRQBitjDLKU9N2BebT0umw6U8lMHYKGYH0mtxQfNP52+aFIXchdxE7pn0mK6XDbKwhCkf 58XOwRZItx4lqSvvxrGNYKZAh9HZ/OnKzGuvxNxFiNoYHWQIov3KbPYLcAG+jzV99Wd0j8rLgA5 HzfC6BunDib1QRKF9YQ== X-Received: by 2002:a05:6000:4612:b0:488:88ec:59c3 with SMTP id ffacd0b85a97d-4a6389ec4bfmr656398f8f.14.1794939786088; Tue, 17 Nov 2026 10:23:06 -0800 (PST) X-Received: by 2002:a05:6000:4612:b0:488:88ec:59c3 with SMTP id ffacd0b85a97d-4a6389ec4bfmr656356f8f.14.1794939785669; Tue, 17 Nov 2026 10:23:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794939785; cv=none; d=google.com; s=arc-20260327; b=DOJ/ulkdVHeY0RlWXI5ZmgRNQyhpjSMjcSOjkk0YnMmybYmXLFMGhTEeyvqrWpdh9M EC2U1Q2pdiOBk5WfE82CHZqwDwN+CoMsNhFMDKUI2qe/pYRcyhX9eR70IkbtHmNlDf04 RMJ/Qz101BgatkrO+Ppb1hoAZy5873KqxRoUVk5tdqM8mpIt7XP9ds3dDGL+pftipk8v pB/AlEZ6cDc27FuCURAio5qdIuiXRyzz2kcf8/JS4DEnG7KPF1FKN8ATisKrVRVTVg2W Nl8iTmgOM5LPdW+T49aybQHm4nHnUbrxQY6EB/mhhxte1OoFCYvz2AsYjC3nB/zEU3R/ EM4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:mime-version:dkim-signature; bh=OyY77U+0QhDu6Cm1l1+hTB4dKAdb/doVubCGMXDHSrw=; fh=YDx/sgeCfUIZ9eyfBjqETg92hV70ladS2omuMPCV2do=; b=s3rTIPBmhpSnIoRbeq2S/0bOyJixCKG6k6YMOjtY+1x3viY01CCtOkNcr87QG9mCvx C7GjXp2mwKMSBwR8IZJIhfFIdRaOEZqryw++lODXW9Z7kwT+o9CCPJGctMqL0GBCCi0/ fjpL+4sjfozXPYfOo0lILb7PCpgG6XEEyinkLO3zVUI67XVR4hNNywWalVFMs9gdEQyJ yqoQhoP9zjveIkiUvtVaE6ANlivt3P6IwHi+AvX92HJN3er3TFqfM7LtsUaDREnZ4ffG WEaTFRwptb3/Uaql/EHN3GnbEoNlF0F4ksmkbCn5uvc2U3pN/NC8kQ/mY9ODLCJA4acK kniQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Bjdsgz/2"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4a6574b1783si152818f8f.144.2026.11.17.10.23.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 10:23:05 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="Bjdsgz/2"; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Date:From:Subject:Content-Type: MIME-Version; bh=OyY77U+0QhDu6Cm1l1+hTB4dKAdb/doVubCGMXDHSrw=; b=Bjdsgz/2fntl pHrD8+g2//Q5yEhJ51myJrI4BmD3DswZ4oE4npE1O7WGhklirnPuoX0dY5odWApGdVtcTwbmJfgXV N0khPOatDp6dtvO3rgwiiGSfUTmCr4+dkXqMKbyue047s9I6rrv8ptzQHc915Y6mrvpo6/zJFaa39 T0RM7B78c2rt/tyfuViY+ELxXw4WTgaNqsPfOO5tC0iwojkxnOcV0CMoGrS2d4WmoLFQJawhi9DyJ +5CLIoav9ayawEIxipTHWYr9T5B/yvlmLgjMfvCRJMtrwsFsRX3cUeiAWnPKgOh9GfcYLV51SwOVd f8QOLjmPkJlJ1SCMyonbzw==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTNlQ-0012zS-1u; Tue, 17 Nov 2026 19:22:55 +0100 MIME-Version: 1.0 From: Konstantin Khorenko To: Alexander Ivanov In-Reply-To: <20261117171743.3216794-8-alexander.ivanov@virtuozzo.com> References: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> <20261117171743.3216794-8-alexander.ivanov@virtuozzo.com> Date: Tue, 17 Nov 2026 19:23:02 +0100 Message-Id: <179493978229.173269.9890153384890679861.b4-review@b4> X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=688; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=kRYWA09ziVArSQlu9uglPyCXnvaVEC//nJ5UME8yErg=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBq/JuHiOs0I6nxnID5ZWBIZfQMjM2fm/+APVIgk IZCJMwb4V6JAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCavybhwAKCRBRlgpH+WFc KtPqEADHBOvOyQx2+DTjfe3oSu6Xm7fYNvgIdrJ4UDMttSMMyO1C6lOMnFY/cRJj2Lg4/44QOAP Vqrc5OUAbPe/KsOApfQRtuqK3m+YTbt79xblPcW0ovoZUrnmJXorUZ6DXSx26cKF5b4pTZnWvle ICS4FuMDz2YE0luSm5tI6mhRMlLtu+cnGzlXak//kUaYXjIxgQMI3xntJUkpE+9TuwRCnwgaD6H Hvlpk+th3/B9u4rJZBSXm6x0+iXIoGSMpbPotjwNkvixUTYjnpZI40UaGoGfqkXIGzdNSKScR12 jAtZdgDgiXz3NKUAes4GM/ROSaWG9VlVR1YWBGGR19fzW/h+qVlyCqoPYRrD0kH94uQxboFCjEE /LmAdzkc76p6l7h0+z9alB5mEu+U2T7lUZDGDSouMBhBoeHyfP1llUsJcPuUPPhy63kw6ezYD3n 1a7VgNKZBgk3e2AJOb0JumHz10XDDNDYT5LVddSa2chZR/i9KMNBoq9Lp9NkE9UqZApJfx/Y3eP qhzVLD4RXa3F1cBEM1Yd+bXqU+b1SvDdM18xaXMc8kLQOmP+ZUkuzrPdNGMpc/emxwR93ttUHOU 7bPtMYy8koIcVqQB2A+ejQRRYJjYPnpsLO2ag8C6mdSPv52q71BKwDNrlGdHhvVfvv1ByO1NiYc O6gHdJ9ZatFSbTA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v7 07/10] dm-ploop: fix use-after-free on the last inflight_md decrement X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org I won't apply this version, please send v8 with the changes below. On Tue, 17 Nov 2026 18:17:41 +0100, Alexander Ivanov wrote: > +/* > + * Waiters do not act on zero inflight_md without holding inflight_md_wq.lock, > + * so the ploop stays valid while we hold it. Once we drop it, the ploop may > + * be freed, so this must be the last access to it. > + */ Item 5 of the cover letter reply: the wait added to ploop_postsuspend() in 9/10 acts on zero without the lock. It is safe because ploop_destroy(), the only place that frees the ploop, takes the lock; the comment should say that. Item 8: Fixes: d1a1e5108aeb. -- Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel