From: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Subject: [Devel] [PATCH VZ10 4/6] drivers/md/dm-qcow2: fix seek skip to the next L2 table
Date: Mon, 10 Aug 2026 15:29:58 +0300 [thread overview]
Message-ID: <20260810123000.19834-5-andrey.zhadchenko@virtuozzo.com> (raw)
In-Reply-To: <20260810123000.19834-1-andrey.zhadchenko@virtuozzo.com>
get_next_l2() adds the number of remaining clusters to the current
sector, so for a position which is not cluster aligned (e.g. the
llseek offset itself) the result overshoots the L2 table boundary by
the in-cluster offset.
Compute the boundary from the cluster index instead of adding to the
current position.
https://virtuozzo.atlassian.net/browse/VSTOR-139407
Feature: dm-qcow2: block device over QCOW2 files driver
Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
---
drivers/md/dm-qcow2-map.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c
index d6d15b04215c6..776e89fc4eb1b 100644
--- a/drivers/md/dm-qcow2-map.c
+++ b/drivers/md/dm-qcow2-map.c
@@ -4405,12 +4405,12 @@ static struct qio *free_seek_qio_ret_higher(struct qio *qio)
static inline sector_t get_next_l2(struct qio *qio)
{
struct qcow2 *qcow2 = qio->qcow2;
- loff_t start, add;
+ u64 base_l2, add;
- start = to_bytes(qio->bi_iter.bi_sector);
- add = qcow2->l2_entries - (start / qcow2->clu_size) % qcow2->l2_entries;
+ base_l2 = to_bytes(qio->bi_iter.bi_sector) / qcow2->clu_size;
+ add = qcow2->l2_entries - base_l2 % qcow2->l2_entries;
- return qio->bi_iter.bi_sector + (qcow2->clu_size / to_bytes(1)) * add;
+ return to_sector((base_l2 + add) * qcow2->clu_size);
}
static inline sector_t get_next_clu(struct qio *qio)
--
2.43.5
next prev parent reply other threads:[~2026-08-10 12:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 12:29 [Devel] [PATCH VZ10 0/6] dm-qcow: lseek improvements Andrey Zhadchenko
2026-08-10 12:29 ` [Devel] [PATCH VZ10 1/6] drivers/md/dm-qcow2: fix lower delta seek window clamp Andrey Zhadchenko
2026-08-10 12:29 ` [Devel] [PATCH VZ10 2/6] drivers/md/dm-qcow2: keep seek parse window within limit Andrey Zhadchenko
2026-08-14 9:55 ` Pavel Tikhomirov
2026-08-14 10:26 ` Andrey Zhadchenko
2026-08-10 12:29 ` [Devel] [PATCH VZ10 3/6] drivers/md/dm-qcow2: fix seek constant comparison Andrey Zhadchenko
2026-08-10 12:29 ` Andrey Zhadchenko [this message]
2026-08-14 10:25 ` [Devel] [PATCH VZ10 4/6] drivers/md/dm-qcow2: fix seek skip to the next L2 table Pavel Tikhomirov
2026-08-14 10:33 ` Andrey Zhadchenko
2026-08-10 12:29 ` [Devel] [PATCH VZ10 5/6] drivers/md/dm-qcow2: scan lower delta in one pass over empty L1 entry Andrey Zhadchenko
2026-08-14 11:09 ` Pavel Tikhomirov
2026-08-14 12:00 ` Andrey Zhadchenko
2026-08-10 12:30 ` [Devel] [PATCH VZ10 6/6] drivers/md/dm-qcow2: seek unallocated L2 entries in one pass within md Andrey Zhadchenko
2026-08-12 12:42 ` Vasileios Almpanis
2026-08-12 12:50 ` Andrey Zhadchenko
2026-08-14 11:55 ` [Devel] [PATCH VZ10 0/6] dm-qcow: lseek improvements Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810123000.19834-5-andrey.zhadchenko@virtuozzo.com \
--to=andrey.zhadchenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox