OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: [Devel] [PATCH RHEL10 COMMIT] selftests: net: l2tp: ensure required modules are loaded
Date: Tue, 11 Aug 2026 21:24:56 +0200	[thread overview]
Message-ID: <202608111924.67BJOuro117050@f0.sw.ru> (raw)
In-Reply-To: <20260104015028.55859-3-aleksey.oladko@virtuozzo.com>

The commit is pushed to "branch-rh10-6.12.0-211.39.1.16.x.vz10-ovz" and will appear at git at bitbucket.org:openvz/vzkernel.git
after rh10-6.12.0-211.39.1.16.3.vz10
------>
commit 77604b60d0e87b5df9bfaa21fb4acf457fe65345
Author: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Date:   Sun Jan 4 01:50:26 2026 +0000

    selftests: net: l2tp: ensure required modules are loaded
    
    The net kselftest l2tp.sh fails when the required l2tp kernel modules
    are not loaded beforehand: the test aborts in setup(), which runs under
    "set -e", and not a single testcase is executed:
    
      # ./l2tp.sh
      RTNETLINK answers: No such file or directory
      Error talking to the kernel
    
    The kernel does try to load the modules on demand, but
    l2tp_netlink/l2tp_eth/l2tp_ip/l2tp_ip6 modules are blacklisted and
    cannot be autoloaded.
    See https://access.redhat.com/articles/3760101 for the rationale.
    
    So load the required modules explicitly by name before running the
    tests, and skip the test if they are not available.
    
    Loading l2tp_eth and l2tp_ip6 is enough, module dependencies pull in
    l2tp_netlink, l2tp_core and l2tp_ip.
    
    With the modules loaded l2tp.sh passes all of its 16 testcases.
    
    https://virtuozzo.atlassian.net/browse/VSTOR-121804
    Feature: Fix selftests
    Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
---
 tools/testing/selftests/net/l2tp.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/net/l2tp.sh b/tools/testing/selftests/net/l2tp.sh
index 88de7166c8ae9..0927056b92689 100755
--- a/tools/testing/selftests/net/l2tp.sh
+++ b/tools/testing/selftests/net/l2tp.sh
@@ -369,6 +369,9 @@ do
 	esac
 done
 
+modprobe l2tp_eth || exit $ksft_skip
+modprobe l2tp_ip6 || exit $ksft_skip
+
 run_tests
 cleanup
 

           reply	other threads:[~2026-08-11 19:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20260104015028.55859-3-aleksey.oladko@virtuozzo.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608111924.67BJOuro117050@f0.sw.ru \
    --to=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox