From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khorenko Date: Mon, 24 Aug 2026 12:57:51 +0200 Subject: [Devel] [PATCH vz10 v2] selftests/nci: skip when the virtual NCI device is absent In-Reply-To: <20260821150733.793496-1-eva.kurchatova@virtuozzo.com> References: <20260821150733.793496-1-eva.kurchatova@virtuozzo.com> Message-ID: <20260824105751.437824-1-khorenko@virtuozzo.com> List-Id: From: Eva Kurchatova All 8 tests fail in setup without CONFIG_NFC_VIRTUAL_NCI. Skip only when the device node is missing, so that a real open() failure, EPERM or EBUSY, still fails the test instead of being reported as a skip. https://virtuozzo.atlassian.net/browse/VSTOR-142445 Feature: fix selftests Signed-off-by: Eva Kurchatova Signed-off-by: Konstantin Khorenko --- Changes in v2: - skip only when the device node itself is missing (errno == ENOENT). v1 skipped on any open() failure, so a real problem such as EPERM or EBUSY was reported as a skip instead of a failure. As a side effect the following ASSERT_GT() is reachable again and no longer dead code. - commit message: explain why the skip is narrowed to a missing node. tools/testing/selftests/nci/nci_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c index 1562aa7d60b0..c6fcfffc768d 100644 --- a/tools/testing/selftests/nci/nci_dev.c +++ b/tools/testing/selftests/nci/nci_dev.c @@ -419,6 +419,8 @@ FIXTURE_SETUP(NCI) ASSERT_NE(self->fid, -1); self->virtual_nci_fd = open("/dev/virtual_nci", O_RDWR); + if (self->virtual_nci_fd < 0 && errno == ENOENT) + SKIP(return, "virtual NCI device is not available"); ASSERT_GT(self->virtual_nci_fd, -1); rc = setsockopt(self->sd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &event_group, -- 2.47.1