OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Konstantin Khorenko <khorenko@virtuozzo.com>
Subject: [Devel] [PATCH RHEL10 COMMIT] selftests/nci: skip when the virtual NCI device is absent
Date: Mon, 24 Aug 2026 12:58:36 +0200	[thread overview]
Message-ID: <202608241058.67OAwa9I437944@hci8VM.finist.virtuozzo.com> (raw)
In-Reply-To: <20260824105751.437824-1-khorenko@virtuozzo.com>

The commit is pushed to "branch-rh10-6.12.0-211.39.1.16.x.vz10-ovz" and will appear at git at bitbucket.org:openvz/vzkernel.git
after rh10-6.12.0-211.39.1.16.8.vz10
------>
commit b8239000cd0692224a6384c55a8d03c9f02f63d2
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Date:   Fri Aug 21 18:07:32 2026 +0300

    selftests/nci: skip when the virtual NCI device is absent
    
    All 8 tests fail in setup without CONFIG_NFC_VIRTUAL_NCI.
    
    Skip only when the device node is missing, so that a real open()
    failure, EPERM or EBUSY, still fails the test instead of being
    reported as a skip.
    
    https://virtuozzo.atlassian.net/browse/VSTOR-142445
    Feature: fix selftests
    Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
    Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
---
 tools/testing/selftests/nci/nci_dev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
index 1562aa7d60b0..c6fcfffc768d 100644
--- a/tools/testing/selftests/nci/nci_dev.c
+++ b/tools/testing/selftests/nci/nci_dev.c
@@ -419,6 +419,8 @@ FIXTURE_SETUP(NCI)
 	ASSERT_NE(self->fid, -1);
 
 	self->virtual_nci_fd = open("/dev/virtual_nci", O_RDWR);
+	if (self->virtual_nci_fd < 0 && errno == ENOENT)
+		SKIP(return, "virtual NCI device is not available");
 	ASSERT_GT(self->virtual_nci_fd, -1);
 
 	rc = setsockopt(self->sd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &event_group,

      reply	other threads:[~2026-08-24 10:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 15:07 [Devel] [PATCH vz10] " Eva Kurchatova
2026-08-24 10:57 ` [Devel] [PATCH vz10 v2] " Konstantin Khorenko
2026-08-24 10:58   ` Konstantin Khorenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608241058.67OAwa9I437944@hci8VM.finist.virtuozzo.com \
    --to=khorenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox