From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khorenko Date: Mon, 24 Aug 2026 14:39:37 +0200 Subject: [Devel] [PATCH vz10 v2] selftests/tdx: skip when the TDX guest device is absent In-Reply-To: <20260821150706.793224-1-eva.kurchatova@virtuozzo.com> References: <20260821150706.793224-1-eva.kurchatova@virtuozzo.com> Message-ID: <20260824123937.442700-1-khorenko@virtuozzo.com> List-Id: From: Eva Kurchatova verify_report fails outside a TDX guest, where /dev/tdx_guest does not exist. Skip only when the device node is missing, so that a real open() failure, EPERM or EBUSY, still fails the test instead of being reported as a skip. https://virtuozzo.atlassian.net/browse/VSTOR-142444 Feature: fix selftests Signed-off-by: Eva Kurchatova Signed-off-by: Konstantin Khorenko --- Changes in v2: - skip only when the device node itself is missing (errno == ENOENT). v1 skipped on any open() failure, so a real problem such as EPERM or EBUSY was reported as a skip instead of a failure. As a side effect the following ASSERT_LT() is reachable again and no longer dead code. - commit message: explain why the skip is narrowed to a missing node. tools/testing/selftests/tdx/tdx_guest_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/tdx/tdx_guest_test.c b/tools/testing/selftests/tdx/tdx_guest_test.c index 81d8cb88ea1a..612005b10f7c 100644 --- a/tools/testing/selftests/tdx/tdx_guest_test.c +++ b/tools/testing/selftests/tdx/tdx_guest_test.c @@ -135,6 +135,8 @@ TEST(verify_report) int devfd, i; devfd = open(TDX_GUEST_DEVNAME, O_RDWR | O_SYNC); + if (devfd < 0 && errno == ENOENT) + SKIP(return, "TDX guest device is not available"); ASSERT_LT(0, devfd); /* Generate sample report data */ -- 2.47.1