From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 25CF6802FA for ; Mon, 31 Aug 2026 22:37:55 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 67VMaeK5030454; Tue, 1 Sep 2026 01:36:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 67VMaeK5030454 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="R2DjoS8Y" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 67VMaYHP030437 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 1 Sep 2026 01:36:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 67VMaYHP030437 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-47f6db77430so2076655f8f.0 for ; Mon, 31 Aug 2026 15:36:34 -0700 (PDT) X-Gm-Message-State: AFuF++k6oBuGWGhzYxAE/QDUtPYpKKKa3i7tOKxNOg9KAQRcmP4UcPgi i1NiIbeLUix/heRu+AAgehzKjBMwM9eIUX2SaGte6jrLm2OdUrG0ZPtNcUIQOSDvsla1pKHexLv HiAPugTUAafwYXg6bGbuv7C6G94wWEuj5LTbWl5zfgndaL+W5gtWFJA== X-Gm-Gg: AYBFou0P5/iO9ZopCa8k+y+fIjoOhsiMR8jlJXnAOReHe6KYiWQUJax6XgMogjKziHm MRzhkrNks5QORA4r0oj1ZuEoxiHh81tBJCT652RccB5P/Wew9Bxr3m7feFmxssmWi5C8QopEtGQ Kbs/EFM0v7h269b6AqyVU3WEQjsNlTZcKGMCp7fdPzlhWYPWtl6YDSxEj3cD5YcwPdaHYU1Jm4p P0LLp9eG2atgPkWBOAVN+h6kB+5lGVsLfFOW9Flf0qgGYPI0httDe1YH0v0nsxr5Erkrvm9Z5O7 2WBfZ/DHvZymu2ZcKSm/QVQGg+KcyNuzL4IBpbhZRsWJCm9ojGDYgH8+Xr6KT66qDoUYHbDQCDZ V/AVI2PYL4tE2vBc4JdmgaY8i X-Received: by 2002:a05:6000:46cb:b0:484:3600:35b2 with SMTP id ffacd0b85a97d-48440fcee03mr5464266f8f.5.1788215794598; Mon, 31 Aug 2026 15:36:34 -0700 (PDT) X-Received: by 2002:a05:6000:46cb:b0:484:3600:35b2 with SMTP id ffacd0b85a97d-48440fcee03mr5464227f8f.5.1788215794159; Mon, 31 Aug 2026 15:36:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1788215794; cv=none; d=google.com; s=arc-20260327; b=oJuUGEcx6PeyRk+0KgG12RO8y5yR3/iUhnTLisIrM9h7RpsNVBjG4jzK8SOAvHfmNb f1okAjevNSOe8I3VMvOVKCnzj/zuhkkbtTGyZdOmMWT5UhjiEhU1KIzVF/MaurxisOG4 PRqDED/0szq52evDX9iUpwwklFXK3xNN3EzC3BkiKj4qm2fS+Tyf6VI0xGhGGvIyW561 dsVTGHLIwBt3IKXzsWRCt4tDEHn407Rze4DwqSD+CV6A0CS1pr/fl1WdZcIg+/g7rkfN LDi0UStMiiru9P4yrXn/P+hyW9fCaEprol3LUpQx8NkuxXieqZF9ipAsNczIfNxldaP5 +K4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=hSD+rU6A7ObhpDTn8lw+ccfvCyk/09zDLRd6r0yU4jM=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=AG6dza33ECABdso2+xjZYgpykv/nsEjSzem+Jr7R58mi8LyRNG+Qsl0rZumG2/Kwjn lKvRR/Rm8pMELFsrrxZnTOV4eXQi9VVurf6K/6UuR5pW3BzRUx9w7ij7L20ZNtuPQZOS hHYPTCrWZziaHS6uT8ukmwqxUnb6vH6XAMl9v0U84kqsrCI5jE48W9pfIJgKVmWfQUbS sdvl4Vf8umsJgnp6tUqqm12Xj+8bUvwpTjNYxS/h32ZQuwu2iSJczoJQ4cXCaaEHHZfU MTzhkdUI3S8JWDWMh3Tak6s+zMsOteJOcpx0/opzW4ez7RKn9E1JNar8+qgFXZU40d9/ UuHw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=R2DjoS8Y; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48442d86a74si587492f8f.381.2026.08.31.15.36.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 15:36:34 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=R2DjoS8Y; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=hSD+rU6A7ObhpDTn8lw+ccfvCyk/09zDLRd6r0yU4jM=; b=R2DjoS8Yxck8 bjWqCLLREJCd4J5WJPaomnWyHgCg3nooFt9wAjjPSOGvLgJyYVkb0Bl/SknvUOFS6q990rLcBdu+Q TbWtNyAFYT/AhxKXSumlQN5qLbYvZ6y1kjFFsEq6WK6IST7qNt7UPrazc+n0tb8Ypufr6aFsDoYDs NtZsD+0NoZsnWi4XpFX1Gpjz+Ju0E/Orgmrfqh3lvHX/hgkp0PhDp4aJKuynVIqCm4MsXWXKs00iM bWuwZyOb9McTv3j/W0e1r7JDLzwQA8YfR9smh451w+QcPTHsgY88u/yLHcImU2BuUcxvoVGiKRYnf UdjouKTeav10J8hzvCD10g==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x1AZr-009V6h-0P; Tue, 01 Sep 2026 00:36:24 +0200 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Tue, 1 Sep 2026 01:36:23 +0300 Message-ID: <20260831223631.1637488-2-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831223631.1637488-1-eva.kurchatova@virtuozzo.com> References: <20260831223631.1637488-1-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH vz10 2/3] selftests: cgroup: give the O_TMPFILE open in get_temp_fd() a mode X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org O_TMPFILE, like O_CREAT, needs the third argument. Without it glibc refuses the call at compile time as soon as fortification is on: In function 'open', inlined from 'get_temp_fd' at cgroup_util.c:24:9: /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments cgroup/Makefile builds with "-Wall -pthread" and the fortify checks take effect only once the compiler optimises, so the cgroup target builds. kvm includes ../cgroup/lib/libcgroup.mk and does build with -O2, so the shared object fails there and takes the whole kvm target with it. Building with -D_FORTIFY_SOURCE=3, as distributions commonly do, therefore loses every kvm test rather than anything in cgroup. Fixes: 844934d16dbc ("selftests/cgroup: move get_temp_fd() to the shared cgroup lib") https://virtuozzo.atlassian.net/browse/VSTOR-139672 Feature: fix selftests Signed-off-by: Eva Kurchatova --- tools/testing/selftests/cgroup/lib/cgroup_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cgroup/lib/cgroup_util.c b/tools/testing/selftests/cgroup/lib/cgroup_util.c index 9a677fdf0bf6..8f996b54849e 100644 --- a/tools/testing/selftests/cgroup/lib/cgroup_util.c +++ b/tools/testing/selftests/cgroup/lib/cgroup_util.c @@ -21,7 +21,7 @@ int get_temp_fd(void) { - return open(".", O_TMPFILE | O_RDWR | O_EXCL); + return open(".", O_TMPFILE | O_RDWR | O_EXCL, 0600); } /* Returns read len on success, or -errno on failure. */ -- 2.55.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel