From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 534FE8015D for ; Thu, 10 Sep 2026 03:19:18 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68A3Hx2f023099; Thu, 10 Sep 2026 06:18:00 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68A3Hx2f023099 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="OMbNTMxs" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68A3HvDq023091 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 10 Sep 2026 06:17:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68A3HvDq023091 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48597bbd963so4539937f8f.2 for ; Wed, 09 Sep 2026 20:17:57 -0700 (PDT) X-Gm-Message-State: AFuF++lLsdsoAVpD/D15Ghd+XwlLcigx+mxq6W0czdonCDNOzgV+KiFZ C7Dj3XHNKadISGN0HKpgb+cHX2LyRjd88s3vaUgmGsOHcLVmfzaTODBb6LLd2eSGCbQGk+KcEnT N/GpfWcamWaHFDD5aPdPbNTuAFzm8lvJfkLGpdfySdq8hvFode0tiPg== X-Gm-Gg: AYBFou1ruvBLz3YI0gHxxFfat7zo8z/sHk/xYzYI6/JabnvOfROZFBsvZF1uSuYSQrg KD/14PKzYpaS/6Yiy5qIznwLtABFRfCj4zuijKVZ7KlcWPexH8n/hjNunTFqccBPI6yYgJSWEA3 oJ59mZM8naVSesn+vvlnwN5OWo6BRhK+sNbaX83LkbyOX9PdhvfeAmGApworI2rLCR4nYhalRxG bSSYkkZ0eU4iewDUmVM3NG5ie8OczNXx1gdN9NuqchzmYuXgd1n2RVAlxdpr7xfzLEF0sJyvtL9 bJcDQADx3ykG6ph7rixN24dF539MN2U3ApTLz1PvP4O3Rda6Gb7anDt53GoOtXOiymNRJ4dpifV uf8TnbPwjyxWDlP9KtTUH/42h/w== X-Received: by 2002:a5d:59c1:0:b0:485:a306:1f40 with SMTP id ffacd0b85a97d-485c23d0ad2mr9593273f8f.13.1789010277535; Wed, 09 Sep 2026 20:17:57 -0700 (PDT) X-Received: by 2002:a5d:59c1:0:b0:485:a306:1f40 with SMTP id ffacd0b85a97d-485c23d0ad2mr9593201f8f.13.1789010277088; Wed, 09 Sep 2026 20:17:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789010277; cv=none; d=google.com; s=arc-20260327; b=hnaWDrj0iIu6g+WvJ8LKCmR5hlGNZYTzX78Q4L93QFzHIMCW3L/JbVAQSScW91SBLv R3WKdbwfbY2tO0+caNwH6PwLvqKHiw8Vow5uxlu+eUd6Eo8Sz+NhrstYizBvZOAfEX5/ h/R4yUwqGKqwJ98h2/M2jZikU8FArVYiEscbBn2m1CXuMPYOt4UtvBn8r5bFkTnRHmGD /ClTCTLpZDN/vOP3fGFDNyWcBXdcuGEncy+bwXvbO5IX8HlEtra2fG9hVqEfBDl3FzWB +a0OS2SLJIoWnkW30owsbnJ8TNllHBwT9P/pYduc+JIFQvCEqiYH8bos0+EPR2sLMErS M2xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=Zmb/iQupBSazIZ4Q071tWjfZZB8HXYqdAPzjJzrwIMU=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=axpL3kQT7cDZeSO0/aX24vX406ObeX/5ERgwjG5vt+jizUsQkp35hkddKD0gMMS7eY W2bKxrbZT6HKv/s4v/CI9Lp3Wab6WTsQ7ObCM6NPLAIQkmxGKQDOVz/RnkKExIPeoiNk d6DEWAxq6Mw8k+yT/TFvMyUr1P768x9UJ5AP6P8r5YY2271HXMRzxPwAF07h7W6UXjey MqcxyP6KfEDCe4ygm8sXcz0dT8A/XO5Np61xfQgLFTPVxJn2sHR+YJcxvSnrZ/A3YPqO j3fKi9BRj3bnGO33Y/EmMpwXddY0o+c69LgtabvyrH3ABGfiRtwTErNBCEu7D00VECmw YfDw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OMbNTMxs; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4858beac626si37546548f8f.336.2026.09.09.20.17.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 20:17:57 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OMbNTMxs; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=Zmb/iQupBSazIZ4Q071tWjfZZB8HXYqdAPzjJzrwIMU=; b=OMbNTMxsetsK HWSMQ7aoTRXH7KXrrKDkqL8B14lPeoi0urmptP4rDhnYaAcz7Ug0PHZx+oH2K/ZKsxGvRkdDQwAk2 rXTm3CfterprqBwwNsgNnJ8lF+oSc6RE51OuGXuwTOTzkQVNY/Z2hIm0UKxwUDG/u3zZ+l/X5bqbm VrxUAP1nA+8RajSFQ7MvQqSd1+DW9P49SQKcEddjku3rwAU227NNjIdwjWbdZ9c6/mPpWuEeIbi9n UaEBieUpx7feD6U3ZGNLoCN8E8Zp6DkDHXq9GZlPDidW9wMHCFn7uXIFwQ3JFYIDdz/zVW0KgbKEE aYpKNwwdTg3zkyYA2zlOsA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1x4VFr-002fSX-3A; Thu, 10 Sep 2026 05:17:55 +0200 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Thu, 10 Sep 2026 06:17:52 +0300 Message-ID: <20260910031755.397386-1-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH vz10 v2 1/2] selftests: pstore: skip when no backend is registered X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org An unregistered pstore backend reads back "(null)", and every latter check fails. This also contradicts the pstore_crash_test documentation. Fix by skipping an unregistered backend in common_tests https://virtuozzo.atlassian.net/browse/VSTOR-142447 Feature: fix selftests Signed-off-by: Eva Kurchatova --- tools/testing/selftests/pstore/common_tests | 15 +++++++++++++-- .../selftests/pstore/pstore_post_reboot_tests | 2 -- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/pstore/common_tests b/tools/testing/selftests/pstore/common_tests index 4509f0cc9c91..71cd4473f45a 100755 --- a/tools/testing/selftests/pstore/common_tests +++ b/tools/testing/selftests/pstore/common_tests @@ -55,6 +55,8 @@ operate_files() { # tested value, files, operation # Parameters TEST_STRING_PATTERN="Testing pstore: uuid=" +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 UUID=`cat /proc/sys/kernel/random/uuid` TOP_DIR=`absdir $0` LOG_DIR=$TOP_DIR/logs/`date +%Y%m%d-%H%M%S`_${UUID}/ @@ -74,8 +76,17 @@ prlog "=== Pstore unit tests (`basename $0`) ===" prlog "UUID="$UUID prlog -n "Checking pstore backend is registered ... " -backend=`cat /sys/module/pstore/parameters/backend` -show_result $? +# A tristate pstore leaves no parameter file at all when it is not built +# or not loaded, and an unregistered backend reads back as "(null)". +backend=`cat /sys/module/pstore/parameters/backend 2>/dev/null` +if [ -z "$backend" ] || [ "$backend" = "(null)" ]; then + prlog "SKIP" + prlog -e "\tbackend=${backend:-}" + prlog -e "\tcmdline=`cat /proc/cmdline`" + prlog "pstore backend is not registered, skipping" + exit $ksft_skip +fi +show_result 0 prlog -e "\tbackend=${backend}" prlog -e "\tcmdline=`cat /proc/cmdline`" if [ $rc -ne 0 ]; then diff --git a/tools/testing/selftests/pstore/pstore_post_reboot_tests b/tools/testing/selftests/pstore/pstore_post_reboot_tests index d6da5e86efbf..a5464407f5b2 100755 --- a/tools/testing/selftests/pstore/pstore_post_reboot_tests +++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests @@ -7,8 +7,6 @@ # Written by Hiraku Toyooka # -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 . ./common_tests -- 2.55.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel