[Devel] [PATCH hci-8.1 v3 0/2] selftests: pstore: fix backend/frontend skip

[Eva Kurchatova <eva.kurchatova@virtuozzo.com>]

Patchset for task https://virtuozzo.atlassian.net/browse/VSTOR-142447.

Changes in v3:

1/2:
- Print "ok" with prlog once the backend check has passed.
  This can never set rc, so the "if [ $rc -ne 0 ]" exit below it was
  unreachable; drop it.
- Drop one of the two blank lines left in pstore_post_reboot_tests
  where ksft_skip was defined.
- Rewrite the message: the existing check tests the exit status of
  cat, not the value it reads, which is why it passes on an
  unregistered backend. "latter" -> "later".
- Cut the comment above the check to one line.

2/2:
- Cut the comment to one line, the reason is in the message.
- Carries Konstantin's Reviewed-by from v2.

Link to v2: https://lists.openvz.org/pipermail/devel/2026-September/085069.html

Changes in v2:

1/2:
- Fix the verdict of the existing backend check in place instead of
  appending a second check at the end of common_tests, so the output
  no longer says "ok" and then skips.
- Skip where the parameter file is absent as well: pstore is tristate,
  and a module that is not loaded leaves no file.
- Keep the backend and cmdline diagnostics in the skip case.
- Write the test as [ ] || [ ], -o inside [ ] is obsolete.
- Define ksft_skip in common_tests, with the canonical comment, and
  drop the copy in pstore_post_reboot_tests.

2/2:
- New patch, split out as asked in the review of v1: the console and
  pmsg frontends are separate options from the backend and need skips
  of their own.

Link to v1: https://lists.openvz.org/pipermail/devel/2026-September/084981.html

Eva Kurchatova (2):
  selftests: pstore: skip when no backend is registered
  selftests: pstore: skip the frontends the kernel does not have

 tools/testing/selftests/pstore/common_tests    | 17 ++++++++++++-----
 .../selftests/pstore/pstore_post_reboot_tests  |  3 ---
 tools/testing/selftests/pstore/pstore_tests    | 18 ++++++++++++------
 3 files changed, 24 insertions(+), 14 deletions(-)

-- 
2.55.0

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel