From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A4E2D802A7 for ; Mon, 28 Sep 2026 15:04:48 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68SF3RkR010501; Mon, 28 Sep 2026 18:03:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68SF3RkR010501 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="TL9uBWeN" Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68SF3PgL010497 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 28 Sep 2026 18:03:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68SF3PgL010497 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49fff093efcso23590045e9.1 for ; Mon, 28 Sep 2026 08:03:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBy1IAw7y9WgbKnPJRob8Q26U24HJgi8Ov60bhrIOthZePl3OczPX0sg48/4MNb12LZt8Uy2og==@openvz.org X-Gm-Message-State: AFuF++lh4ngIU2vG5XH1DHHpUaWrTGW9dZR1OyxvEkoXZAeKRJMnMlr0 hLYDwP1wpfCt5iqzYPSDBrzzTkdV0b2UxSLOvC3waO5eHY6yaNcVrPl3iMGbB5l4QVoS2WlDFyu PMaNp7U7XG6QsV+a2CimA+okzJL9Gs+ncTSm0o4lOTYPlhLpr5yG2iQ== X-Gm-Gg: AYBFou0o3ieufkHGFMfk1m1nBS0GBaUvdaKdk8rfVhrCtEliZ6fyNkK56+ArWyuaPcx /vYLrJUdt9h+HbG+wBCOipq3QqXpfwaAJU4F7cDPpx2V8k+7Uiildec9VRaqt/WREw7QuLC37Cy AhxDGjP1LI7p3RPknZDDab1nNiOKHjGAw1v+ieCJGnK10tQ0p1aDXP0y2EHol/bMl6cj85NaA4e wm6GSef8F1NqQOQpBHKfswhnF53gpaNrcg04LUiJBxBxDuB6XSKBMspFd7ObMq81sC+AS5z1m8E MBraAwK7RpeLxjb0Mwa+bcCDdrV4YgwSe+s5vyL1ikBiKXknWdVQQ9wxhPxYeoMjrdCXO8kTRiM /Ukv1mb4gSoT/j86G X-Received: by 2002:a05:600c:8718:b0:49c:fa21:1c84 with SMTP id 5b1f17b1804b1-49fe7bba7e7mr216239145e9.25.1790607805457; Mon, 28 Sep 2026 08:03:25 -0700 (PDT) X-Received: by 2002:a05:600c:8718:b0:49c:fa21:1c84 with SMTP id 5b1f17b1804b1-49fe7bba7e7mr216238365e9.25.1790607804711; Mon, 28 Sep 2026 08:03:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790607804; cv=none; d=google.com; s=arc-20260327; b=UMTV1sTIiowWOimBqp/DkDacPyVfamLNNMxLR53ezdhno73ATcorDijwGk701LbMNi P/BGH5D73e8nx4DlZ1IC970dah1msHk4KgEyQMn0EA2w8KHqU4U2t1zMZ8lt2qa/d8aj dfGlmy6skvO6hBH+U8cHChExopQuXBLFWnKjUhz+nEKbQY/wRF3vsmJ9+Yw+ltDYbs5b iEiSw2EMAXk0oa3L/TDdU3VCq3GeGAEXbQ2EksPH/ZkJsqRgEjv/+/ZFbjQ3JP4Oe8za 9aUexPviN2F8VG1vVUwSyuc6XtOyRYqflwPGmsRr4GQ1LiWpHkZN11FTGohqsIhHD3Ey uOvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:dkim-signature; bh=/6wlvEJfgL/S1nGMDkNZDge9G0R+aPdlfumpMaSXll4=; fh=9+nDjKmImzZ2OGcc76ajOPc+Ar87TcSuIOkIlr4DXaM=; b=bafsk8K4x+rMyKFZZ4pZZgqLj8c7rMMWg/pvnCdFOr7VYzccT6FVWnyTzUWtdIAOTp d2gNgzrkwusGHIU0X5i0ghajZpR2MldwmsCkhcyRFOky3l5EcQODMFzkw7eW1eEI+3ZF OzsuHyKDL6SSXrDGPbOlPl7MXn7oyTkw6JpLWCZ6SUThi+5RyVUwrp5XX0RBEI+neypf U6UtEAhOb3ctRG5HHMx+p5jT33RI9KUwlDc++mb38fW7I7Rllr05pQGhFHJKNrkcgcEk Apmqf942ftEexAZTZce513EDTBtNgitlEagAz+0lxdRsYR3AGhDuQBzC1UKeFgNIT1vc mkeg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=TL9uBWeN; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4887a861dbesi21422288f8f.330.2026.09.28.08.03.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 08:03:24 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=TL9uBWeN; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=/6wlvEJfgL/S1nGMDkNZDge9G0R+aPdlfumpMaSXll4=; b=TL9uBWeN/wnEjxCMjDZ 6mwsXY2EvdnXT8m8eEiafYaglycR/l1w/c0Jtt2gup/7cMLp75PKbi25NDa+8TpjkSGNYXzv+4RSP 6avfVhMzUOsmpIDzxUAp7vPLgRKkLjbcxYW+aswBbd09/4FARwDyPlYrXVog7hAjnY9kGrlebc59x bHffKHLkokYvTlnjCdZW5wblguMpLdMhKzn39/MxWh0CkZNF4+3XeCLAjVMB6kKp0nKa7pzi/CXp2 9Vxu9Vdn9BqUoO3MxOIiOKtyk2m0p4svSA3siD0akrs+h+k0bsiJC0G9yhQ+AKSxPVesXIjECEQus dW7wJChI81Vk9QA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xBCpz-004fd7-1g; Mon, 28 Sep 2026 17:03:15 +0200 From: Konstantin Khorenko Date: Mon, 28 Sep 2026 17:03:18 +0200 MIME-Version: 1.0 Message-Id: <20260928-prep-kh-vstor-141673-kio-read-ack-order-v1-1-6069e78cac95@virtuozzo.com> X-B4-Tracking: v=1; b=H4sIALWBumoC/yWNQQ6CMBBFr0Jm7SRtbah4FcOitIOMTSiZIjES7 m7V5fvJf2+HQsJU4NrsILRx4TxX0KcGwuTnOyHHymCUaVVnLrgILZgm3MqaBbXVrTtj4oxCPqI PCbNEEuzGYAarolXOQbXV38ivX+kG21sr6P9reQ4PCus3AsfxASsa9xuRAAAA X-Change-ID: 20260928-prep-kh-vstor-141673-kio-read-ack-order-9fc2b40d4077 To: Liu Kui X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1297; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=ohLeG8PXafvr7RJbTTJakhI1wHnGPy+94pgqO48V46E=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBquoG7AieYONOqJMkX1HRcb7YA+EfGF9QparpXw 2csV9o6zcGJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCarqBuwAKCRBRlgpH+WFc KhuiD/916kZ+HKjW9TP7iElXEvXuQfi4AoVrYP1GS09aX/obcTUJF3TlQaI70dNVmoaf7Sdi6wL 19liEdaCRpKEcXP+7Kml2LBNBBdojOqoSaJmDe3QBrvKaBsEc7aq8hxXeEyuuknyBisd+l54eeq se3jHlP39Ua2tvQqhjT3SEPC4XkuY8ONpz+N53mbG6QQNxoXEQocKvfcp7ITG3LSihR/uxAezBw aepzoNSt4mnjfwCbwj+hSBKbkO9ck5qy0BnU5Rhi4S6lvRU61wufCUa0fSvo0cc4EXmJorDwRh3 v6WfXxW9qAvjwHDGLyt16EDOElus1YPA1Kp7uviQlztdEAtvCVfjWGivOPdZm6on6SnPwWPl7Ny 8RjyvZeO+rxZRrrKa8ybhKuRtRemjiH6gzz/Ius8CbwSheaQq/2882ZQGsX1TPFLE3581r7luEn 1q08/A2qX7EByU+csYWC+14Lz7Xf5aLEgwi+PSQ1QOPJ83ggX2BtM+zw7DAoXtD1FMj6te6p2bd kUtJoMkX1yH0zwrC6aSg3e3NJiosz+bOzuUgCklx4R0MrWKgMwSlC9A/OZMlVLjiyUp4tnwEMgH 8ktDl/xUlblKEqGr2Erh5J2wZDH71AEkGRsp+j0Kyb/Scyz8pV0iKnbZhzF09D16AXRcJLT/QYR 2sVIIW/f0aW0mDA== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH vz10] fs/fuse kio: unlink the tx before completing its msg on RDMA_READ_ACK X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Use safe style: remove the tx from the list and clear tx->msg before completing the message, so the list never exposes a dead pointer. Right now it's not a problem: currently nobody reads ex->msg without ep->mutex, so it's a precausion. https://virtuozzo.atlassian.net/browse/VSTOR-141673 Feature: vStorage Signed-off-by: Konstantin Khorenko --- fs/fuse/kio/pcs/pcs_rdma_io.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/fuse/kio/pcs/pcs_rdma_io.c b/fs/fuse/kio/pcs/pcs_rdma_io.c index 2001297010a64..c582b583cf797 100644 --- a/fs/fuse/kio/pcs/pcs_rdma_io.c +++ b/fs/fuse/kio/pcs/pcs_rdma_io.c @@ -928,9 +928,11 @@ static int rio_handle_rx_read_ack(struct pcs_rdmaio *rio, list_for_each_entry(tx, &rio->active_txs, list) if (tx->xid == rack->xid) { - rio_msg_sent(rio, NULL, tx->msg, 1); - tx->msg = NULL; + struct pcs_msg *msg = tx->msg; + list_del(&tx->list); + tx->msg = NULL; + rio_msg_sent(rio, NULL, msg, 1); rio_handle_tx(rio, tx, !rack->status); return 0; } --- base-commit: 0679f0d70523972eec3a0643565521d93e26eb9c change-id: 20260928-prep-kh-vstor-141673-kio-read-ack-order-9fc2b40d4077 Best regards, -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel