From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 16D43802A5 for ; Tue, 29 Sep 2026 17:39:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68THcL2x001090; Tue, 29 Sep 2026 20:38:22 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68THcL2x001090 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="OD917WF2" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68THcJot001086 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 29 Sep 2026 20:38:19 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68THcJot001086 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48af5a07314so738060f8f.2 for ; Tue, 29 Sep 2026 10:38:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvByqUeUt1Zw4WyOm92gLiafWxPETdNjrYjppnOqyCkgS039EpMpkMe42kD8Y+vfjHEhdjb+K9w==@openvz.org X-Gm-Message-State: AFq9FYKcyexL2ZzUHSVKxppX+DR2SSgVsFRn1MStoZK8qgWq53YJGvt3 rPVKQr4YQfdmmGWAhigrJAIcBiAYRJMRLgNgKJLoYERoHmMyLcgouwhxxlQbKywssq0T412TU8q gPiqWLmV/ItZn3+vwvulYOhYhbalO+9rLb6OV8t9Mi8N9yiy0d4g7uQ== X-Gm-Gg: AYBFou238AYPybGsenx5eRqwQx0BRS5sslxOXXZxWyAwPCaNpewlfVkmZMo29Gt/kvz 1cMMhB3uU3AnjALHBE8DcOuoxAnaI/zE6I/lSMZO4EQpjXAZdB4SDpIhh2m/ByrhPbehkmFE5iN +2QWeAg1Hsgj20Aqr+AvgD9I/wzOmYEA0DcUyEyyKF1NSDJH9OBIG2ekVWYImfdph/7c0xOSu1J kUgYqU0nG6IpLUuMmSl9oS5jk9sMdyBOY5wLGXX9i7pKHqS4s2GbLVcOXd3BJgNF8+mEMZzgEur yszwojUc71dUXIYTTCu+qJh6kz5RKVjaMnvAoiLzOsxyHm0IuxyMdSveY8fnP4DOqOz40QsozuB SEEyWYE15YaxF5z7g X-Received: by 2002:a05:6000:3104:b0:488:79d6:a4b5 with SMTP id ffacd0b85a97d-48afe793346mr26432f8f.10.1790703499379; Tue, 29 Sep 2026 10:38:19 -0700 (PDT) X-Received: by 2002:a05:6000:3104:b0:488:79d6:a4b5 with SMTP id ffacd0b85a97d-48afe793346mr26399f8f.10.1790703498758; Tue, 29 Sep 2026 10:38:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790703498; cv=none; d=google.com; s=arc-20260327; b=k0AONw4S+PIt1vPbMuyP27wY85uxWkzkWFXb+C6S3wbIm8Ey/7J8EhnJorBFs4tdnP BqeNre0Sb+o0UpflBAhj+xNVqHzYc9K4JJT3aheuheezkCVT4z2g0v3BbPORuGKpC3mB tFMA2pnjyLaiVz49Ndt6rc5Ilz+4SzCixunwpcEYxmImwsP/EbejiPKb6TPo5IR1MVHF D2SNH2qClufX0jDMQ27KIo5o1devL4eCitHbe9QoIKC9GzQdJNfCm7Fjq9Nt147yTAP1 drmKyPiHU6KCBtDFpCszanuO2nYEZXlxd2l/WF++4vMBMv6scFB/sEFGi3Jnwmxe8h8X WNqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:dkim-signature; bh=dS/m+M5g9Nmgk9w/jdV3vjWFDSBxiMmWrehoIBB+2zs=; fh=9+nDjKmImzZ2OGcc76ajOPc+Ar87TcSuIOkIlr4DXaM=; b=jOTafLcJO283ROHEly2MQxd70V1jv0V20jrSJsolQ1guPBJzQE/MH1WFmBCPhlDR+S dRZ6u4T7y8ZvWuHzPyQ6x+m9iKH66AzWgw/rZgQMw8nWyQhm/tfUoeh6vRmIejbfaYM8 qmOUdi4ILuJSdr4E+e8NuhNGUVZxksnDNIxtGiCUvGsaKAvCl8D/x6NA4gHV/LX05wqj b2mUuoSMvertUAk36YTZfWDl/kLb+vQcS8fkC5n7Pl/Pl33ctB2A8IoYAffHx9KSwjm5 MLZGm+Fu+cMWZHF5y+leud2Pn9/6PZuYoKb5QrZ4wXHKIdJOuGolpCljIil+1dq7KGMH 5+Bw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OD917WF2; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48afe6abef4si119056f8f.308.2026.09.29.10.38.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 10:38:18 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=OD917WF2; spf=pass (google.com: domain of khorenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=dS/m+M5g9Nmgk9w/jdV3vjWFDSBxiMmWrehoIBB+2zs=; b=OD917WF2KwaD2Wd9/WD 7UyEmRAqnzZtaqU9ZYDs+LcxhMj4/Mp2FoRyP9ozg76ojATkxNhOxkYVCxHXZd4oLGRpXgfUT1bEP aRK6hDe0jIbfXnX/aQlhYpAmLGhja/pmrM226i41wV5vmFAuvOOJ0UfHYb3jWRceIKbsy3vWYMxHr vB5Ml1AySnj9OsDJlpnE88bU/wHFK2I1DVtUVpDaYF7t24Z6ZIe+9iGe6VeN1ixQEOmQj9+WYqbS8 RywQO69uGMoi3eKCbi3BwepHxOjHLNoCv2Ziy5LBVff/21FykX7XBUuwOnG6CcP9WUdANn2L91609 rXllP25ftOy/xbA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=f0.sw.ru) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xBbjP-00HZQF-2q; Tue, 29 Sep 2026 19:38:08 +0200 From: Konstantin Khorenko Date: Tue, 29 Sep 2026 19:38:14 +0200 MIME-Version: 1.0 Message-Id: <20260929-prep-kh-vstor-141673-kio-read-ack-order-v2-1-bf05c0d2da51@virtuozzo.com> X-B4-Tracking: v=1; b=H4sIAIX3u2oC/5WOTQ6CMBCFr0Jm7ZC2Ij+uvIdhUcogI5GSFhqFc HcBT+Dy5f18bwFPjsnDNVrAUWDPtt+EOkVgWt0/CLneNCihUlGoHAdHA3YtBj9ahzKRaXbGji0 60jVq06F1NTksGqOqRNSJyDLY1rZew++DdIfWMOaxhPJn+Kl6khl3zh5ted/+HJ+CPAp/44NEi alIC8pyo01xuQV242Tn2cbGvqBc1/ULpjiKpv0AAAA= X-Change-ID: 20260928-prep-kh-vstor-141673-kio-read-ack-order-9fc2b40d4077 To: Liu Kui X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2958; i=khorenko@virtuozzo.com; h=from:subject:message-id; bh=KiQsWwnl/6HdBCthyFK1wnpKiNTYRXYLxWRbXX63Rm8=; b=owEBbQKS/ZANAwAKAVGWCkf5YVwqAcsmYgBqu/eJ15iucN2CMiwwvNm7dhQp6XpD9D2nsiOVg zdeuwl3MQqJAjMEAAEKAB0WIQRWD23IPcXT0GO9CCxRlgpH+WFcKgUCarv3iQAKCRBRlgpH+WFc KkCoD/0ePETNIMzj6HiIyE4sfNaJ+igM4hcVc4rMhE7G5WyaCNihtnWYi7rNADvt2FYs3SwJDXJ p43qARbZOCed2EZRrf/1xtexl1tJGXKV51ugE/QsF5G+t3S44UG7MQelm5gVzSDuxdqgdPam9Cv tDdX5t83OF6I5we3vOJ/KIfxoq8o0M6Wi0FaZ3Tz+V8OxqRRiOA17rFoPLzAUYX5BLIyghxBJzX smfqn1YxtUl4YW876nW1UueMoa/CbbufBoxRN6e3knyvtLApmbQ8AG/mVikzsGZ37883MxZmlQw zPpKNqyHtcLDURHSJ1x9l45VPxBd5jqGXm8f+kBvn2ftVwV/1kJdNBaYwgIPjJ3b7V74QzBru8S hmTVbHpfxE5Lrc2U7RqOjRLCB0QFfvgYjWS6EwsZJ/hhHjwDpyoUYCAxaDXsGbMgqNY6VRaPnKX KLtuk3G59LFe7Iy3AO6+eVsZhJFDVrARoXURx944guJEZl0kxWrTWNsjJ1lUa/cmFRaMceceN1v SvQHjJ6cnNRohMqlSBNMA6zg2Ed6UPOfCpGvxRqE++HixOMBnheVwZBeT782BOuSvQd01cMYv6h snivRyzFv1s7lBAHY9bTBx9M0bjCxia2RmltA8tNDZXWnJo/vE47LRCUF0ufr9dNriiA+lPsGGm 802AZKmnGYEjhBg== X-Developer-Key: i=khorenko@virtuozzo.com; a=openpgp; fpr=560F6DC83DC5D3D063BD082C51960A47F9615C2A X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2] fs/fuse kio: drop the done parameter of rio_msg_sent() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org The tx and done parameters are mutually exclusive: * done == 1 ignores tx * done == 0 requires it Let tx == NULL mean the message is complete instead. This also stops rio_submit() from passing an uninitialized tx on the PCS_MSG_ABORTED path (harmless, the done branch never read it). https://virtuozzo.atlassian.net/browse/VSTOR-141673 Feature: vStorage Suggested-by: Liu Kui Signed-off-by: Konstantin Khorenko --- Changes in v2: - droppped: fs/fuse kio: unlink the tx before completing its msg on RDMA_READ_ACK - Link to v1: http://lore.virtuozzo.com/20260928-prep-kh-vstor-141673-kio-read-ack-order-v1-1-6069e78cac95@virtuozzo.com --- fs/fuse/kio/pcs/pcs_rdma_io.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/fuse/kio/pcs/pcs_rdma_io.c b/fs/fuse/kio/pcs/pcs_rdma_io.c index 2001297010a64..59a3c1286363d 100644 --- a/fs/fuse/kio/pcs/pcs_rdma_io.c +++ b/fs/fuse/kio/pcs/pcs_rdma_io.c @@ -151,9 +151,10 @@ static struct pcs_msg *rio_dequeue_reserved_msg(struct pcs_rdmaio *rio) return msg; } -static void rio_msg_sent(struct pcs_rdmaio *rio, struct rio_tx *tx, struct pcs_msg *msg, int done) +/* tx == NULL means the message is complete, no tx tracks it anymore */ +static void rio_msg_sent(struct pcs_rdmaio *rio, struct rio_tx *tx, struct pcs_msg *msg) { - if (done) { + if (!tx) { clear_and_wake_up_bit(PCS_MSG_BUSY, &msg->flags); pcs_msg_sent(msg); msg->done(msg); @@ -630,7 +631,7 @@ static int rio_submit(struct pcs_rdmaio *rio, struct pcs_msg *msg, int type, u64 if (unlikely(test_bit(PCS_MSG_ABORTED, &msg->flags))) { pcs_set_local_error(&msg->error, PCS_ERR_CANCEL_REQUEST); - rio_msg_sent(rio, tx, msg, 1); + rio_msg_sent(rio, NULL, msg); return 0; } } @@ -725,7 +726,7 @@ static int rio_submit(struct pcs_rdmaio *rio, struct pcs_msg *msg, int type, u64 * in a single RX queue are guaranteed to come in order, there * is no race in this case. */ - rio_msg_sent(rio, tx, msg, rb == NULL); + rio_msg_sent(rio, rb ? tx : NULL, msg); } return 0; @@ -928,7 +929,7 @@ static int rio_handle_rx_read_ack(struct pcs_rdmaio *rio, list_for_each_entry(tx, &rio->active_txs, list) if (tx->xid == rack->xid) { - rio_msg_sent(rio, NULL, tx->msg, 1); + rio_msg_sent(rio, NULL, tx->msg); tx->msg = NULL; list_del(&tx->list); rio_handle_tx(rio, tx, !rack->status); @@ -1428,7 +1429,7 @@ static void rio_cleanup(struct pcs_rdmaio *rio) BUG_ON(!msg); rio_put_tx(rio->dev, tx); pcs_set_local_error(&msg->error, rio->rio_error); - rio_msg_sent(rio, NULL, msg, 1); + rio_msg_sent(rio, NULL, msg); } } --- base-commit: 0679f0d70523972eec3a0643565521d93e26eb9c change-id: 20260928-prep-kh-vstor-141673-kio-read-ack-order-9fc2b40d4077 Best regards, -- Konstantin Khorenko _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel