From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 120E7802A7 for ; Thu, 1 Oct 2026 03:26:54 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6913PetQ030228; Thu, 1 Oct 2026 06:25:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6913PetQ030228 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="xSmeguP1" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6913PZis030211 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 1 Oct 2026 06:25:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6913PZis030211 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4887f71b1baso5003486f8f.2 for ; Wed, 30 Sep 2026 20:25:35 -0700 (PDT) X-Gm-Message-State: AFq9FYLe5mP9ErtlyENssU0kdPmlb/EhHCsI0FDDlQgQ1tQxos5HQnVh YolubHPfmyvK7HX/F7gjQSHO8o0HtQZho4zN2FgIG0EjVbibu5VjIl9zDubE/2Ctt6R2Wqo4AGC 0z4BIsdZtyi42bT/aK9U5Fucp/W8j9AtbdYTjRAP/ymxHsR1pQB3EUA== X-Gm-Gg: AYBFou26XRmiDZzKA/4aFqF40B1khhsmIxdUKcazCmD2o9EqK53VQjUWCLtEva/rgEQ UnxP+bMUZWZmSVi2u0g25dfhI8PV+OjhkrmFkekS3jDr1JESdJuetraMH3sW9AvkzeZAO18lGaJ u9EnIZ7clcYEWkfNr3bPoXOX6InSV12517O/+BkEkyljqHNPFXVJdmoz+UGKSQpQGqpTnt+e/wC nMyORa1lQLOI3nPu83zy+lQIn9iT7xKXPQSaU0rt/UU8OmuHptudvYdwYtHwbSNDU+J2J+gFyGd jcWRPNY4gdXZ5UprhenGy3cEv0CrLpkacIJfxvweO5y7lu92rYQs2XPeZDm2k2aihBjkyg8BNdX HBMTJHAEZrmRrKGiUOfTtACBTHA== X-Received: by 2002:a05:6000:3c7:b0:486:f3c0:c26b with SMTP id ffacd0b85a97d-48b02548b57mr5869424f8f.57.1790825135073; Wed, 30 Sep 2026 20:25:35 -0700 (PDT) X-Received: by 2002:a05:6000:3c7:b0:486:f3c0:c26b with SMTP id ffacd0b85a97d-48b02548b57mr5869408f8f.57.1790825134570; Wed, 30 Sep 2026 20:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790825134; cv=none; d=google.com; s=arc-20260327; b=G/uZGjPFHEcmqaHkkegIQOXEIzuifYOh0IkXBR+JYqYFi9llkAFSW/+4xzuJTe17dx E5iT9tbse4VxBQandro97nZwGQlYbGmTa+m1KbMLoIIzYAw4pB2VIHjGZPUsCKiLiIYa jlJ/N0IO/NkV9puxvHPYaX7ena1h4sy3eRv97+jmR4ian1/wbZ+F7Q7PdniXokiT4srW g7sCH4y2EDKcjcERnFw5vXmrUOa8BBg279YruGGViZDmr05tlWhtDu5f0HDJypJgiznb XOzMfGr2ZBI6aXn+D1js9QNsg/1E5oCcsCIok23ytorA4RPTS0vF/wVeGYrTnTm7xYo6 ag/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=/BHY6MGQXtjZsMYOkHRboi8Foz64EHIJBm7TUlTesLE=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=UOAvxrJ4mhKMIpCZEpcee8I6EgxJqtdvvdUbvs0DoRmsoPk8UDg/IDJtW8D0eHrmh5 aJCNPLQxYtWaVeixKoEIrK4zurrUvwwfKktJN+WbcslU1u6EeJbUyBOaQbPyx9Gsidy3 dOwVrdeDY1rtAH1aI1scmhJt9TRn9WZMjphE+yaKpxNPkpUFtxCzo3fp544XZlQlGu8T B/1zcAmHTX60CnrjqvfR0Ww8u+DfdAEhkP4qCgbiQFNHEVHEsB0zRTcY5fr97KHDOjBw 22Pfr2C7RvUPuqUfVdRLVcYioObKeFuPA8+vFwKM8cJPYrgy5ih+AhUPTLAa35HReHMw 1YGg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xSmeguP1; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48b06b40760si2682293f8f.366.2026.09.30.20.25.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 20:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xSmeguP1; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=/BHY6MGQXtjZsMYOkHRboi8Foz64EHIJBm7TUlTesLE=; b=xSmeguP1WY5Z kA7136lgw8LwXueJO2R75rAtHQggA+2SOOr4uy1EHPaDQvQPiMnrscGqrfo7P/LFAh3QRrpjXuL9H p5WFahwhVl4lwxHb1y0pfqOMqkdxNXK3ftRqx9u9VKBje2+YStkch5+xhFTt2VhIIc8bQCz6Ee4eW t2owbYx/nI7hMd9BcNbbeIv3ah2ECNuEtp2TBr5vOR2qqx28ntcyypOGsIJGFmTb2R1kChfDRHfSP SLNGuI8zEQVvadOG7wMrKOpuW0mZq8dxiOVpf23dwBhJpIjcKBg2vOJegU9878eKoGRjUdB7jw8YM bMscuLPs6v4uV3fE5QM04g==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xC7NF-003ax4-2J; Thu, 01 Oct 2026 05:25:32 +0200 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Thu, 1 Oct 2026 06:24:19 +0300 Message-ID: <20261001032531.1307025-2-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261001032531.1307025-1-eva.kurchatova@virtuozzo.com> References: <20261001032531.1307025-1-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 1/2] selftests: ve: grant the directories the files sit in X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org The sysfs variant names nested leaves, kernel/vmcoreinfo and kernel/notes, while the proc one names files at the top of the filesystem. Both enforcement tests grant the leaves and nothing else, so in the sysfs case the lookup stops at /sys/kernel, which a fresh VE cannot traverse, and every open answers ENOENT. Grant x on each directory along the way, taken from the path the variant already gives. Fixes: 303ce49b7446 ("selftests/ve: add ve_perms test for proc and sysfs") https://virtuozzo.atlassian.net/browse/VSTOR-144955 Feature: fix selftests Signed-off-by: Eva Kurchatova --- tools/testing/selftests/ve/ve_perms_test.c | 34 ++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/ve/ve_perms_test.c b/tools/testing/selftests/ve/ve_perms_test.c index 25ffbd42c380..8096b1fa3b43 100644 --- a/tools/testing/selftests/ve/ve_perms_test.c +++ b/tools/testing/selftests/ve/ve_perms_test.c @@ -114,9 +114,11 @@ static int ve_open_rel(int cgv2_fd, int ctid, const char *prefix, static int set_entry(int cgv2_fd, const char *path, const char *entry, const char *mask) { - char line[256]; + char line[PATH_MAX]; - snprintf(line, sizeof(line), "%s %s", entry, mask); + if (snprintf(line, sizeof(line), "%s %s", entry, mask) >= + (int)sizeof(line)) + return -1; return write_file_at(cgv2_fd, path, line); } @@ -343,6 +345,32 @@ TEST_F(ve_perms, write_parser) EXPECT_LT(write_file_at(self->cgv2_fd, path, file), 0); } +/* A leaf is reachable only once every directory above it can be traversed */ +static int allow_path(int cgv2_fd, const char *path, const char *file) +{ + char dir[PATH_MAX]; + const char *sep; + + for (sep = strchr(file, '/'); sep; sep = strchr(sep + 1, '/')) { + if (snprintf(dir, sizeof(dir), "%.*s", (int)(sep - file), + file) >= (int)sizeof(dir)) + return -1; + if (set_entry(cgv2_fd, path, dir, "x") < 0) + return -1; + } + return 0; +} + +static int allow_paths(int cgv2_fd, const char *path, const char *const files[]) +{ + int i; + + for (i = 0; i < NR_FILES; i++) + if (allow_path(cgv2_fd, path, files[i]) < 0) + return -1; + return 0; +} + /* * Enforcement, allowed side: from inside a VE, granting r lets each file be * read, and granting x on the directory lets it be traversed (the lookup then @@ -358,6 +386,7 @@ TEST_F(ve_perms, enforce_allows) ve_file(path, sizeof(path), self->ctid_a, variant->fs); + ASSERT_EQ(allow_paths(self->cgv2_fd, path, variant->files), 0); ASSERT_EQ(set_entries(self->cgv2_fd, path, variant->files, "r"), 0); for (i = 0; i < NR_FILES; i++) EXPECT_EQ(ve_open_rel(self->cgv2_fd, self->ctid_a, @@ -400,6 +429,7 @@ TEST_F(ve_perms, enforce_denies) O_RDONLY), 0); /* Granted w only: visible but not readable. */ + ASSERT_EQ(allow_paths(self->cgv2_fd, path, variant->files), 0); ASSERT_EQ(set_entries(self->cgv2_fd, path, variant->files, "w"), 0); for (i = 0; i < NR_FILES; i++) EXPECT_EQ(ve_open_rel(self->cgv2_fd, self->ctid_a, -- 2.55.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel