From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 369AF8017D for ; Thu, 8 Oct 2026 16:52:52 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 698GpVNL026083; Thu, 8 Oct 2026 19:51:32 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 698GpVNL026083 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1791478294; bh=n7mf3oFy7MP2HoyYC3SK6L7L7Rnc7nNWfBINniGlTnE=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=le6z+mle/fmThisNxGsITTHKGiv/4T3XtlpR9LGMJG7thsqYFyf8GQgMMZmicGlzt vj27/B8wWxNvcqQn13Pw3N14B9iOg6wwecS9eMbq0b2NB7eVdlpwR0784Ktmaf5iRv 8W9hJF1YWSvfBOUu7C+6IgR89gC6W2NlCJEok1wLuLcToLcGgBjlqNZaiuYbElbQsh xxKBl+SX/bHNsNiKB0dIQa5KwrssbLTnF/xnmqji9IrKYv+IZRBFKNvVb8gFsuwBC9 ZvbF/j0j6zGMa8htEpkfNByrOPd/aslmGQo9njRfEGhsIQ2GjED8u0NC/VA5Qr0Sah OVP4Sulqdx5bQ== Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 698GpTRm026077 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 8 Oct 2026 19:51:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 698GpTRm026077 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="XeXxwPp7" Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a01d1fb07bso56095385e9.2 for ; Thu, 08 Oct 2026 09:51:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxRSyytgMQ7k7027+kD0etpo00w0uUtd6bPs2HGeSTYw4jnBjQxPTLAKYP6KPPvWOSsXvd0eg==@openvz.org X-Gm-Message-State: AFuF++kUaIFYAFuFokokzc5l9NIyHBorGVmEesUJQs5QEu040Qc/96/F L7BBXb8WnRsSgomFI6Qx+akNxlsXf2/UJzNKMvsdJsf4xMfREQ4bnclb92qU+4XGjhqnXEDbOtP hkKABUb+WsyzqTvgn0wfr/svQ2sMDzE5I5rSusLlsxAf6AJBmx/8JdA== X-Gm-Gg: AYBFou2a4H+RYPwbLpfmeG76R/q8tWUtwmzjlaNoSwgI792AGI1EuOkLkb06k76C0EP +Ow82OoJJ2EXUQRuJzp4/xbKTk4jQXj3BqgcjJF1iFBxKxg4iVzsSJwuTiqD4yyWrx4cUjy1iKC MXZqj6GUmI9/XGEhixWBc0MBXs3EeyHVZJSUCLSqNURJVy4v78kCC/9h+oYWaEAU+ObU4T10kdh fqUUt8iD6aCYkNebK+ISUXSmildTTPr/Suz2UYV4/gFTyDwwoziWnhT+kAcPrfrWa6zwzD0OaM4 UB06TtIB3Q== X-Received: by 2002:a05:600c:8217:b0:4a0:a34:6e7d with SMTP id 5b1f17b1804b1-4a18041f9a0mr118028155e9.18.1791478289251; Thu, 08 Oct 2026 09:51:29 -0700 (PDT) X-Received: by 2002:a05:600c:8217:b0:4a0:a34:6e7d with SMTP id 5b1f17b1804b1-4a18041f9a0mr118027635e9.18.1791478288698; Thu, 08 Oct 2026 09:51:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791478288; cv=none; d=google.com; s=arc-20260327; b=VReiQg56EHT4b43X0eZVBEQq+avbLWJNff4676hLF+6uG2EQzOdGkju3K1VvTYQ60b 2+DQ/mTcnxToqBaqNNPXMueFlFN/8SgD+FAxbUZ4sI1INsLyzqpX4ZK6Fuhyjc/kQ1Ur dXAFUsy989IDV/3OVBBXvmDimkadyVVNd6oUAepYEUD6GOhOPeHWYKnGlT0U+bdVrD4S zbOCg2z66yKG+1vnr8eUBlGhfQcUqrjNCZwbRX05aunZ8NB+3CAR7f7i3LacLZTJ+aYc 697lrbWtuUMSiHMVo1kY+7E19HN7IRfhKB70QIjMVW4ex8VOp5YZVYSgAicKv6fBbv/O WGUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=CJvL55BMv3WMJs3if9Stoe7tntUM2iyEvlhOvllvvbo=; fh=q31mKWjAcbW4Xs7xdeOVTf5Xhfe748ofDyEH8iC0LTU=; b=jzPRzhWDZAbRdZEqpslK51XTg3CJ6tcV7zjhBMbNeWTriN08VW/VpCEmcWhNvbNCe1 H2VVc2tTFPlrHpDC7MChFWkst7FBZWL2wyahDSxDHbCdcK7/XIeMBsG6aulJZ2rcAMbs Hgs2GzmgbCzw1RXIwzH0I7K8K2YWoWVE8rhApugWd+CwNX1ZHkO5zrQeRJBzMpkARXI/ EHhKCeFpQZvnZGT3tL4WOFKFkl3Sxhm1E03eFDgVKvpHnpxdjeO/ptuBu3QT2TfmuFsm YPUpH0Qf6Ca5z8Fl8jMEvR228Frf3FuekUODOHCoNH+xXKOF6R0RK0sCSZPPjSoewZ3Y RWPA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=XeXxwPp7; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:6a7a:5218:3cb9:a82b as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4a18accbd4asor323705e9.0.2026.10.08.09.51.28 for (Google Transport Security); Thu, 08 Oct 2026 09:51:28 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:6a7a:5218:3cb9:a82b as permitted sender) client-ip=2a06:5b06:b600:300:6a7a:5218:3cb9:a82b; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=XeXxwPp7; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:6a7a:5218:3cb9:a82b as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1791478288; x=1792083088; darn=openvz.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CJvL55BMv3WMJs3if9Stoe7tntUM2iyEvlhOvllvvbo=; b=XeXxwPp7WCRVScNGI396ZUHqPNEPac+m18wK/oemQofWdz8GzNvbWkXiQMNKeYxWr/ LWrSSocDDc60UN6iXDcZAXpyBNfzuWqMWkUO2RynvnhOl6KUX7gMWo7jJECiJU3Ehr2V 21yF6bNV94B0Ic7pnpngAFZA3pwuAoE5F1mxeb9vj1GSbEGnMmKi2CvuYVPU7OJPXsEx S8Rizw8ns2TwolPR1hVcWIb0LtGdrFkn3Hi4GJD1VpaJKstncBfoahWJgLbqMqpKDINe aAOtwI1qX4RFhz1OtNC69g3mLbCFBoQwiAP4KJEyG2CvBYwO8x2AC5dE40bqMjA7abeN nQUA== X-Forwarded-Encrypted: i=1; AKwUvBzAYWih9m/mjWIYDeRliKAv+oj3eMtJinBHwzq7ydlA3mCuk5wqfizfwaLGdva9Dfvy8Xqd3A==@openvz.org X-Received: by 2002:a05:600c:8b64:b0:4a1:6dc3:f5e2 with SMTP id 5b1f17b1804b1-4a180650499mr110083605e9.33.1791478288186; Thu, 08 Oct 2026 09:51:28 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:6a7a:5218:3cb9:a82b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1843d8997sm90383545e9.10.2026.10.08.09.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 09:51:27 -0700 (PDT) From: "Denis V. Lunev" To: Alexander Ivanov Date: Thu, 8 Oct 2026 18:51:19 +0200 Message-ID: <20261008184500.review-dmploop-v3-1@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261008140333.614909-2-alexander.ivanov@virtuozzo.com> References: <20261008140333.614909-1-alexander.ivanov@virtuozzo.com> <20261008140333.614909-2-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 1/5] dm-ploop: fix lost wakeup in ploop_allocator() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 08.10.2026 16:03, Alexander Ivanov wrote: > + /* > + * Set the state before checking the conditions, otherwise > + * wake_up_process() from ploop_req_prealloc() or > + * kthread_stop() may come in between and get lost. > + */ > + set_current_state(TASK_INTERRUPTIBLE); This is the canonical kthread loop and the commit message already explains why. Please drop the comment. With that: Reviewed-by: Denis V. Lunev _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel