From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A7A198017D for ; Thu, 8 Oct 2026 16:52:53 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 698GpZnA026105; Thu, 8 Oct 2026 19:51:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 698GpZnA026105 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1791478298; bh=ydpyXgFIMeAJMH+IVBsuta2Km180d8Cuqa6/UAxYUcg=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=DtRstbDGJ3U8DTEnAMN3H59+jrHHC9w3N19SOA2+zzj8ojoMbxPRPNW03W4P4+Zh6 aU0S3Y8wFOrGxRikJYx6lTvRgnBB09lwpOw/Ge4A0TtYrzakuPXIzm7OD9L9pHRgIG R49AUDM4pURoThk5VDwjaBCZPaHKbfdJbN5h3g81Y7Lq4CNsXtN1HX+9Eq605MZZXh uQCvor6dmQGQZ8BwCLar45oMxsC1TBMsSuOFbjPfqLup8ICwRwSe5cCYu7e1RhLIhP hLxtORzMBGzfDiG9OeJJt3567svrUAn/59h1vKsjFonLi6b2SRAnU7Pdt8NylIbZc7 J+EV4EZlAuaRQ== Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 698GpUNj026081 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 8 Oct 2026 19:51:31 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 698GpUNj026081 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="JROtFBp8" Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48589603501so3033524f8f.3 for ; Thu, 08 Oct 2026 09:51:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBymxb51iroo07LR58GkI6kc/GUhIKhKtJEpdjVePSuV6ap8Ul9oGbbBSPGixT79p/0/+mW75Q==@openvz.org X-Gm-Message-State: AFq9FYIUx5tZ20WwcAwwnz/ydgSuIGBtFBcyazW4ZtQweVcmyW9zrQaN L7EHPphsJu3tImANxy2Xhspgyrdy6BlrLZ6s97E7ttfrkBtQOukRaJtEfCAkHBhPWR6LrSarcHo D7G18x6O4U1PrVimFVyauMkarfjoV+esObt1VcQMsBUA5Or82rCkP8A== X-Gm-Gg: AYBFou1maWIF1r4aR0Zi8Hqfk2iI+e9JkTw/4QOzZuve39lWdLkRL9N3tBgzbccuNPJ itL4R2IH+1W8zHQnyXqxxpBhlhVTxTMRG+2VNS7E+bBcVR+9GI91B6sbMaeBwd6bSIAlPtJuLSE 5CXdFoIuujZL1KF0Z5hm/821icWV7pltA+uPqrxysRfOc3M7MtE+SuVCOwZl2FGbU3N54pJKaf5 9GWsAicnicLEIQPuyiO6p96h3oQiMYTexRD9JEee7mK8LVyuv8z3+em87OVKOXNGaeaf+BKh0bP cdn7aqj4Tw== X-Received: by 2002:adf:e189:0:b0:48b:26c:8cc with SMTP id ffacd0b85a97d-48c7288acc5mr11659542f8f.27.1791478290197; Thu, 08 Oct 2026 09:51:30 -0700 (PDT) X-Received: by 2002:adf:e189:0:b0:48b:26c:8cc with SMTP id ffacd0b85a97d-48c7288acc5mr11659513f8f.27.1791478289823; Thu, 08 Oct 2026 09:51:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791478289; cv=none; d=google.com; s=arc-20260327; b=di2wx2BrcUuf9q8TrZZBANx2bsev54MtKkLOji8I95h0P2QztLqrvmmSITI4tvKeyq IQObb30Jbt/aeUBuGTaLSqH6UErN6zgTm/dz2J/gpFqkGVB7QwA3MgRskFPImTcddnza 9uHF0ZUhMt/sBIYhVXMpP6WulFnoJ2k8oZpnFXHRzU+3Sf05HoInIptaYyOCh0kjPBp9 pf500Zq+nVADPdDxpH9kW6aRFut0evUPpEjy0t74oizgvdTaVE//Y/k9i3JC+MI7uXxk T/2031wynfEEeZK+yQ+AcIN2/B9fNcFnGq0e62frcLf/+feeWnPpYfSbqG8u3y7mCQ6X rIFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=19MgnqKUMhBvJYWgtGReo9Gtj+xruCkg/b7NDhzNoP8=; fh=+LiLVA8zR2b07W0Ra14iSQBMf//rCbJysg17ooyOei0=; b=qMx5gH71zGaDvjfHMmDqVLw+Y2ieJ4Ssa95yl0kMd/8CeDLoRHdpMrGiZm355Jhi8V m2bQOIhe8N6HYKitUA3B4k54kkbxobKfvIa8a9yLaSJ7cQezx2JNr24uVRxfGvtjBeBT YZG7V4jZPfYVGDyDkphu55sm19KG8PlH218Xie3JzclA4s3GZoxf/WVWRsBmSU+oqO2T m5qbMuonttllrGJnmY2RToEILZEFCtt9bf3GewMsNxyuhes8mMWwaCmTdxqPDD071o0c Ze8S+SScs3qD84ZAP0cdLFq1cacDcbndMelWQXWMjkyqmdSJmHSSsb6SG6NkeTNSquTP KNdw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=JROtFBp8; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:6a7a:5218:3cb9:a82b as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48db6559487sor54000f8f.16.2026.10.08.09.51.29 for (Google Transport Security); Thu, 08 Oct 2026 09:51:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:6a7a:5218:3cb9:a82b as permitted sender) client-ip=2a06:5b06:b600:300:6a7a:5218:3cb9:a82b; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=JROtFBp8; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:6a7a:5218:3cb9:a82b as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1791478289; x=1792083089; darn=openvz.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=19MgnqKUMhBvJYWgtGReo9Gtj+xruCkg/b7NDhzNoP8=; b=JROtFBp8jlfS0qWJU8klyX+pM7fCyhSa6MChMbra+tEeA9MfpHivMHr8eHkeulBBEc 1wH3FJLuvkEfUNQd5aUQwNJ+E1RqdyftgWgeAnSMOXuXmcYSRb3moY+Vi1k7/U0+zeEQ P8Sp25R98hcS/O4GCuu8QYS6b8EBOk/+ExqSzqeBkNT/VvT/62B0J4Lo5cpFMT8vyxhR T+L/op/1+GjnwqCzXK1d5NoP8a/Czz0bZW2grNBWJ2lgRbV8hrF369VgLb83TJGV1XQ/ mupZBQAi2Ee3sutsAZgiml6JdhLOSSCaga83Z0kqZB6ZhalK74txAAjTfoZXirs7KK51 y6Pw== X-Forwarded-Encrypted: i=1; AKwUvBy3AqAJDSIaZpbiwYO4nGHFB4N2gYDqAXtNHutANATVkep/tB+79/OiYASBtjFpqUlq3WTmGw==@openvz.org X-Received: by 2002:a05:600c:524c:b0:4a1:77db:45d9 with SMTP id 5b1f17b1804b1-4a18043dec7mr105529555e9.6.1791478289339; Thu, 08 Oct 2026 09:51:29 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:6a7a:5218:3cb9:a82b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1843d8997sm90383545e9.10.2026.10.08.09.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 09:51:28 -0700 (PDT) From: "Denis V. Lunev" To: Alexander Ivanov Date: Thu, 8 Oct 2026 18:51:20 +0200 Message-ID: <20261008184501.review-dmploop-v3-2@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261008140333.614909-3-alexander.ivanov@virtuozzo.com> References: <20261008140333.614909-1-alexander.ivanov@virtuozzo.com> <20261008140333.614909-3-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 2/5] dm-ploop: set delta is_raw before applying its mappings X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 08.10.2026 16:03, Alexander Ivanov wrote: > ploop_apply_delta_mappings() takes is_raw from deltas[level], but > ploop_add_delta() sets deltas[level].is_raw only after the mappings > are applied. So a raw delta is handled as a non-raw one: its md_root > is empty, ploop_md_first_entry() returns NULL and d_md->kmpage > dereferences it. Please say that this has been the case since the driver was added, i.e. raw@ has never worked here. Otherwise somebody will go looking for the commit that broke it. Reviewed-by: Denis V. Lunev _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel