From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2683680726 for ; Sun, 11 Oct 2026 22:54:10 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BMqu7u009379; Mon, 12 Oct 2026 01:52:58 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BMqu7u009379 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="LVIzAIYT" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BMqoSE009340 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 12 Oct 2026 01:52:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BMqoSE009340 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a19df2328cso5397005e9.3 for ; Sun, 11 Oct 2026 15:52:50 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxJmdGwE6K7E8pA+exP6GTEdmyFYx1VX8/CIYahDsBj6FQxpOy+pQkkY8MDu9dSEUxR7trrQg==@openvz.org X-Gm-Message-State: AFq9FYIDF5FFnRlLwb7874WECytrgT3cMVquuaAmztu39zdf5Jz7dp9m /kexbYKv+1/Ofu+Tj+//uo+5dbttZ4NDON4vNRkVZWZWlBezn70yIab7pwz7D7cvoa197vpmcUc GP29c57dE79GdqgaluRecaP+fvxvImHB60SiO2qR1653Stf6AdogxTQ== X-Gm-Gg: AYBFou2uIWvVAVWahFhxg2bXA6Tosvx2lYqeniE+O+ZOtn85Dlz9GNeROO0Z7XjB4sz DeGj8ubB0q/cm5mOgNuFozwf+6QrhCd1IMkO+X3gdwPYNMok8v/0kOLsBWDPSRU78VZHq8SCWnU 656/jqeH2/2vj41RA3cXhWF5arRNVYjw95/hl+rB6HxZ3uv/8VNQ878XNOKbcqMeXMyAKr7ya2i J9iOPTU/DCb+11rvAgWU4EAiSEqQ5erEEV8b4c01N8+lSB1PQxOClQHvTK4Bn7o9odYbtf/BuB6 800x+GRJubZF8zZm+zfvvsPwkTWj1C2HoBIB62oLki+HjCeqLAdtYZKuxOrkY4yfCs14GnaRomu vPh1W9irGT0YHfTMKuaMdsLqij30V X-Received: by 2002:a05:600c:4f42:b0:4a0:b6:4619 with SMTP id 5b1f17b1804b1-4a18e3ecfc8mr171955595e9.0.1791759169881; Sun, 11 Oct 2026 15:52:49 -0700 (PDT) X-Received: by 2002:a05:600c:4f42:b0:4a0:b6:4619 with SMTP id 5b1f17b1804b1-4a18e3ecfc8mr171955425e9.0.1791759169338; Sun, 11 Oct 2026 15:52:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791759169; cv=none; d=google.com; s=arc-20260327; b=GujkPL4dW0zFdeOqzdMcJclXqMc0ddedoa7FIJwvi6jUGqqUjhdC1s2oH7pWIxXLUk UbFEkcYwWSK1S+JxJdqmwlE8N9Ruv5ApPXORiXh86+ltfIg7UTj1jxGOZz9S4rcKTbVn 03h2NdE1N7gSZ7MQNUI8k0AQLJkX1esRsd7GZnVAy/QRRQ74TUwD8fhvtGYWYGhG9/MM dm0TSk7i43h3g5Bed5XUHM9aaNDgNraTR9zgTVl4cVnL1O6tMWovCP4sEOS1IlwP49gE W/1t7vc4fgmyoykY9hrgAYdi6t4Yk+IfPQ60bjXqTQTN4q9l74vWT6RbvCO4gEwFUWjE y0aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=9/eAv5ZJUiHIgCPsZDCkRUiNid5/Zxw1jfsl5Ua4B9A=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=PSB46t1sGGBkuP242GYLHAoxwZEWBgn932HipWELkIcRXwikALfokWEhUdRRCz60Kj 2JfbrXgEk1g0ccVvVaCFdYkXLnTWXiTONNPQmgpTyboRZPy81LSGhp+UWOsdQfGoE+We jF/2XIW7A/TzmhJSRU8HtWh/OBTbNUGjpw8BOmlQyL2z1zUpf/UcX2dJcFLxZ8CQzPAu bEta16R3GU3axwOVzb30zkEVTRCAHHXHtoo1/mL+EAJtxpOIufmJGeHDhGhohJOzGnsa LkLuTFjIYSRSr/2M0EpOQtZZxzkoPXJYZcM7TObcxVtfLG7FtwQ7qmNFTrinH3slQ9ZG ZwxA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LVIzAIYT; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48dd8fc3076si1101174f8f.391.2026.10.11.15.52.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 15:52:49 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LVIzAIYT; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=9/eAv5ZJUiHIgCPsZDCkRUiNid5/Zxw1jfsl5Ua4B9A=; b=LVIzAIYTC41bbOaWrnn A3FHF5zVLkQs/gBUdN34rQE8/MBelqhppBFL42P6cqwLv9LVHmkqykV6wnBYe54QjWvThG+nzCriY PJtefO8QRhn1f86V/8B2+1PCk1wvS1FU55qauJLPpJS4kfTei6+WWEsDWOJWqNsgdV6LJqSZxo7Dj MT7MrNljCsaKdpDwiy297W8ZYNzwgrQQI44EmYbcMY8oZA01I8xib6Gn4eOEMPemDSgHzE22CnFHH 8V1gwzuuJMiJCYfjBxKw+iJJGQNjxcAiM7seT952HYRJlvWZvAU/ip0kzBOTNnsTUmgjQ7LSA9EpX C7YSq235fZlLPoA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xG2M4-002SCD-04; Mon, 12 Oct 2026 00:52:41 +0200 From: Vladimir Riabchun Date: Mon, 12 Oct 2026 00:52:28 +0200 MIME-Version: 1.0 Message-Id: <20261012-ve-printk-irq-v3-1-efc95fd5c78a@virtuozzo.com> References: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> In-Reply-To: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.14.3 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 1/6] ve/printk: Add sanity checks in ve_printk functions X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org This patch adds dst sanity check and reorders VE_LOG checks in if. https://virtuozzo.atlassian.net/browse/VSTOR-146839 Feature: ve printk Signed-off-by: Vladimir Riabchun --- drivers/base/core.c | 4 +++- kernel/printk/printk.c | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index ebc6c5570a4d..2d233ffb5661 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -4945,12 +4945,14 @@ int ve_dev_printk_emit(int dst, int level, const struct device *dev, const char va_list args, args2; int r; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_start(args, fmt); va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = dev_vprintk_emit(level, dev, fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_dev_vprintk_emit(level, dev, fmt, args2); va_end(args2); diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 8940b36e790b..efe2c3279c85 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2535,10 +2535,12 @@ static asmlinkage int ve_vprintk(int dst, const char *fmt, va_list args) va_list args2; int r = 0; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = vprintk(fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, fmt, args2); va_end(args2); @@ -2567,10 +2569,12 @@ static asmlinkage int ve_vprintk_deferred(int dst, const char *fmt, va_list args va_list args2; int r = 0; + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); + va_copy(args2, args); if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) r = vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args); - if (!ve_is_super(get_exec_env()) && (dst & VE_LOG)) + if ((dst & VE_LOG) && !ve_is_super(get_exec_env())) r = ve_vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args2); va_end(args2); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel