From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 279B080958 for ; Mon, 12 Oct 2026 13:28:22 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69CDQuLP022869; Mon, 12 Oct 2026 16:26:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69CDQuLP022869 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ojz5qPcF" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69CDQtnp022839 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 12 Oct 2026 16:26:55 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69CDQtnp022839 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a19df2328cso13391725e9.3 for ; Mon, 12 Oct 2026 06:26:55 -0700 (PDT) X-Gm-Message-State: AFq9FYKHUjBDeHGCxYHgAiR5KWowe+JbjWWHhcNGHcpkFKyEZLVykO0x CTN5O48LvoiWcOlrSTF8hQ8FLuIjlvQmfNQ4G+snFisedRqHxl2LT4tnT1M8m20XJLONBJVg+rl MpgMPFspb6dLCjbKbG6mpPuYaLIESGlN8+MrRo0QDN5TSuPJfLcT6Vw== X-Gm-Gg: AYBFou2nhnhQsOnavEiNCc9peu+jDET4Yb0l323kGQMfAY2hL8cEgIGKOWcXcqbm+wp FPz0YD23VEWPWStp4fQR2EoTy5u5JX895PtukXm6CjZKhSCi615HJN3gTAzUedA13zu/Mnt6Bz7 4mkawcalW6rgLIzM8KUipmRvNlmbk4aqfilfd+uLRVfGT0tJ+LaIjAg38B2tElYrtIFvhBPhrOH aC8Kqavh+egQp22nqMB8bpxA3oq6rWrimwXr0Odp92kOh/jDsdKzwgjYRAdYsf6gBqnE/fAsgCj gXaxJ19YygwAFOBHtQzXZFTZCLSE9aDLTxHsEBZUAMExk7ULqN02iYh6a973oG/8iE9yVJ1m7HW WXChNeD1vDWOcvBWj9Mjkge+lcJZo X-Received: by 2002:a05:600d:6413:10b0:4a1:88d7:4e6a with SMTP id 5b1f17b1804b1-4a19470eccamr86813005e9.27.1791811615207; Mon, 12 Oct 2026 06:26:55 -0700 (PDT) X-Received: by 2002:a05:600d:6413:10b0:4a1:88d7:4e6a with SMTP id 5b1f17b1804b1-4a19470eccamr86812455e9.27.1791811614452; Mon, 12 Oct 2026 06:26:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791811614; cv=none; d=google.com; s=arc-20260327; b=rgVooHvwCmIuAYdB3T1BgltkO08Khp5HsVBoVMl6gvd03SHi9bjiN+xDSfmzp92Vik JW7mXmItJj1jdZyyXtJL+UCIFuXRHBupwMv6z9asKWg3iI6LCIqR3QQjnHc1ZLibubqK p+sHNbT8jLQs5cck1PwRJ6WeUlkB+hZerNdfjJFwth2TIy8sPfTHULuVCtmB9sQY6LoJ lFD2dr5e1culfj8/9BQw55txUw/9vOtNOy9c4LngyogljAhjg/Z81B4GbwpRAE512Z2L /0FbE+F5BT2KFIhWy8fLEfGOg+h7Qwi1bVYx3KLOUjZJy8tnc+JICWiVq993O1jZ4neY ImvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=a4C4uUdw8tUjC90mdFeJBjMXQD3BQoeYt0bplaAl/iuwQeeHE8S9cW825jvbSkQ9OH j13CfO2fSGByx0sE8uPudrbT7CktPktmgcxFv4eTfi3AJkZKQnM3FMnY/x6hXwD3SWME YeLAaLqib3St4NepoJQXJy/VYml43oVxKFZqnfrEmV1flMav4cRZvwKimuoQmEzKsEwx v7ToYudVo2mxylwuUJrVl+yaAt16VaKbO9URg4MQVZtc8KUZURdJK5F2P3/EmK4OY4pY MAbUKDqIFmOAlKvxgjEu3+bLCtvXozlKxVR8bXiIfDdZ/copv1+YEIUCdpBSDEtBQVtW iJ6Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ojz5qPcF; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48db9465867si18797288f8f.23.2026.10.12.06.26.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 06:26:54 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ojz5qPcF; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; b=ojz5qPcF2w79 nkZagBClG6qVJakioxfbP1NfzhDtiHg12FIAPFGw1e1o/wqJmRzH6SZmBuiZZ6lM1Q1hw2DhVw3Sn ccXspKmhOEmku/FZNteI4FA7Tu//HwOyEMGbY3EDRRqdNC2oy0bKYS4GVXAF9393HvOmnUFHuQbX6 EukEztRyHpgyCCn3GBTY36YhfjzYt5nEv6jNbZazFIsrffsNJkcpCj46thI8QQcyZcmoCgk5HTMvk ZPART6iTKt5AkJnuxfeQzLCWwGNLpUuaK1TNmEgrvkAECuMpYlgAufejz4hGzugwQc5cEDN/S1ePj D3f4RDmTBPQjewyBidYvWg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGFzv-001WAY-2a; Mon, 12 Oct 2026 15:26:45 +0200 From: Alexander Ivanov To: den@openvz.org Date: Mon, 12 Oct 2026 15:26:38 +0200 Message-ID: <20261012132646.41494-4-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261012132646.41494-1-alexander.ivanov@virtuozzo.com> References: <20261012132646.41494-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v4 03/11] dm-ploop: reject a delta header whose BAT does not cover the target X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_setup_metadata() takes the number of BAT entries from m_Size of the top delta header, but checks only m_SizeInSectors_v2 against the target length. A header with a small m_Size (including zero) and a large enough m_SizeInSectors_v2 passes all checks. Requests past the last BAT entry then hit WARN_ONCE() in ploop_rq_valid(), which panics the host with panic_on_warn. Reject the header if the BAT does not cover the target, taking the skip_off shift of request positions into account. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-bat.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 5ddb8ffdff07..7b12b0f9fe81 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "dm-ploop.h" struct md_page *ploop_md_page_find(struct ploop *ploop, u32 id) @@ -189,6 +190,7 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) struct ploop_pvd_header *m_hdr = NULL; u32 bat_clusters, offset_clusters; struct dm_target *ti = ploop->ti; + u64 end; int ret; m_hdr = kmap(page); @@ -229,6 +231,11 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) PL_ERR("Too short BAT"); goto out; } + if (check_add_overflow((u64)ti->len, ploop->skip_off, &end) || + SEC_TO_CLU(ploop, end - 1) >= ploop->nr_bat_entries) { + PL_ERR("BAT does not cover the target"); + goto out; + } kunmap(page); m_hdr = NULL; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel