From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0491280726 for ; Tue, 13 Oct 2026 07:56:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69D7tS2k009958; Tue, 13 Oct 2026 10:55:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69D7tS2k009958 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="mTbuOA8N" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69D7tRwv009934 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 10:55:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69D7tRwv009934 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48c69bdeaacso2124593f8f.0 for ; Tue, 13 Oct 2026 00:55:27 -0700 (PDT) X-Gm-Message-State: AFq9FYJmss0LZ9aIIizVT7Gqf2TRzr8hh+Bo6jFlOGwJthIJGexPU8Rv zC1y+7JspfIrMZfTVzMPBHNp2hafUQ/YANOlIIB1/qRwJkXoUyItkGlnzI6tRdPvS2UWY7VunOu fkITe3fjpNH8jKtx27K89HVyIZfF+xO2T4mY/dXKuBWSvaPx5BYwOKA== X-Gm-Gg: AYBFou0ji17z/8Wi15NPwPBwt8jNI860n64U2zbf8InoQnqm5moj9qzEhFUosLIogAh 1OFuwLh5I/L86/uDQGobgpfrZrkO/yKM+UapQpaZNulu2tD5DbJLaAH95eQoe3jWYfRrNv6DRhi O3Jj5MdukQWpHbI4QvLCCqaCsWfAm7dH2QOvylVciKTfbKI9a8zdKUDDrlRwMURS6aHruUIh/I1 y5BXZNrySGgSYe2J6o8YubfC37ILZsfiHF309gf5zaif4vaOPU63zZRZGHAcJVOmwFYjdrIIuW0 PZXTx3M7FZlurO4xIZWvfirZUWU6375Ky6XaLScPqmJ4YJvnlAQj4Ol7GkiNg0mT9I8gcvaLA2F vvIiBoGYhVPf2KUBR/RLh6ei2jZc= X-Received: by 2002:a05:6000:46d6:b0:488:83b1:16a1 with SMTP id ffacd0b85a97d-48dba789368mr12995720f8f.7.1791878126736; Tue, 13 Oct 2026 00:55:26 -0700 (PDT) X-Received: by 2002:a05:6000:46d6:b0:488:83b1:16a1 with SMTP id ffacd0b85a97d-48dba789368mr12995686f8f.7.1791878126156; Tue, 13 Oct 2026 00:55:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791878126; cv=none; d=google.com; s=arc-20260327; b=MkFqcGE2qtECKMSuTTWSPXNYCa+c+0AQYfcUcNxAOHCbBwG4wCwahs73sFUOT64NWI 7SRLm0YENJj0JcT8MhI+wHl5JPkJleM6OF+cvh3aWXqY4dzczxUY1v7hWyBjif0lphro U+qrE1Ot2WVfsJnc/OREYVVqTec6e65+enat/oI8sH5+yJoJdx8F2xSPF8B8y1ze2Bzd tn98TRreGt0yJGKL/NxJ4qpEVVBTzmiRwkuYV7kYIUKYrRYCNpHr4oPl7RLkWYHDI1Pm 3akMKiWul0cdNvWiSDGwO+pw5JXcNo9zv5TyoIL48yEfsWpemUKPvpw2z26uk842H4mJ HyYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tj9oV5sudd4onI61vAo7lfIUu5DtFQHB0f29SE0KHMo=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=L7OTXnrU42f1QLSByivxeaoHIiMhxOSLIXyiBB3+SKJ1oR+HUcXz0537RObgob3jBR Outy/Hb+N4EOti1WS7Cpx/xGw9W2lLwkECO+fZi6rw7Cc3FMhNFRVz+ufCB+GJ4j+IUV WJjhfgJ3UNMj2gEG67lUZ0VBjoeFXRJNNplXQ3vL9MKAio5W9M/mtsQSQPeEaJpc4QP0 wz8jg8jkkl4Qz0odaMirX5eW0PznNDwedCtU2JxfEYT2mtOjKCKTZkfsa3Q6b72nNhh3 RBG8x/yEyTu7slteTN82usQ9DCYG7eTI2Q1ESr2+IdADBVEiqGcH1PlEvNqLE+eh+OVq F96w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=mTbuOA8N; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0ac8256si3808468f8f.109.2026.10.13.00.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 00:55:26 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=mTbuOA8N; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=tj9oV5sudd4onI61vAo7lfIUu5DtFQHB0f29SE0KHMo=; b=mTbuOA8NG7Q6 FBdSRYUL1SorEEdDnaL0C/vCjaIPaxadKmjRvxvnhk9efQ1P6ZQ4eMWLc1u1R7UfmrUgXoi5O9M/K 7N7XAjTg1507FpxkmaAAyaF0CgE1HARuaZzBOCnrrDXUm/+0E4N9t7wck/UHRHJkyBicfcSvFOID+ 3LnY6Sqe6GwUEMOqwVLa/RxR1bV6QL3wA/CHrPwz3jk963zjrjkI2vqPTwQ6RXDr6uw+8v7NpLy2c 8e3RPocMXBO9HAWGAjrIy6zIzEal2KVHqfRhQiWal0NhTGdkbpwETBUL7Rx8K0cAbSgkfr6d9aGHL M+655GhI48XyLhXPChxJVQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGXIg-004zlI-22; Tue, 13 Oct 2026 09:55:16 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 09:55:04 +0200 Message-ID: <20261013075513.90618-3-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013075513.90618-1-alexander.ivanov@virtuozzo.com> References: <20261013075513.90618-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 02/11] dm-ploop: fix lost wakeup in ploop_allocator() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_allocator() checks prealloc_size and kthread_should_stop() before setting TASK_INTERRUPTIBLE. If ploop_req_prealloc() sets prealloc_size and calls wake_up_process() in between, the wakeup finds the task running and is lost, so the allocator goes to sleep with a pending preallocation request. Later requests for the same size return early without waking it up, so the request may stay pending forever and waiters on dispatcher_wq_prealloc hang. The same applies to kthread_stop(). Set the task state before checking the conditions, as the canonical kthread loop does. set_current_state() implies a full barrier, which pairs with the one in try_to_wake_up(). https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- drivers/md/dm-ploop-map.c | 44 ++++++++++++++++++++------------------- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index 48466435dd19..92ceadf41b42 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -2347,31 +2347,33 @@ int ploop_allocator(void *data) struct file *file; for (;;) { - /* we do not care about exact number here - risk one extra schedule wrt taking the lock */ - if (ploop->prealloc_size) { - __set_current_state(TASK_RUNNING); - file = ploop_top_delta(ploop)->file; - current->flags |= PLOOP_PFLAGS; - ret = ploop_preallocate_cluster(ploop, file); - if (ret) { - /* - * threads requesting prealloc must check - * if size actually changed - */ - /* ENOSPC is only for fallocate */ - pr_err_ratelimited( - PL_FMT("failed to allocate space: %d\n"), - ploop_device_name(ploop), ret); - } - wake_up_interruptible(&ploop->dispatcher_wq_prealloc); - current_restore_flags(old_flags, PLOOP_PFLAGS); - } + set_current_state(TASK_INTERRUPTIBLE); if (kthread_should_stop()) { __set_current_state(TASK_RUNNING); break; } - set_current_state(TASK_INTERRUPTIBLE); - schedule(); + /* we do not care about exact number here - risk one extra schedule wrt taking the lock */ + if (!READ_ONCE(ploop->prealloc_size)) { + schedule(); + continue; + } + __set_current_state(TASK_RUNNING); + + file = ploop_top_delta(ploop)->file; + current->flags |= PLOOP_PFLAGS; + ret = ploop_preallocate_cluster(ploop, file); + if (ret) { + /* + * threads requesting prealloc must check + * if size actually changed + */ + /* ENOSPC is only for fallocate */ + pr_err_ratelimited( + PL_FMT("failed to allocate space: %d\n"), + ploop_device_name(ploop), ret); + } + wake_up_interruptible(&ploop->dispatcher_wq_prealloc); + current_restore_flags(old_flags, PLOOP_PFLAGS); } return 0; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel