From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 34E7C80726 for ; Tue, 13 Oct 2026 07:56:51 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69D7taLx009988; Tue, 13 Oct 2026 10:55:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69D7taLx009988 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="gMosywD2" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69D7tR6u009938 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 10:55:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69D7tR6u009938 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48b09f01f56so1607374f8f.1 for ; Tue, 13 Oct 2026 00:55:27 -0700 (PDT) X-Gm-Message-State: AFq9FYL+gj2iSzawRXHkQ2ILmcJzDVg42BviRctiWOCzTT3KpUbFvHNE GDeAnK3zybUdJvPND8fQZ/uipxsBDSClbECtIYWNxISwAabmA/ont19tMu6k6fKh9t3eBPGJ6Hm CrmCIEtUY4jaofrewx9lRNCyXtQdC7u4bgJeAJVl1Q38jjSnoPeBuDA== X-Gm-Gg: AYBFou31wu2RqFMDnaQZnZOggSOd8N7fhNoNM0M+gP7Z/3+70qZ6huzk6xILpwNeM9m 6wJYRjnlLHtmwm07PClbYnjcd2HsWq3TlXI6oc8PeKkL+6UbkFVKDkxrtgD459jQrxgLFTqDm6L NgCrF0H6I3309LjX5QPaAwkHC++PJZgtCZCpuhE8HGbcWdy7IoZVl5C4CRllRrlboAWbm5J65Kx q8Hf5sF/IkjARZT6oQ3gVz/S4wc+PfCH338iJFwcQjXzKG3/o4EQRJ7xYRJyeon+hFn8y+1cRKQ gpAgGPYzGDCXLAtyteWGU+N1b/dchbI6Hp/PF6jUC78YbT/OHHyy9AuUy+T21j7zVuj0hllwpOX KOapXBzyg2OUNkU6F/1y9WHX3yAPK X-Received: by 2002:a05:6000:491c:b0:48c:7326:cf0b with SMTP id ffacd0b85a97d-48dbacfbafbmr20873645f8f.56.1791878126897; Tue, 13 Oct 2026 00:55:26 -0700 (PDT) X-Received: by 2002:a05:6000:491c:b0:48c:7326:cf0b with SMTP id ffacd0b85a97d-48dbacfbafbmr20873598f8f.56.1791878126329; Tue, 13 Oct 2026 00:55:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791878126; cv=none; d=google.com; s=arc-20260327; b=Hesr412bbfTMzc9LCX8Yr5gE2N9H4UMvSs9dmMUGLUajm0wIVKKNbNBaRUv98VSJS4 of6tb/2eQUlQgRNIO9tr3a/ERZVsSLzgGi+1jGOTiGquoxbSHjI1sX2q7P2RZPB3tMWa cDElQbozhsP94PF1UjPS3PcDpnwXZvAqCKMq/l5qM02+EXpRBQ/xYCL2BSjJOD9LTnBH /oQUaD/MUXEjM+c1b/rOpWuhaRi3ykDg2/gpIdy3B7Fg2ewv6VHquMqGXj9IlS+fXWbT b+qPHebHxQrBuVLrW2kATcpNb6/V2rK1Hc6ZcGRcPaAweo6ojgYwJpu+vtGhiyfGZ7cy FIig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=P926WhJaeMQZ6BvIkhVcdcwzlqY7hGAtJzdnu0rCbHOOuTwiwEA/nhiEzxtAyE8Qgq OZ7gDCJzH5Qz8agplZ2c0eQbnMR6XLtQ9Qv/+HTu1FklMH6OsZRz3XP4SJ/7GtlZt8VV nkf41WdT++utPYzkm2puR1sEuzQpwVpbanNmZi7hixYydj953JUWd0zaw+1Wr4BSUo55 adfLFxn7phnFy6u0ivI8hiOaxkk+liHM/+4dgHiNt3Z+Njw6llQ7620MIln0B4kJGC2H AOOxrN0BDX2jhiTRKQmuTVFqc1ZhV1WzKqssOAib4sQrnna/bb6qe22ClpOspJ4juERF ur5g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=gMosywD2; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0c04501si3936720f8f.368.2026.10.13.00.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 00:55:26 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=gMosywD2; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; b=gMosywD2Xccd nZZ85hKf23HCWFqNGGsKCC1PZS3qm3Yi+8WibJglN2pH2oxpy3GxfpRS7Jv9R38InzF5JzAI8GIds PBUQ4vPdM+xVj0l4b6Zs2QZq+9xXxJZiLMILoDDy1m7EOmdCRQKSXvqL45fi/gkBQThKChE4s7tW8 Td6b7JYQRzdW9ZpzyREmQI5LssXw9derjp+60DxeJFKFwiKm8OtAf5UTbOYxuk2RpD8oAqRzbY1Bi ZR0bauLt7g+KCPVTGMy8zdGsyQ73nX9VGzeFOoaM133TJTLIrcMD5OehstZVV3Br3IpsRGFE2i7Rw eXqhFew0yHwHE3qOKzU1Kg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGXIg-004zlI-2k; Tue, 13 Oct 2026 09:55:16 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 09:55:05 +0200 Message-ID: <20261013075513.90618-4-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013075513.90618-1-alexander.ivanov@virtuozzo.com> References: <20261013075513.90618-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 03/11] dm-ploop: reject a delta header whose BAT does not cover the target X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_setup_metadata() takes the number of BAT entries from m_Size of the top delta header, but checks only m_SizeInSectors_v2 against the target length. A header with a small m_Size (including zero) and a large enough m_SizeInSectors_v2 passes all checks. Requests past the last BAT entry then hit WARN_ONCE() in ploop_rq_valid(), which panics the host with panic_on_warn. Reject the header if the BAT does not cover the target, taking the skip_off shift of request positions into account. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-bat.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 5ddb8ffdff07..7b12b0f9fe81 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "dm-ploop.h" struct md_page *ploop_md_page_find(struct ploop *ploop, u32 id) @@ -189,6 +190,7 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) struct ploop_pvd_header *m_hdr = NULL; u32 bat_clusters, offset_clusters; struct dm_target *ti = ploop->ti; + u64 end; int ret; m_hdr = kmap(page); @@ -229,6 +231,11 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) PL_ERR("Too short BAT"); goto out; } + if (check_add_overflow((u64)ti->len, ploop->skip_off, &end) || + SEC_TO_CLU(ploop, end - 1) >= ploop->nr_bat_entries) { + PL_ERR("BAT does not cover the target"); + goto out; + } kunmap(page); m_hdr = NULL; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel