From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F2D67809C5 for ; Tue, 13 Oct 2026 11:17:58 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGlct012575; Tue, 13 Oct 2026 14:16:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGlct012575 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="RgfZ13xA" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGck5012533 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 14:16:38 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGck5012533 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48c511d9e97so1609309f8f.0 for ; Tue, 13 Oct 2026 04:16:38 -0700 (PDT) X-Gm-Message-State: AFq9FYIm/N7dHe5spskFwf0xqnVMfzmX3SEzcploP6XUNjxDzhpGcYAt K0V6OvhOd5yAbNkaHwITMTRQGuiyh+x+r1Lh1x/uKp+qGNJRw3uYFpjR/JFh/Fxoer8zIHuF2nR +PNwWxnXy7M/iq3+35NlflFa1QLUULYwk/48dxEnXwevVFzy5jwIrKw== X-Gm-Gg: AYBFou0nzERrWRUN1xvQletd1h6zgQ8V+JVGAWZwPhXG5TZ65Ev3yJ2bDNIzLoidTQI oaqoIEFUIWqAwcnWjqUy5T19TgPI7n+kYGuSV4vsI/io5SHctt3SMg6WjfIHwuM/jwy6Kl34Zkp zvHt1pEJzCJ2HLHiKHaixRGEIyZK/+8DrU6elQLh7i2BDu/uJIdrxTEu2zDL6P7cy0LuEB7Rgjf 0HKgrtwtsCYn4GTt4eNSX4lgxXMUFvf4MseCrrnaGr5hLPLjCdZcW8aKaqxNYf19L0T89gPOe7X +Dgwxi8tKYMpL0tpaAoeZK1b92eMLlKGK+ikJNQnXvDnoFyoW8g/Oszgae7FclsgH9yea2I8C/b /xJb5ida95Qo+k+Me/01AAGUyBz0= X-Received: by 2002:a05:600c:1c07:b0:4a1:b044:9ccd with SMTP id 5b1f17b1804b1-4a1b0449d00mr9295045e9.28.1791890198154; Tue, 13 Oct 2026 04:16:38 -0700 (PDT) X-Received: by 2002:a05:600c:1c07:b0:4a1:b044:9ccd with SMTP id 5b1f17b1804b1-4a1b0449d00mr9294085e9.28.1791890197409; Tue, 13 Oct 2026 04:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791890197; cv=none; d=google.com; s=arc-20260327; b=nfbf3ylbECeDkZh4ayAWjugywjDBaEerMD/frEm3f1z6HMiPugexJmTHMvbpkxsrQE VSSYi+XHu5aBhryy9FJhBRwxEhPoFTtrckZqP3WukFuUjEH3oI+py/rgiYberOJJYAao /PUosrCvagpy8iJryTjGBO75eYycdgqNCOQ2+WISW59RiD5DUs20cmOEHNy3w3YBqa6U F8NfFTSuezCUM97tsLhqnXkaeXGjGDKxW2hevrne0ng5ytqsB8hwgHMoaoeULgrmDKMh u74+jcSHkuEguKsrE5J6gbZqH4t2U6hknNGcDtcA/xEDx4LIJ97oNVzLAbef99GUBifX O3HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=8tAqExlVj2QZnVfDhuNObzJNbEc5uLE+s24ZUZjXrqc=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=re121MPx3fQU8hxqdsH0BX/xVKWPRU7E5uUcZoi2jPP3ewio76W8HYSVLBZz5WWPlA HSU99SaLEfb5VzSRWTF1tzWMS2lCT20QivaSpnfbYfYTDjIq8g4fBiwCeDbk77ny94Sv PqMxEX2NpasO18dwuMjNEKtERgfmi1psNTC5COEZEbOwzvCbjkZ2GuI3JtO1m35H7Pul d5JhFHk0uRqV1JAmwWmsSxPI8O13etB+OfcFpxwFrZIKF53FwX39Ffs216lK+exYa1p8 kQQ8pC47cSVaprd8CiNWE5LG1FsEYlkt42KFVIxya56ICFsy0h1FU9QRxpEGvvhQTyeO hSew==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RgfZ13xA; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0ac807asi4710183f8f.77.2026.10.13.04.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 04:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=RgfZ13xA; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=8tAqExlVj2QZnVfDhuNObzJNbEc5uLE+s24ZUZjXrqc=; b=RgfZ13xAEJXt H4E0nct5N+kwUhh4lEVaYz29BG87aXGf2MzpR1EAUXBjZa34B3wcW3AG9MaPvpmSCXAjpu4jdwjHL 23UOKxPbn1Ra2cELIv09zxmVG7jg3vqCcVwsSn7FDybMCpjEUyRin1bv+U74PvTJhkIU/+/qjcA8g sE99iIWl1kni1MlzLbK7COKQmh2OmE/Jr5ROvLyP0H2eZX3ZWpXKCVyNjaIwpcqTPWIXqyRFzwPSU vQfBaBsT5Q8oxANKxEsHqkY0XRGQacHGUtTKvbMIxRkhcLIi5unEECp9pq9dnUzDMqGrEUNwXm9WO s2+gs5zrxxkIFXQ8nLWkaQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGaQz-008pMQ-0C; Tue, 13 Oct 2026 13:16:02 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 13:16:02 +0200 Message-ID: <20261013111604.142989-11-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> References: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 10/12] dm-ploop: fix flip_upper_deltas racing with resume X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_preresume() checks noresume under ctl_rwsem, drops the lock and only then clears ->suspended. Messages are not serialized with resume: target_message() uses the live table without md->suspend_lock, so "set_noresume 1" followed by "flip_upper_deltas" can pass the check in ploop_flip_upper_deltas() in that gap. The device then goes live with noresume set and the top deltas swapped. Clear ->suspended in the same critical section as the noresume check, and only if it passes. --- drivers/md/dm-ploop-target.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c index dc9410212831..abb60aa6a1e9 100644 --- a/drivers/md/dm-ploop-target.c +++ b/drivers/md/dm-ploop-target.c @@ -757,19 +757,20 @@ static int ploop_preresume(struct dm_target *ti) struct ploop *ploop = ti->private; int ret = 0; - down_read(&ploop->ctl_rwsem); + down_write(&ploop->ctl_rwsem); if (ploop->noresume) ret = -EAGAIN; - up_read(&ploop->ctl_rwsem); - - if (ret == 0) { - /* - * We are singleton target. There will be - * no more reasons to break resume. - */ - ploop_set_suspended(ti, false); + /* + * We are singleton target. There will be no more reasons to break + * resume. Clear it under the same lock as the noresume check, so + * that flip_upper_deltas can't sneak in before the device goes live. + */ + if (ret == 0) + ploop->suspended = false; + up_write(&ploop->ctl_rwsem); + + if (ret == 0) ploop_set_wants_suspend(ti, false); - } return ret; } ALLOW_ERROR_INJECTION(ploop_preresume, ERRNO); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel