From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2D4CC8017D for ; Tue, 13 Oct 2026 11:17:48 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGYX9012523; Tue, 13 Oct 2026 14:16:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGYX9012523 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="UiRRyT5J" Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGCbe012460 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 14:16:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGCbe012460 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c34edc241e2so195827066b.1 for ; Tue, 13 Oct 2026 04:16:13 -0700 (PDT) X-Gm-Message-State: AFq9FYJgERajItvfeOyIykMVa59v6EO69AAYBSagAfpT2TPhiUbyWB9n AWUkTZoLuiNNhKCKZxKD4QTpNNMfoSmYXpNF5EG+1EIAOl7vMfDc+/6WCUndPGYSY8oD/TEjVQB vIPkO9cABZX2UAC/uPNgN5E8g8jg68TgGJX/GUKz7HSjO3iEfXoBf8A== X-Gm-Gg: AYBFou2K3zKnWQmqvMQRD3qFLmhL/xEiiRpA7tnVIrWN2L3LVGBpDZuNYckvxHsWLrL qBkqDFiWTz2hfXpfOdLiF3AK3Wl0ANLqOeOnUhwHa1POrOMW0cQEM7inp0lTZ7j24VCkgNpwJpW N2xhIEwwFu1uXcavOMIySpNLN15G3Ujp4o42QTmYbwRx3ecngtW5JdIBHXh1yXYBhwPts5xA17Y 3LbsDpf7YC9UWfZWb4bMN6jWXFT3uISQRwiM8UgHu1/3UKCugm0xzHx6Z8UqwewoyFqQpKOoWYa 6iRqZ+hMMO3hLzlKY0sxMbbPvFYbWCJhk4RI/mBO+9SMVxd2rqn4Nfb5FYtPQol2X231KPXZyKb C5WUw/fljtaGHNDq4/foCbcxcs21G X-Received: by 2002:a05:6402:5285:b0:6b1:497d:1c64 with SMTP id 4fb4d7f45d1cf-6b17c293eccmr10706469a12.45.1791890172534; Tue, 13 Oct 2026 04:16:12 -0700 (PDT) X-Received: by 2002:a05:6402:5285:b0:6b1:497d:1c64 with SMTP id 4fb4d7f45d1cf-6b17c293eccmr10706318a12.45.1791890170133; Tue, 13 Oct 2026 04:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791890170; cv=none; d=google.com; s=arc-20260327; b=pNIlPLOTfHO3VxwKVx9KVCMJ1SyeKuJVEa0gFPVbtJJRwXEzRk2glUBRcXybQodL5q 5mPH2GNo4/hmt8gZIw9193fGDyFCFKs4d1F/nJusuIZmrk9B9FeqkBaJPMaMSY+LJFrG 764A49n0EiEo+Q9qlnAKk1PqsjLqYh+BpDfveVvIMJQ46HPdjB4eEj1g6ju+RLFstVGz KgdKkG37WB1kj2QdTIsoLrtK2Sdm7K2VNYgqSWdMjAmByIL0EKJfr6HcS9XTklqSZlvd gZkADaZF/ojIODEkzFpg8HQ4+Xnrk6OMS1ejqch7gm+ZMYPARHVZlH9pDR1vDdXy/ZdE 7ccQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=gGVJcx651uWsFNYQ1eiAswnu/fBO/jPLM9r6gE4KQ11du/3pXNb61KBKYxHn/8TxrW prW6xEzUzffmLARugnwOwTlF+wP8n92XQ2CAYvHZ0Yxfst+3pUGkoT/VAuw4cHLDwEkP tyNSC5C2eTPsQnnckUnU9w/a+VgGtclGqV3K91KP/Hnqgw7rkMZTkcN1K5Pysu2Zi/Qo IFgmCsvCaOqNAeyKznc/ZM6S7+0yW6aWec/XDkcxi7kZf3kRbkPj7wDp3RYd2X2f67YC Jj4qxVWa4eQLeDOSvByPrtw7rQIwOtQdfNyDgPZIy84Q5b6MvJPQ6HKEAXtjmfset4MB pGfQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=UiRRyT5J; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0c032d7si5106780f8f.367.2026.10.13.04.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 04:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=UiRRyT5J; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; b=UiRRyT5JRcl1 92cH0k/X3ZKPWWTxqyQP58guCrOPDxmQNFlPsFoNOS+G2E4HGnsihlajJ6yLP4TH8JZ1rbgHIw4Nx k+3HBY/AhdClPaqGlcmCiR0dgydpsb7j9hS+3Psbw/evYmPjMLibB4ETvdaK+ZgMVbS85s3h5zmcQ 89Na4QydKtyOPnSEx07PJSOVdGDz/2ALR/vx+10VCSgLiGHSxysxn198aJI884xifwwh2IY7SLI4u A9ku51EqBV9QEB8r+JLHhAzs4cB0sl5/d/SKngqxj9V2iUdcl+EFUC9X+BEEU+1VoafbQ4/sKcTwE yNJqaJNrwaTaIZolC2+PMQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGaQw-008pMQ-1B; Tue, 13 Oct 2026 13:16:00 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 13:15:55 +0200 Message-ID: <20261013111604.142989-4-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> References: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 03/12] dm-ploop: reject a delta header whose BAT does not cover the target X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_setup_metadata() takes the number of BAT entries from m_Size of the top delta header, but checks only m_SizeInSectors_v2 against the target length. A header with a small m_Size (including zero) and a large enough m_SizeInSectors_v2 passes all checks. Requests past the last BAT entry then hit WARN_ONCE() in ploop_rq_valid(), which panics the host with panic_on_warn. Reject the header if the BAT does not cover the target, taking the skip_off shift of request positions into account. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-bat.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 5ddb8ffdff07..7b12b0f9fe81 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "dm-ploop.h" struct md_page *ploop_md_page_find(struct ploop *ploop, u32 id) @@ -189,6 +190,7 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) struct ploop_pvd_header *m_hdr = NULL; u32 bat_clusters, offset_clusters; struct dm_target *ti = ploop->ti; + u64 end; int ret; m_hdr = kmap(page); @@ -229,6 +231,11 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) PL_ERR("Too short BAT"); goto out; } + if (check_add_overflow((u64)ti->len, ploop->skip_off, &end) || + SEC_TO_CLU(ploop, end - 1) >= ploop->nr_bat_entries) { + PL_ERR("BAT does not cover the target"); + goto out; + } kunmap(page); m_hdr = NULL; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel