From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 897BD8017D for ; Tue, 13 Oct 2026 11:18:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGVNf012516; Tue, 13 Oct 2026 14:16:32 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGVNf012516 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="PAEAuX4x" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69DBGCNV012453 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 13 Oct 2026 14:16:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69DBGCNV012453 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a01b112fa2so42531955e9.1 for ; Tue, 13 Oct 2026 04:16:12 -0700 (PDT) X-Gm-Message-State: AFq9FYKjMn/8ThxbKPUqvyu7hly3YT4IbJwkY9zoF3K8n+ZYZmOGnVMa iqtL/tWWOfJ6+HRZWU0ialsj/mJOAyzn9yOTkQh/vLB3sQEAlvDSHgNSDKmeojL6gqhsjPpY9SQ +LZtVP0NOZPP2MlrnueEsVmxPhv5JHPbxdcIo3YS/CIJcYsn3nk2o4A== X-Gm-Gg: AYBFou0VXkVdVDZXiyBT84Vu4MFaOhbZhr2AXeN6l8XIa83vOWoK37+kSBqU1jT7BKX qgevfH5ZbRAHFMWwxM/gM43WLSTYvMJdeHKrxN4NNqQ4CFRhIWHPxyJwBBlYra1hjS/iCe95pwm Zf/mdgCx0jMBiK85qQOOqeUZ3lujnqJGXcWiypbq7O5pKa7X+gsNBOxxU0lIYRkXFRpdGFkQXBP R89iN3jJ4w0BPULVtw9nUa/x+KeADrrmH1VIOL0q70KkaWrFqoJtUhxM3hTlIb2k+HT1IxUW4Qa phEkJqZHQimHsb8FYpECDDKczRynh6S7TMoh0bNE2LFx/v3hfRqVyPDP7FCv40cLsNMt24bYz/d zEWQHzu1HsP3Xs/8ePeMFWnZQQ4Zc X-Received: by 2002:a05:600c:4e43:b0:4a0:1f90:594b with SMTP id 5b1f17b1804b1-4a18e4b67e1mr220590315e9.22.1791890172218; Tue, 13 Oct 2026 04:16:12 -0700 (PDT) X-Received: by 2002:a05:600c:4e43:b0:4a0:1f90:594b with SMTP id 5b1f17b1804b1-4a18e4b67e1mr220589005e9.22.1791890171006; Tue, 13 Oct 2026 04:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791890170; cv=none; d=google.com; s=arc-20260327; b=jlpDcuLm3ChM4ZVD6VvVdd+NyoCn1NrOvYtcpti5UNNjiwfdHxAiJ3zsU4Vvjnk7If 1yNbTAFMwMIcgSBeJNtELLhX4vjtXtwzOuwDnVIVoDNpdHEY/8qS4Rk5Nsiz18yM/c+C P/gClxnep55AqCd05A+nKovoyix64l9M2jgJI/V2yFSPFi16dzxJnkQ/ET4H+YaxZ05Q I0jrmfN2BdGK7ZJt8iVJe4WoNOO+QB3t0ipcDzY+v/jiMRe3jfi0iy3Sq0Mev0pb028l f2C15Khd3VMoTI5ZnJPKThhasOsEKNyVyplHdsB8/m9whdzUkXt7pG8hjlLJG97+nN2Y K/ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=PyddkjEHIPck8bzYCzzFrzm5PHvZPbMnv8wcMopIueE=; fh=M+TyAUhAp4+t7uzAVeqNdLHW5eNz2FQXSv4TjrRhpCk=; b=NVA8zjLx7jxxZed6pcX4UME+IOP3nv68EYexx0rzISr4BXu5VmS3x31522yhFlEMus EsxOIuhjrsY+54aq8HjCtKdNxPKeEiY3ct97/uGdRQScCqUm395KukP3lUGl4ISPk6Sn s0/0by5yCHqJ6XUyPSqzqEpZ3Y+8FYtKq+Xl6qHNVh3lzjk6WlgQarMKFuc90NdbZ/+S 9+mZirHKFhlFu2rjC49KdtEB7Q5NWb6vTx7puLVqVDPxXo5zGLl49W6fJsoDkvGXXX0H dpu+mG90tpmPQN+PtCf+4URbmxQIghhUNl4J4aQ6fIHVNmVZMkYxebhOsPgqHsYHmV2Z baZw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=PAEAuX4x; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48de0ac89adsi4852446f8f.113.2026.10.13.04.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 04:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=PAEAuX4x; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=PyddkjEHIPck8bzYCzzFrzm5PHvZPbMnv8wcMopIueE=; b=PAEAuX4xIRBz TlyITpZYMyEnF0WvFIWeCf0oqo0XmvluslV+OyNIpLFMruHZoD6A66rbEqYuOYa8lW2er22FsxIwi EIAoOrA8EG3gNB+Gy+ckF0A1KNgSowDDC2zDYfKF2s7z4EcErDrHFhF9NJ09xCuCAxovuIrikssns ykpttKI65xgyqn41ZTFwGF+q25Z+vrzKFL6UlVpLGNjcbWoOzw0xaoA73+Y/UWyuNpDxndk9VGkQQ 5sI2LhdQwlzzcW+I76q1BGNhI0vbhwZ/2fWU2z0P3dZN7n6KuqRlCgmINnbDo5+Jn9O4ssNBn3U/v 5DDCGz/q9jH9FyrxfS8raQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xGaQx-008pMQ-0n; Tue, 13 Oct 2026 13:16:00 +0200 From: Alexander Ivanov To: den@openvz.org Date: Tue, 13 Oct 2026 13:15:58 +0200 Message-ID: <20261013111604.142989-7-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> References: <20261013111604.142989-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 06/12] dm-ploop: factor out ploop_read_delta() from ploop_add_delta() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Move reading of delta BAT and applying its mappings to ploop->bat_entries into a separate function ploop_read_delta(). It will be used to reload metadata of already added deltas. ploop_read_delta() takes is_raw from deltas[level], so ploop_add_delta() sets it before the call. Replace the stale comment of ploop_add_delta(): it claimed deltas are added from oldest to newest, while ploop_add_deltas_stack() adds them from top to base, which ploop_read_delta() relies on. No functional changes. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- drivers/md/dm-ploop-bat.c | 43 +++++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 3427d1a90d81..5a89771a2e02 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -481,23 +481,27 @@ int ploop_check_delta_length(struct ploop *ploop, struct file *file, loff_t *fil ALLOW_ERROR_INJECTION(ploop_check_delta_length, ERRNO); /* - * @fd refers to a new delta, which is placed right before top_delta. - * So, userspace has to populate deltas stack from oldest to newest. + * Read BAT of delta @level and apply its mappings to ploop->bat_entries. + * deltas[@level].is_raw and nr_be of upper deltas must be already set. + * + * Deltas must be read from top to base: mappings of upper deltas take + * precedence (already populated BAT entries are not overwritten), and + * size of the delta is checked against nr_be of the upper one. */ -int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_raw) +static int ploop_read_delta(struct ploop *ploop, u32 level, struct file *file, + loff_t *file_size_ret, u32 *nr_be_ret) { struct ploop_delta *deltas = ploop->deltas; struct rb_root md_root = RB_ROOT; - struct file *cloned_file = NULL; loff_t file_size; u32 nr_be; - int ret, i; + int ret; ret = ploop_check_delta_length(ploop, file, &file_size); if (ret) goto out; - if (!is_raw) { + if (!deltas[level].is_raw) { ret = ploop_read_delta_metadata(ploop, file, &md_root, &nr_be); if (ret) goto out; @@ -512,9 +516,33 @@ int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_r if (level != ploop_top_level(ploop) && nr_be > deltas[level + 1].nr_be) goto out; - deltas[level].is_raw = is_raw; ploop_apply_delta_mappings(ploop, deltas, level, &md_root, nr_be); + *file_size_ret = file_size; + *nr_be_ret = nr_be; + ret = 0; +out: + ploop_free_md_pages_tree(&md_root); + return ret; +} + +/* + * Add @file as delta @level. Deltas must be added from top to base, + * see ploop_read_delta(). + */ +int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_raw) +{ + struct ploop_delta *deltas = ploop->deltas; + struct file *cloned_file = NULL; + loff_t file_size; + u32 nr_be; + int ret, i; + + deltas[level].is_raw = is_raw; + ret = ploop_read_delta(ploop, level, file, &file_size, &nr_be); + if (ret) + goto out; + deltas[level].file = file; deltas[level].mtfile = kcalloc(ploop->nkt_runners, sizeof(*file), GFP_KERNEL); @@ -535,7 +563,6 @@ int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_r deltas[level].nr_be = nr_be; ret = 0; out: - ploop_free_md_pages_tree(&md_root); return ret; } ALLOW_ERROR_INJECTION(ploop_add_delta, ERRNO); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel