From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id EBCED8017D for ; Mon, 26 Oct 2026 14:44:01 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QEgk6g011700; Mon, 26 Oct 2026 17:42:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QEgk6g011700 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="J9RPWMht" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QEgT2G011652 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 26 Oct 2026 17:42:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QEgT2G011652 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a359c7f47bso17648335e9.2 for ; Mon, 26 Oct 2026 07:42:29 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBwT55Qr1Zt7oTmIG6IztY/sDq0lMeEsei7UxpV9FABjH7gb1bkx3UVu2lJWgYMqLo1fw+NQGg==@openvz.org X-Gm-Message-State: AFq9FYKuhQD5RlerR1fm7cOy8pNttUuqiGUvr/x1B4cITcW7ZSNE62O7 7hEPFQa0k3LgMapLFk88skk6TXEDt5hZfRukG99zmRqMlpQcv2kei8W1VmCL7IHbGoYOAOjCs3S YTgWgOrOAsKkjwWGobDzrIAyrsEKDw4T60+reptAwWyas/1nHotiL9w== X-Gm-Gg: AYBFou2/d8eBfYN/64w5X58ihA0lgOmoemiNnwmtumINWuoM0SoHZn1HzxkELN429/+ n3xObs8Xub0ZB2MtjBIdWE0ScQ8x9z7bjuquskiOHaBjk0vhhW7yyKm4kMzqt1yastVsHibcMHJ mcAhuTk6TpRQZu6QNjRyX3/5kSIu8jfxOyJ/Dr7j3GgmzSNJn4kQqsRIlmzX30SRHnPFKKaZdO4 +b9q1HDcASN/T7SEr84rQWe8lCNFl2mfJzZ6Fc7HofwILhMJP5xQA5wcN7nClwT7lMyAzDrdzzT 6929rFc9m8LZb5Yq1SZ368+0fY3C5JhOEQXX518Qz/Ru8M7dY0NR3L81XYtwAcf+bp/bjNyhxbb SsHNuK0YkfOC8NOXQeHKEv6p6ZFM= X-Received: by 2002:a05:600c:530f:b0:4a3:2f35:38b4 with SMTP id 5b1f17b1804b1-4a35ac8b2a7mr143096475e9.10.1793025748791; Mon, 26 Oct 2026 07:42:28 -0700 (PDT) X-Received: by 2002:a05:600c:530f:b0:4a3:2f35:38b4 with SMTP id 5b1f17b1804b1-4a35ac8b2a7mr143095565e9.10.1793025748154; Mon, 26 Oct 2026 07:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793025748; cv=none; d=google.com; s=arc-20260327; b=ZE+yOzkF69GzWawj3j41m/sn7lUNhP39Mv6o+28kwHYr5BHqiLXeXwXzUsnVfrr1OK ySndkNog+xR+s91pe2dTQXB7nx75NpUtAhtzYWhdoVccxgR0G9Dl4bxFlGzyzYGhVXRz pVOqNfaVw24A/j5LFSA3QBZih+2gq2tMRhenubUGOzsLNxbWl0WF+EjUHojK4mv/1wYe Zj60EKnCo4/nX+030FU7fa//YkwO85bAVZwKK0mnf0LVTcBPQFJAP2Ru0kVuj+uKwZws iuYwfz1FWLyjubXBH2K+eMz3kmfEduBFp0oeFMzy3bJNdS0Tcxx1thIlgcXkTMJkwIHH 0LPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=4w8Rt36nEAfXvcf5cQFqv3T1RCeO+BBIfenaWHn9cEQ=; fh=1MEQxOGYABaQPNQS1Ckioh0rrUOwgCYjd8t5csgx5as=; b=gv6izJq9+B4YIEFUFdrG/mHvMuayfHB+rp5CX8fuR9rIJtjZ+NwdJBk9/9dqp2Sx3z h60Xmxp/uZYgSr8zD744b5c30nR8g7EvJFTksTK5J0RbaUp0MVRSvmsDWdVapMb+I4Dd r41Ef0zy3DGnqstc+6idEoWUlF0HAqsrFx/WL/B4OYbVWP5dMHEj1k4XtTwT421LVvPS Cairltzf9Pqm5z/sQGdC+e/FdArrMBtJtsaECgDnGQWdDH/hYzMrX53oyqa+vjjpsEH6 9qmi8kyl3qvuj2i0oebo2I0mmN+ORNejldP6udviHWkA8iq+OEx9VQcLLbXc+rM1xHuQ FKNQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=J9RPWMht; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e3ece88bfsi13780509f8f.167.2026.10.26.07.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 07:42:28 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=J9RPWMht; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=4w8Rt36nEAfXvcf5cQFqv3T1RCeO+BBIfenaWHn9cEQ=; b=J9RPWMhtQ9zb ymTEs2e0kt/0W/ax2TzYn5dGLA3St0QPSsxu0TRutxuQ6wm97/yoV2STn6fA3a58kanU62CocJG+6 rooGI3BHGfyafQLDRugYDOCkug8AuQZAUF1wzptn/67CUZrOfJuA9XpwFeLCJ9/3Ra9jkOR+DBG9H JKkw7bXQU8NtHYG03hS/87azp8Ulh/lq8ZiBlyd8sjLvt8o5rvq9OLiIyKqZcreHYP+FGkvmxiy6z fmr+LL17+3XoxWu6B4HBYCD1wAQFEkOc0D+ouf8J3MXUvOaa8ee9DaiYYZG18Nilb7fnsfaH6BmtF ICc+Uc/Fn9zMqNJ+HKyDqQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xLLqO-004nT9-0T; Mon, 26 Oct 2026 15:42:19 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Mon, 26 Oct 2026 15:42:21 +0100 Message-ID: <20261026144223.2787145-5-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261026144223.2787145-1-alexander.ivanov@virtuozzo.com> References: <20261026144223.2787145-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v8 4/6] dm-qcow2: complete wbd before ending the data qio X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org data_rw_complete() calls qio_endio() before complete_wbd(). qio_endio() drops the inflight ref, so qcow2_flush_deferred_activity() may return on suspend while complete_wbd() for a failed L1/L2 writeback is still running in AIO completion context. revert_l_entries_update() then marks clusters unused and dirties R2 after the flush, and the change is never written back. Complete the wbd first. The md writeback path already does it in this order. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-map.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index 5952b5feb8bf..fa63bd6acfb8 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -2888,13 +2888,14 @@ static void data_rw_complete(struct qio *qio) spin_unlock_irqrestore(&qcow2->md_pages_lock, flags); } + /* qio_endio() drops the inflight ref, which suspend waits for */ + if (finalize_wbd) + complete_wbd(qcow2, wbd); if (call_endio) { if (bi_status != BLK_STS_OK) qio->bi_status = bi_status; qio_endio(qio); } - if (finalize_wbd) - complete_wbd(qcow2, wbd); } static void perform_rw_mapped(struct qcow2_map *map, struct qio *qio) -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel