From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DD3678045D for ; Thu, 29 Oct 2026 13:00:48 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TCxWHk032653; Thu, 29 Oct 2026 15:59:32 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TCxWHk032653 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="jb/Q689O" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TCxRZO032631 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 15:59:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TCxRZO032631 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48e0c896d05so1756979f8f.1 for ; Thu, 29 Oct 2026 05:59:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvByMYoHARVlb/boIiYpLe46QSw0bk7YSW+qba8DO/QdtedcG7qsr4jQKMYdy2uEJQdzOEs6QVA==@openvz.org X-Gm-Message-State: AFq9FYLiWn1eb7Kq+omcMPryW5JtW8NS+zxppLMHEcpmV9RKecuCcIlb 7KEYm/1VPCvqwiGsczZvP2sl6XUGfTtsIfjMYmgIKlO63gHT1SZqFyswmCZmWjLX4otXfSMsLwA tKWg7yUh4yZ2eUROnv+E0hHghsuL7UcIgQkmsr9xOugg1SE7bqB1r/Q== X-Gm-Gg: AYBFou0n+asZQrY6Vfwkifgg0VJjOigPcGXaXgTMB27TqnU9cHLynN9iqSSl62K1nE/ +GvuRNjfvNSb4SJRykxcnDaD0tR+2CvhhxHTH5bqc3q+v0ZSrgJtdaRABBSatRbIfQ9oZbb6M9O 8Lt/J4F3ARsvYi0kqFjzdxQ/yXBiqKAshTRSiazsAQQeO8lKDCZ3BPytlRlCFw2VcpfoBKPV0ww EKWfBCIuc7L9O7Z/HiMI+0Z+UvQo5Ccl7yZx3OSw0H7+d/gTdYl+Cex/CYJK6wm+aEvDATnb610 GVDAdVBZ/dpYlJhnr1Hp/pLoasUfk8QnLpRUQ/U92lOL1nGCzQ3CKovkyPKCCRyhQkV82dWz/HI ji1b9ocOsQGAYjLW+ihr6rNKSUo5k X-Received: by 2002:a05:6000:184e:b0:48e:4115:f3e8 with SMTP id ffacd0b85a97d-48e5d2f1faemr12364688f8f.27.1793278766913; Thu, 29 Oct 2026 05:59:26 -0700 (PDT) X-Received: by 2002:a05:6000:184e:b0:48e:4115:f3e8 with SMTP id ffacd0b85a97d-48e5d2f1faemr12364645f8f.27.1793278766397; Thu, 29 Oct 2026 05:59:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793278766; cv=none; d=google.com; s=arc-20260327; b=Ms0EWRnNg2EHa22eGWaNE6VliUFaeM96KLao75wV7z9LhSuTzQfa3IjeqfAmCyvcPd 9YTp+53qe4fNPBS2ajFT1RP7OVBb6vtldXJMAh5hLiIZWbkCTY+Qxmabz/dj0O38rSPM u4o9acS2mzuF+V/cksp/X1hbCQXvKN8ngcmYknZ7HVsX4VP20I7Bl3APbxWVUGqhGef+ wSj3l5kVhQObuZQ6m5E8PWooqhDhD50iO/gQlT0M3e8CNjtZUFivYW4sbWWV+EtXsA1r 80r4kAtHt28m52/xiSW0ksEcf2ulaZEsxBv0mycG0go0cKa3S4SXeYlA4XMqdCsFGVyd I3IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=BD9VpO9U5KLmjagS6gX8/tkHnOR3HZdDia2Kc8wRiis=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=Go85MAqriyPscIxiODhsKx6dQZmxbi3I5KzUA/qzW51+T9+0FMa9aVp7VnWz0RQUVh nOpP3DkO6A9iKGCVp79hlzHnDG8aLU1M/wQAl2v2on3l7HooHkexdDG/Zv+IhAlklU/I 1bWjXAH8x0BCDzY/d6bx0ZJxZrchGiWlUBf99J9NSk3EvVHYeI1QJawSEQKSmcx2lh+5 1Le9HxtOoLF683NqQXxc5izjvueuuXfjPcEuD37901S2sE2W2Iq4Fq0Jhm5T9zTnDqRG Ju+MHrGjMWQBW/ah+CHyjWjgXmfC6WvLR/X7S9p52Npw98vGvPHEDOu3qFQGH1jodvRb AC1A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="jb/Q689O"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e6626f2d7si4399564f8f.494.2026.10.29.05.59.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 05:59:26 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="jb/Q689O"; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=BD9VpO9U5KLmjagS6gX8/tkHnOR3HZdDia2Kc8wRiis=; b=jb/Q689OK5/B 3FrKqeCCj2Xdg6Z2ZazydMneR5Bx1w/Y8v1/da/v0oNGMcc/OoO5cgVusgnWs/ISm3AEGlgKfpiYC 4Y/UEJMGUV/w+ddeC08eDYue1WuhHDPAIi3NwIgibXq6NhU/mD4ZNO10PlB+hoRkgIRmzaRKvVCZw 11sxKAL3HpZ9LwVdBmh8NfbdZacoyHj/EPAY4x6+k1eigTscnGlvVIsWO0GA2AOLdy87H8vGxDh1k +QoiUnBhA2jT3dp1AuyZqI5RnnHdNHU9IQFIEPOGK1HlxY18kiiJqGnwiZyT9GKfrzdSVOCAXYpmA T7u37wRAKGCvWvWu4nto7w==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xMPfG-005INM-1M; Thu, 29 Oct 2026 13:59:24 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Thu, 29 Oct 2026 13:59:21 +0100 Message-ID: <20261029125923.3352735-2-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261029125923.3352735-1-alexander.ivanov@virtuozzo.com> References: <20261029125923.3352735-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/3] drivers/vhost/blk: convert virtio_blk_outhdr fields to CPU byte order X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org hdr->type and hdr->sector are __virtio32 and __virtio64 but were used without conversion. Since VIRTIO_F_VERSION_1 is offered, on a big-endian host with a little-endian guest the request header was misinterpreted. Convert both with vhost32_to_cpu()/vhost64_to_cpu() once, when the request is set up. https://virtuozzo.atlassian.net/browse/VSTOR-142755 Fixes: 1629db092dd7 ("drivers/vhost: vhost-blk accelerator for virtio-blk guests") Feature: vhost-blk: in-kernel accelerator for virtio-blk guests Signed-off-by: Alexander Ivanov --- drivers/vhost/blk.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/blk.c b/drivers/vhost/blk.c index b170439a1806..7234213924d5 100644 --- a/drivers/vhost/blk.c +++ b/drivers/vhost/blk.c @@ -454,16 +454,18 @@ static int vhost_blk_req_handle(struct vhost_virtqueue *vq, struct iov_iter iter; size_t in_len; int ret, len; + u32 type; u8 status; req = &blk_vq->req[head]; req->blk_vq = blk_vq; req->head = head; req->blk = blk; - req->sector = hdr->sector; + req->sector = vhost64_to_cpu(vq, hdr->sector); req->iov = blk_vq->iov; req->bio_err = 0; in_len = iov_length(vq->iov + out, in); + type = vhost32_to_cpu(vq, hdr->type); if (in_len < sizeof(status) || in_len > INT_MAX) return -EINVAL; @@ -478,7 +480,7 @@ static int vhost_blk_req_handle(struct vhost_virtqueue *vq, if (ret < 0 || req->iov_nr < 0) return -EINVAL; - switch (hdr->type) { + switch (type) { case VIRTIO_BLK_T_OUT: req->bi_opf = REQ_OP_WRITE; ret = vhost_blk_req_submit(req); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel