From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5DF2080E7E for ; Mon, 2 Nov 2026 16:48:48 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2GlUXF026973; Mon, 2 Nov 2026 19:47:31 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2GlUXF026973 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793638053; bh=YE03BYDx+O3e1yCmc6JL3y8m9hpZq3aWQgXoCfs/UWk=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe; b=W1hwpuQvA5U5lnPSpA6YVdNeBNCZuMLJGlSONwS9dYrYOf8ZS0VpiNr6OtaQyv3py AgyTTwKj4wqDphSfC4YItm+FAnSHJKks4BaeI+1k/KXX4xOtUneMlzzVocDXj+N2T1 83p2Kxnsg8/XaJt63fchSl+lTPz4WUIbUgEcLg5DW4lI6eCpv1gYHnRJm7hNRB0dE5 ZJB0ntUcyxFk7eHrMBvlmxlPW+aTEVeMAOpDexv6mcggXA6c0D753ZJRPWdTOyCL97 5iUHUAw57E8Pn6YkWWarMkfzhTT/b0YdKfAJEBsLcyPihVL6zHtnHtdh+zac4fkARt GVjipnQSfUXeQ== Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2GlTxM026969 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 2 Nov 2026 19:47:30 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2GlTxM026969 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="PIYe476p" Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5bcf39533ebso2078007e87.0 for ; Mon, 02 Nov 2026 08:47:30 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBwfF5CosFzEcZX0FRFvlyaVvjR+fZA1khboXn5k12dGBOUHSXaRRWC3u4DjE7liXLIPLPDtcg==@openvz.org X-Gm-Message-State: APuU4Z/VZKi/66j1B7xWK8KmBoXn+mz6kzu2vXFC6ylbChT/3NZz00ae LWBik61h+Alg59vxYrA4mVekVTRnyHNLhEpYCaFo1zWSs4uKCxS2hZfmPysdDSX/oaFkbxYg/Ry YCVoVLOuczWtIWAkgoMCxck3v7Ly2tnWLYZPctH0JwtX3qUGSLGADMQ== X-Gm-Gg: AYBFou0nAVGg/kvyCWtZPCrjvZfdu3YICMO+taqKHkisq8Ya/McBcP6WIx8f2cAFYsI SzfDnOgBERoEANwryLVgH16eVnZrjV/1ojG+S3OSb1FtXuHFZNAUJ5DEz1TJh2wrzURGM/VrL3E TIw7YgXUquKLdjxGwNMRKiSMqJxcwcBPJerlwX7jBGBYFGP6JLRP4FKpEy96+clj6HkIrptv8Si z6z8kZOjFRGKh0vqin+tYIQfttyJb4e6mgYuC5gj7M6naAHseDsCFGjBtW4cnOSgSbbRijrPivE qpoIf9x5Vg== X-Received: by 2002:a05:6000:2610:b0:48e:3647:c35d with SMTP id ffacd0b85a97d-48e6e2fcdfcmr25374145f8f.21.1793635943784; Mon, 02 Nov 2026 08:12:23 -0800 (PST) X-Received: by 2002:a05:6000:2610:b0:48e:3647:c35d with SMTP id ffacd0b85a97d-48e6e2fcdfcmr25374067f8f.21.1793635943341; Mon, 02 Nov 2026 08:12:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793635943; cv=none; d=google.com; s=arc-20260327; b=iWyMl3wRv1HIGGAuZSQlUsw7yLQ9qx3zVp+xEiPWsqf83Uk708SkStydYg2/TWD4/T 9boTVZXBETo3bS9jtJ89oz22ph4lmq/P/89HesS81HL6j1gWAxGyUZAQcyz/mvir2ubx 4R2FDiPIYADz6+e5i2aZRVV1btZZtsUhDNhvFlrYM/+uxEuHEG0XdhKratzoiDnH3joG SBV/OebHcIe0hUtPCi4C+GZcGuoeOg5j5c1zKdp50tvtJIqOrldMCjgkgQdqfowZlrjR kgqTrbFCU0O6ewdaPT+ZMyyVHpuoP1E7zLRhBX3lmU+QbX1Jy16BZmMB4IIj6FvfyGuq fagw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=I28D9ggFwHLZRAhGT5GqBUh7E0N16iE7p7bVfCCLiak=; fh=84bRJUIRmkLhryaMEbV3WbHJi2sNv29Op32XKwoydsE=; b=F9vP0dHofp3a/tbZ8z7gk+cHzpiwTQz1V2yfs6VSsu4kBwehU7ltJ88Rx54hB8XOMB ZfW7Iqu1drDj0xxIDq+yUNEdI/lxkPWRbg3KEZ8PEq1C+bH+izJM2MwkXGAwnNpU492x bqvvwN5y3nLaazlT65ff4eR91MjirGrJoKGEvB+7fndVFA4OKjMSyXbVa8o9M2Bu9kMm 2hTalDvjdAvn+l20Meeq1b2TXAlrllWrYrCEDXYDMkpEu05OQX64Sym/F3rZm1fRRmH2 28WP2KbKlICIgpR30EhObJ3e3O4cgK/zt5kzbR8cbpQ29DTK4aypNGfnUe/5FM0H9cbk OWfg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=PIYe476p; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:91db:48d7:7451:652a as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48e6eb657e0sor1517392f8f.3.2026.11.02.08.12.23 for (Google Transport Security); Mon, 02 Nov 2026 08:12:23 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:91db:48d7:7451:652a as permitted sender) client-ip=2a06:5b06:b600:300:91db:48d7:7451:652a; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=PIYe476p; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:91db:48d7:7451:652a as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793635943; x=1794240743; darn=openvz.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=I28D9ggFwHLZRAhGT5GqBUh7E0N16iE7p7bVfCCLiak=; b=PIYe476pQb+mvtg80nw5WRXJgYIU0+KLljkmLGo/yYMOPiVpCfzU+LALShnWOXunMB RsBf9T8YE1THtnfDlmVEQUi6xa8V4PBI92RnEk3j1SAzqYEuRCUxDhOQczXwfGi0IQrx NLVolH9kPr8rNr5phCdnA79NCpTLQ9lODFw9aAsyZUAcUesFFLcDC6slfE1yVeIaLNN4 g486upJnYshDP2fkX8gZ0aad4yxMILFPFrHNl/UfDjgVMklnbDTA36FNManzQfF9Dsls i2WUxajDqDckipXEycqgZTpwlBdKnYDupe0aoCI9ViduNgucRPOvk0woGje4VGWa5Oyg j/aw== X-Forwarded-Encrypted: i=1; AKwUvBybG6XMD+/M2xc2Cj0qI0pK1dzyfPxp9n8LP7KP7NE3Ps/jWJtJVVrfBoCwXo/NHNDpid1EvA==@openvz.org X-Received: by 2002:a05:6000:2288:b0:488:8ab9:f74c with SMTP id ffacd0b85a97d-48e6e2bbf04mr23920582f8f.3.1793635942642; Mon, 02 Nov 2026 08:12:22 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:91db:48d7:7451:652a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71b9b54dsm20387623f8f.47.2026.11.02.08.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 08:12:21 -0800 (PST) From: "Denis V. Lunev" To: Date: Mon, 2 Nov 2026 17:12:15 +0100 Message-ID: <20261102161219.3735623-1-den@openvz.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 0/2] blk-throttle: fix a host panic setting the first throttle limit on a disk under I/O X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org A compute node panicked in submit_bio_noacct() under a vhost-blk worker (ASUP-3910): BUG: kernel NULL pointer dereference, address: 000000000000019e RIP: 0010:submit_bio_noacct+0x12e/0x530 vhost_blk_req_submit+0xf7/0x1c0 [vhost_blk] vhost_blk_req_handle+0x3b4/0x400 [vhost_blk] vhost_blk_handle_guest_kick+0x1a0/0x2c6 [vhost_blk] blk_throtl_init() publishes q->td before blkcg_activate_policy() attaches throttle data to the blkgs. The throttle check in submit_bio_noacct() runs before bio_queue_enter(), so the queue freeze does not cover it, and a bio in that window gets a NULL throtl_grp. In the vmcore the bio is the first read of a dm-qcow2 device created a moment earlier, and its blkg holds the per-disk limit being applied. vhost-blk submits as soon as the guest kicks, which makes the window easy to hit on VM start. Patch 1 is the upstream fix. Patch 2 is its upstream follow-up and must go with it: with patch 1 alone blkg_destroy_all() clears the policy bit before blk_throtl_exit() runs, and q->td leaks on every removal of a throttled disk. Both apply cleanly. Build-tested only: the race needs a throttle limit set at the moment the first bio of a fresh disk is submitted. https://virtuozzo.atlassian.net/browse/VSTOR-152993 Han Guangjiang (1): ms/blk-throttle: fix access race during throttle policy activation Yu Kuai (1): ms/blk-throttle: fix throtl_data leak during disk release block/blk-cgroup.c | 6 ------ block/blk-cgroup.h | 6 ++++++ block/blk-throttle.c | 13 ++++++------- block/blk-throttle.h | 18 +++++++++++------- 4 files changed, 23 insertions(+), 20 deletions(-) -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel