From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B13D480F25 for ; Mon, 2 Nov 2026 23:44:36 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhMui029747; Tue, 3 Nov 2026 02:43:22 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhMui029747 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="alcl323F" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhAMe029708 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 02:43:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhAMe029708 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48e4d1e29f3so3173273f8f.3 for ; Mon, 02 Nov 2026 15:43:10 -0800 (PST) X-Gm-Message-State: APuU4Z/LpZUhAlqrIRoJds2Nki3UKX19k3sh/psEOM35o2hggd3zHOYw IjjHApN/gRzO9VD7it+4bHzWTMjc/BEvX0Gcj/YGh77cp5c3f6lpx/8ABEiOeFZC++IRL3aA4e6 Vy34prpPI6161kmVZvf9kjbUKb1mrm9MWhV3jPYp+DIFgDvXGcCeXiQ== X-Gm-Gg: AYBFou0oVPG/Dx2oFsjPPb/LB2Sbp2O5oXHDRCokUOlbex9+p3hdCe4Qoj0meztjJOL EnF4A0c1wcMqu7Td4fTcYUlwmW8ExhWD/gBGi8qtMir3XR2thYGMtBWcEHgtqClG8UxOhCbtwGT qtBxJbLngL0PeSvnG3LG6ILGDDhB/0+0S6yfmzXQUeI+wNR0xO6N/Erlb67aga4FT2uU9AVixxq CXRCVnmFVC0oaBU/VUBAKTUIK/4s/J+fSYTXvU6Uu2YxnGItz8U6QwPLSE5A+KoytuEhNRQpumk jEJYLmbqtWpnVDYYaG8WpBYnN1gRZBXCJXgJLiDy9QoHi4G3ARCxd+y7x5OCDhxiBO3Gfsdwe14 nYxWHU7hgpPBvnO1nM69Fx1vO/1qgxw== X-Received: by 2002:a05:6000:46c3:b0:48e:f47:273c with SMTP id ffacd0b85a97d-48e6e2bcd97mr17734589f8f.8.1793662990043; Mon, 02 Nov 2026 15:43:10 -0800 (PST) X-Received: by 2002:a05:6000:46c3:b0:48e:f47:273c with SMTP id ffacd0b85a97d-48e6e2bcd97mr17734571f8f.8.1793662989518; Mon, 02 Nov 2026 15:43:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793662989; cv=none; d=google.com; s=arc-20260327; b=F599aHo1NMVblA0MA9oGZGih77CecUoxXQAIw1UvRWDwzU2QGycAVfxMyeMOjA2far KvaqfqpaELvidBlxu8nehlguMzDngrbqHuow9k7DaZkgxAYc77H19+elBcNKhVb4Q1OO 20O6lOiGo67+tolaIkiXnkeVNn5ALeXaUdrxB5AaIt4vO2YrfWY7cmYTg9Yj1Sq79q4G 9O8k9ho9BatkD5DH3O7ryKlmcKdpb0jpsKTjKCLlbrFa/8C/TE/OJnPjvwoB1Z61F2CV YaSBcxQGwd6mZP6WyaHiKBv5C7VNTPWIH9HZU1SD9pTFye5MjdS6ApQUpZ4qpYgSPbDs 1RIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=bLsFawvNGbhy3iTiW2VuMX8ZDHJTeea7esTx6JLTXq8=; fh=9VH7xbtOhOOwoVYPb8YgTvr+erGWPni2iwCEEh8Zz6s=; b=iUsUf0VNna2pz4fckXYFUJGgZsb5GRJYdYMsN6WTdSh4IdrxUw6oyVq8NvusoAswQM 62DRWvG+QbGGk4wOqnL1cLJFccWwAkPDuOSrOorG+Ceg3jNk64N8kxHX6TuJMGUsD50d CYYNn3ACiqcLvWBj7am62mkD0pgkVS7o3h2oNn9V7DXpcjOh/j7Pfegf/FYliz4TPq8p ckycWe8c8oj6mxBzy9GYiuc8bh+rECTMn3YD/4mYg34t34RQBQAzWjcp66g2aUT3jq6N MDdX7g4E5EyHSMxAyJ1G7hlMTyK4Y1QrpafBH+DHLARNqm4UPewEMR0ccU7Rsi45QeGW sqCg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=alcl323F; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71a5539dsi21628897f8f.16.2026.11.02.15.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 15:43:09 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=alcl323F; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=bLsFawvNGbhy3iTiW2VuMX8ZDHJTeea7esTx6JLTXq8=; b=alcl323FTAdg Nmd+ZLlgV4uUp9nGhf+fuqIOzuipcGU7S+eXZiQnq9eqAgLeBJoI8i9ING2oh4IppJR2uSnRYBvU0 HHjbhzyPoQ55UrOjDMWcl2K3FXCABQZsFrpmYWwPh03tsEScQx7cREdO2vEzY/F5trrhs9hAPjSxD WIDxSyHHIgvnXEOoFRoY3LJt1KPZMvPg4i8CjtQEpYWX2w3IrcpEmeyzGkP8HVy5ltaNpxlPKrNK/ TXba/+idmW6jW1NZidTXz8wdgdix8LJ8GvN109UwT4dK5f4LO0vSpbYs1Es8VX/aW75teKHNcAGbN CgNZrdqsuosZHiMuW3NlXw==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO1cI-00BVZo-1Z; Tue, 03 Nov 2026 00:43:00 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 02:38:45 +0300 Message-ID: <20261102233849.613155-2-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> References: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 1/5] drivers/md/push_backup: correct initialization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Allocate pool and htable after lock, waitqueue and deadline timer init so we are sure that pb_destroy() can be called from anywhere. Otherwise we risk timer_delete_sync_try on zeroed timer struct (currently luckily fine). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- drivers/md/dm-push-backup.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 885ea7b31cf67..9a6252f2b21e2 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -658,24 +658,22 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb = kzalloc(sizeof(*pb), GFP_KERNEL); if (!pb) goto err; - - pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, - pbio_cache); - pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, - sizeof(struct hlist_head), - GFP_KERNEL); - if (!pb->pbio_pool || !pb->pending_htable) - goto err; - spin_lock_init(&pb->lock); init_rwsem(&pb->ctl_rwsem); bio_list_init(&pb->deferred_bios); INIT_LIST_HEAD(&pb->pending); timer_setup(&pb->deadline_timer, pb_timer_func, 0); - init_waitqueue_head(&pb->waitq); INIT_WORK(&pb->worker, do_pb_work); + pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, + pbio_cache); + pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, + sizeof(struct hlist_head), + GFP_KERNEL); + if (!pb->pbio_pool || !pb->pending_htable) + goto err; + ti->private = pb; pb->ti = ti; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel