From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 53F7F80F25 for ; Mon, 2 Nov 2026 23:44:39 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhP1o029754; Tue, 3 Nov 2026 02:43:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhP1o029754 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="TODe8Top" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2NhAim029710 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 02:43:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2NhAim029710 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48df730c035so2436843f8f.0 for ; Mon, 02 Nov 2026 15:43:10 -0800 (PST) X-Gm-Message-State: APuU4Z+CRMZKBQ9cDrOuYHL15g5YlbpPag3W5l1SxeBQdfI+udrhzDwI ikJV75ySCu4ciXsoEDqxTkyZozjxCXsm+IVn8roaYegTKxqxl/5OXvia3o8myJENsVs1xziYSHD 51RH2yymt2mS3Fs8UPOIXPtBxr/NljZwl8OR/5J3vBDuQlgshQqkawg== X-Gm-Gg: AYBFou0Ap2IfIQTNlHuKt83vybWhZ6JESanO3rNvO+9VU8mw/PCj9E19v3bFUnAlaSA vGuFLgt4LWD4LrzQgqTGRcGSnugR7FJy/r336UozvcusNwFcAVPAcZYveyshpqBxvzbkI4t20Z5 wzkNCk/L0UlTNNOLjCW7ypulWwt+eFoUMF+DodeDEohONTHIxzsivoSp1gJ7+01SWqmDAoOB1mE 7LYo9nW+tSaPcK7i8a615RmUdVmKAjK79Ob2yCQC+97If2qgcNZqixWr+/us9ErNe3i0ytEba7K lvdd+G0f2PLi39WriM7rIJoxO57azyH0x+SatCvPBuCg30Nisf9h5jYr4qe0IVSOoCVldelAED5 2zeb/h91wMBjLlnWTuIJqqEhFLYe33w== X-Received: by 2002:a05:6000:310f:b0:488:83f7:6352 with SMTP id ffacd0b85a97d-48e6e2c33admr22915631f8f.4.1793662990019; Mon, 02 Nov 2026 15:43:10 -0800 (PST) X-Received: by 2002:a05:6000:310f:b0:488:83f7:6352 with SMTP id ffacd0b85a97d-48e6e2c33admr22915615f8f.4.1793662989519; Mon, 02 Nov 2026 15:43:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793662989; cv=none; d=google.com; s=arc-20260327; b=GXIWrkcZwzBSSlhefJ+1a2BHbu0SEzvwTY1vVLh4K0TaT7ELiHw/JmZy0q/xHXvlOB 74zTdC4rsM01K1j8VekMudlGzd+ibDO9tQKa7/SsVgQpBlVxrUk7Jf4sI9zPkDbmABcs qpFM2yZwoC4JGi9J84uiyQ2C6G71wDpk+HA0QIJpjWUrjLyw/9s4kbSjZ7gtKVRoQrfE 89ybaHoWkxmdIh6vjgCa+gAuYTIVda0/hjMnFZyvG2v1CS3Hf8WcKG2+vUhIOBLFNOs6 b1i546d7Xe2HciMWSqgn8SB2EfVEAoPJvGgDbti4VR5odAzi3loHiZ4Qd2ABmEU/H13f weZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=cJd0z9hGZToAYJouAL+c0vtwA54mTnigx0fTTFZP6RM=; fh=9VH7xbtOhOOwoVYPb8YgTvr+erGWPni2iwCEEh8Zz6s=; b=Y3KC/G0Jjn/IhVxkbmcnac10EaZP2AWFQ8E46n/2gfpwP3jnxWhPKKBJQgLNvYWZMT fyCQ0znYYDi0koLxI1XWfq//nxmM+9CE2/gIo4pCToKMbAIIiGfozC8GWgLtLujTKuFf qnc9LH7cwp8xHmmFPAyD3SPaKfvzGGF/0M3bqassKnxqomvyrGZtjjKNUwx8Tng1JDuV L1XLaZbBhp/sPNa1KSu2RpRHerl5N+zPgqX32TqV2bpOUp2p318uVpp6VJ5NG6wFUTUs PWehEZVaUsrJpzopgg9HZepkZoSwN05DoZIp5EDgEY/bT0F/l2rOBDl2PKgNmo1Wwcfv uwFQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=TODe8Top; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bb0c43si20957328f8f.203.2026.11.02.15.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 15:43:09 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=TODe8Top; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=cJd0z9hGZToAYJouAL+c0vtwA54mTnigx0fTTFZP6RM=; b=TODe8ToplTe2 0qx6GDSd8vnK9dD4A570sVtNdCYFXxB6g6AnWagbeMI4CAb8F3NALT8WnXdAKZQwlYYN+T9ztoQJm 4OJET211OP9U3gO+eLzUGAvN4LoLhE76oQ+zP9m1rNOs00PrrKS/wLqHPWsQ7EdYz5KOIQbqEx89H 2KMDRufDXHsCH1gvbqLR21a5d6GHDTdGgwqOc9tHdIAPPk2mZV0qNb9MrqX4x3yWnG8Tw4jgLAW2d RnYw0k1hVQUPnscnhOzd7Jin4i6nHinRWEpEWWs9G3oW5A1IQv3QPopU6ipo8nPZ+8wSZL6hGQr/8 75StNFVkTufegGfmIWe9tA==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO1cI-00BVZo-26; Tue, 03 Nov 2026 00:43:00 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 02:38:48 +0300 Message-ID: <20261102233849.613155-5-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> References: <20261102233849.613155-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 4/5] drivers/md/push_backup: fix mod_timer() usage X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org mod_timer() takes an absolute jiffies value, but both callers pass a relative one. After about 5 min uptime this causes the timer to fire and re-arm on every tick. This has not exploded because we still have checked pb->deadline_jiffies each time. https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- drivers/md/dm-push-backup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 8ce84a1a696e5..b1861204f6e3e 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -244,7 +244,7 @@ static void pb_timer_func(struct timer_list *timer) spin_unlock_irqrestore(&pb->lock, flags); if (unlikely(time_before64(now, deadline))) - mod_timer(timer, deadline - now + 1); + mod_timer(timer, jiffies + (deadline - now) + 1); else queue_work(pb->wq, &pb->worker); } @@ -278,7 +278,7 @@ static int postpone_if_required_for_backup(struct push_backup *pb, spin_unlock_irqrestore(&pb->lock, flags); if (queue_timer) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); rcu_read_unlock(); if (queue_timer) -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel