From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 35D2F8017D for ; Tue, 3 Nov 2026 00:38:33 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A30bKnM030730; Tue, 3 Nov 2026 03:37:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A30bKnM030730 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="G/vwzkcM" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A30b7iY030679 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 03:37:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A30b7iY030679 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e1291432aso2777905f8f.2 for ; Mon, 02 Nov 2026 16:37:07 -0800 (PST) X-Gm-Message-State: APuU4Z/mESbDFGFt8Qa0VK8HOdjmQB8uLN3bdep/zdxg5ROcmy1yO1F0 vNfgclmQd4Yw6MiV4z+IMMDyCIU0N5Gam4ZYwqEAaL4WaVC9ki+6BmRMPE0r7Vu1js1EeDHMFAg aZFDU5ka0voXBi0OUGGKGjCSA8Dj5KOXqW6iRtr/j4pY4bwXEGhx2eQ== X-Gm-Gg: AYBFou0UI6vLnnAjAuP9Sd7YgBqEtsLpheMgHz6RAPsOxip43+DBbdE0/LVRfuZrnGQ IkMPbdsfK9GJs18g/i6/1ervA7EgiSikpg3+tktM6zPw87qRYFnQL0WBgSyw1PDqdderQzbbPfJ T3zZRDdVgXqMh7kxipK3JrJINx5tdfsE2t/FR3UsTnOW9F0IMsfm+M02BujawYVFDrAhS+BZL0C /7yX9R5b2tnKrm30eijXwlDx+jeLbXttRylPLtTnsK3kwmMR3B7UOQdvDaVHCClChOysuCUBgh4 UwvkZdP0JilVuBcJ5T55K4/64vttvGbwYMZ+Hq5qHPxS5gd1ezqyHvu7AjFgk0gugxUzzq+Dz1A QJZauRedWGhSoCPzrr+5fXsubx/MD X-Received: by 2002:a05:6000:186c:b0:48e:7a19:7aad with SMTP id ffacd0b85a97d-48e7a197e64mr19621006f8f.6.1793666227034; Mon, 02 Nov 2026 16:37:07 -0800 (PST) X-Received: by 2002:a05:6000:186c:b0:48e:7a19:7aad with SMTP id ffacd0b85a97d-48e7a197e64mr19620980f8f.6.1793666226551; Mon, 02 Nov 2026 16:37:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793666226; cv=none; d=google.com; s=arc-20260327; b=HlyXsBegUNUzvhpU14cjVw/xTQsFbQQ84VJroApg2wjWqZuxgL9KWo8/3HIEeahRaJ rtse1rHl7WL3qLjTm6jBlEMaU7F1+W5goSbW087oYOrwQalpgmo6HoiBVERuIpmUXpyv OZUQGpr6pBjaWfdpirv4TA14n2X1MuZFY29/st8bsH3QQbmjgGpA5SDpGjPTCP6IGruY EwdyAPlw+hDVbqNZ+DevcU4sc20FmEhUIWpvml+VeTQedjTjM09FeH1CHXpe8HHU28ao oN36nmrAAL4dne1NVFLEAfFdWeuvGkvSfJHOAJ3RWqXDuP2dbAGvSCTqyGzj9p9tgDfP IktQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=QR6pnAMFhowAvDJSMxaLjx3baDsD6JuxajlBwQus+Tg=; fh=9VH7xbtOhOOwoVYPb8YgTvr+erGWPni2iwCEEh8Zz6s=; b=fYehja6/UZ6sW6gHLwarGeQ7zLvVkvCy+Acmy5x+boJe/1UXvgOcU6mpyys4RneUp1 pXg6WljRFEIFpT3Bjx4hSv8vUhQ3Iy5IbZpcNlJ1muVErG0R/2pamyUvMGzCO7fegB8f 6rorrcaNi0jKBktG++NdefuJM0PoyfoXEEQJ9wAZQMn7HBqL24I8BpHGP5PbAHSaBCzJ 3WcOduvSypfLFtRrYFzJewwwu4Kqa74hwChKmBZkcKJyHBgJeq0ewg4GpfEUCvnrBMGS ULkjxd8m4HvycNslVLu32wuH2F2sDgKlXFOywC/RpHoEE/JfcvnaxKCRBxfsvpPDXFZI 8aiw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="G/vwzkcM"; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bda9dfsi20920280f8f.489.2026.11.02.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 16:37:06 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b="G/vwzkcM"; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=QR6pnAMFhowAvDJSMxaLjx3baDsD6JuxajlBwQus+Tg=; b=G/vwzkcMyKzj HOIKljyGWYV+cAKHny0R9XtvjWfJrG3Tg/jhKIfxafMyPe+fUHY5CF8BE3p3SCZDr4087zLZP0IVI EcXzd7geQduEmTRyoaGYpxPqn3Uo/GBrIbkDl6NwyKl0uLBpzvAFeHZtS3gH1b5MnFVnO8Cifuacj AGAg+RRvU67WSKXEapAZT9pKFtlxFoDjIqeJ0XRPckH1tzwxux2l3jj5W4ICRPpjRczlZP8uUBMZJ hdC0qz/NV46bSOt5mCUrX8O9vyNIr9ZliFjHJhD1+twTYT1Yyg0i5BKDeG4g+0fTy7UItpEjbvYt2 l80QRE3TMEhSNSBRnc13Zw==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO2SV-00D56q-1W; Tue, 03 Nov 2026 01:36:57 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 03:32:43 +0300 Message-ID: <20261103003246.712239-4-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103003246.712239-1-andrey.zhadchenko@virtuozzo.com> References: <20261103003246.712239-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 3/6] drivers/md/push_backup: do not re-arm deadline timer in push_backup_write() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org pb_timer_func() checks pb->deadline_jiffies every time it fires, so we actually don't need to re-arm the timer after setting the filed. This is also the only place that arms the timer outside the window push_backup_stop() waits for with synchronize_rcu(). Today it is harmless because write and stop are serialized by pb->ctl_rwsem, but it would re-arm the timer behind timer_delete_sync_try() once the write path is reachable without the rwsem (next patches). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- v2: no changes drivers/md/dm-push-backup.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 1ae4ccc208ffa..8ce84a1a696e5 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -467,8 +467,8 @@ static int push_backup_write(struct push_backup *pb, unsigned int clu, unsigned int nr) { u64 i, key, nr_clus = pb->nr_clus; - bool finished, has_more = false; LIST_HEAD(pbio_list); + bool finished; struct pb_bio *pbio; if (!pb) @@ -519,8 +519,7 @@ static int push_backup_write(struct push_backup *pb, } } - has_more = (pb->nr_delayed != 0); - if (has_more) + if (pb->nr_delayed) pb->deadline_jiffies = get_jiffies_64() + pb->timeout_in_jiffies; else pb->deadline_jiffies = S64_MAX; @@ -529,11 +528,8 @@ static int push_backup_write(struct push_backup *pb, if (finished) wake_up_interruptible(&pb->waitq); - if (!list_empty(&pbio_list)) { + if (!list_empty(&pbio_list)) resubmit_pbios(pb, &pbio_list); - if (has_more) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); - } return 0; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel