From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B51498017D for ; Tue, 3 Nov 2026 00:38:28 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A30bHxJ030723; Tue, 3 Nov 2026 03:37:18 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A30bHxJ030723 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="MWPih5RL" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A30b7Le030678 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 03:37:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A30b7Le030678 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48dff112136so2335023f8f.1 for ; Mon, 02 Nov 2026 16:37:07 -0800 (PST) X-Gm-Message-State: APuU4Z8/XLi6vqSBeJQZfGHPnMKWxgT9WOS6EEHtbkcJP+25jspheZLT YEwAuxIhVeWGItsdYsYRCdkfWcF2KkNgXmxFQRtZfn9izD6OSmxjIyvQ2HzRWPDg6WDXLc1KG3g rFR/X4gd0R+M9jOOZpxFgxdxNvgmDgfoaCcvYy3o1qJKWeBtaoKA9LQ== X-Gm-Gg: AYBFou3z/rueVKrCl5RUrqDbXpSCdj+mLvzEWkvEZ6k6Cox6+9koCXR0owaI/61Iv0s imOznAZXZ5MQ02ri59oMo5Z+qcJ77bqmeJNgEnelG4cvtk9T/zwCqBH9fqw7ELf6PYuU1r4h4aW LU49wFmFUhZa7lMD7Nt6IcnFvUI2fa8MxYWUiENStnAbmicYDFyPSVh5JMN+LKHbR+xa1GDPmtE Uh1ig1upOVoCJnRTdcJJ/q8Yj7pPNFFTp+zPiH6T6IOccgfssJP3hHdkZaOSkMEaVqiIFmbM/Uw CwqkP7ZGN/oRydFxhvlLoNxqde0a0u00Jv+GcdAMG9RmMoK949gLOacarPCE4zVpS+VZGyfAUpi 1ua7iA5P6IGpDhWmteu8o4zBOd6v5 X-Received: by 2002:a05:6000:2002:b0:48e:5eac:7e48 with SMTP id ffacd0b85a97d-48e6e2f692emr24288006f8f.22.1793666227067; Mon, 02 Nov 2026 16:37:07 -0800 (PST) X-Received: by 2002:a05:6000:2002:b0:48e:5eac:7e48 with SMTP id ffacd0b85a97d-48e6e2f692emr24287996f8f.22.1793666226550; Mon, 02 Nov 2026 16:37:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793666226; cv=none; d=google.com; s=arc-20260327; b=FVVkdZCmrx9/j5i0ovMXfuooVBECw/+/WXqs4CcOcT+l+QXyenBjN6ltibMPgzbs+m to5VjT3qiy1bqNHtJ5LiWroUkdnihxxQFlQITGcBKMS5lbbghuTo3S6+Xlb1WSyQWms/ a+r4dXfXRB3hMfE5gIrW/BEANTr1kmm/3uvuhRFeSfiveJMtHVkKZN9g5sHlou6mJ8wd gr/bcgmXL86iYDu7JZrB6QrqL1AmMCXnLkg64eq09ojvrt1iv5z3rYSMfIX6bnSdEgn+ 7MsrBvCK+cZveAw5+8O9Dwb4BN2XYm0F8Fp8fuvm5UgaF7yLnj1MPH9Uw3vo3r3xSDB9 KvsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kS7z0p8AwIdo+m8/sSi/FdfuCiC+UlsYDkIkbonqnJ4=; fh=9VH7xbtOhOOwoVYPb8YgTvr+erGWPni2iwCEEh8Zz6s=; b=RkV1Mj6Sh7A+VbSA8Fn+PxdyflBcA4Qd7Aym4J6aGp2OlV6IKsyvQ8fExEYiTjMnGz kL/7TmN6AMHWVN0dib51bMY9nEwav5O6pBfVbAWg5ldHZzh1XipoJyWHlYi83eZcFpfC j+HXeGeaCzTj2B14tNvula+nFZw6V+mJveDq70cMglpPyfKvwa/wbE/esMRBx7RBnXr8 r8tdGP/nhbp74wkqG2FnZmfjl/6KHglaZ3AdGkpUD4aJRrFfiiOxThlNju9qMXFaCfEa iYDjV54dkQ57QWlg6fVDz/M+Uwf4QgjgPbjO+uM4IZXE/P44WwXAI9LhWw/GnbUWk7MM QjYQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MWPih5RL; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bc32fasi21765492f8f.327.2026.11.02.16.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 16:37:06 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MWPih5RL; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=kS7z0p8AwIdo+m8/sSi/FdfuCiC+UlsYDkIkbonqnJ4=; b=MWPih5RLkM+x h/w0Q/YsZFXt3ujYpItMsz/gVrWZmq+u03QAtDw2iwTGi5zs9FKNfVTmgyMGnvJAbb8Jkynb+9XR6 6ViCkYxx26zjZIV+v+UaKdWLLcUVV/YjV24MMvr5AVeBqmx4Hj2Dr84AHuCNwLgeonfRmkCMu0nyo RCauhmrg7ugLNBQ9+0Na+GD0DosswVOpZsqdaZKAKvyX/TuLfLVxw+lFpa0DAXKQ6bJFBFb6YuFuY 52siACyWuEM4yeIWihpur45peSxcEbE3bVTuvDZVOwscw8yFQpXZtRcsIAwnJlQfDcleWXRLTRt+5 +qDSR0DNe/snY/euIZ2GZA==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO2SV-00D56q-1h; Tue, 03 Nov 2026 01:36:57 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 03:32:44 +0300 Message-ID: <20261103003246.712239-5-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103003246.712239-1-andrey.zhadchenko@virtuozzo.com> References: <20261103003246.712239-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 4/6] drivers/md/push_backup: fix mod_timer() usage X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org mod_timer() takes an absolute jiffies value, but both callers pass a relative one. After about 5 min uptime this causes the timer to fire and re-arm on every tick. This has not exploded because we still have checked pb->deadline_jiffies each time. https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- v2: no changes drivers/md/dm-push-backup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 8ce84a1a696e5..b1861204f6e3e 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -244,7 +244,7 @@ static void pb_timer_func(struct timer_list *timer) spin_unlock_irqrestore(&pb->lock, flags); if (unlikely(time_before64(now, deadline))) - mod_timer(timer, deadline - now + 1); + mod_timer(timer, jiffies + (deadline - now) + 1); else queue_work(pb->wq, &pb->worker); } @@ -278,7 +278,7 @@ static int postpone_if_required_for_backup(struct push_backup *pb, spin_unlock_irqrestore(&pb->lock, flags); if (queue_timer) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); rcu_read_unlock(); if (queue_timer) -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel