From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 374998017D for ; Tue, 3 Nov 2026 06:23:31 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36MDf4001105; Tue, 3 Nov 2026 09:22:14 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36MDf4001105 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="DhtYH8I5" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36MChT001077 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 09:22:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36MChT001077 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a2063be141so33805865e9.1 for ; Mon, 02 Nov 2026 22:22:12 -0800 (PST) X-Gm-Message-State: APuU4Z9u+exjMr11ENvCKGXLB+SwKL7gIsERPvpWycDQf4aL6Qdsb2iV B9785AwFLuJ1HIE6PH8bRaji5PCgSBO0ZmZY0McrZopw8lhxIyfmBE5JaIoaPlOObAXpEbrSLwZ lOxOMcPOSkC9Yi5EOvKltDMuJULIqgIb1Dsa39o3+0R5aTA4N70vuQA== X-Gm-Gg: AYBFou1deQzRBqFlnPFuc71elJAK9ZS6qrfCtABaiARkZaq425fGh1+Hm4JMtYcxpqr NzitP3GuI3hgzxLRvPuQg9Fntnv9GdwnssTWLMyksucogJqg3sb/1C/wrtuCN7yltkfuEtRu4GS qdBKe3XF03F7OE5e6UjkdYCwEdQPKW7BBahvYhjIXuElvhaZYqNkojuL/uWuMSZ+VyiSV/QH0H4 Tp+kC2IYiSdT6i/K1mORcXsHmAa7oYoifQdIwawV77psE3GM6B32fLxKUe3htJVIixEr3TOyNcN 3XamQXfFVCbUoxTyXRKRJg0j2gqwTfoWLyM+FhZaF6SryUqoFcWtKjJogeFIjZeRKY8XcESd+f9 ohugM5rpUg+7fLcC5mqTO6/0o2rO35w== X-Received: by 2002:a05:600c:4f55:b0:4a3:d327:6ed with SMTP id 5b1f17b1804b1-4ac182dcba3mr300909535e9.17.1793686932063; Mon, 02 Nov 2026 22:22:12 -0800 (PST) X-Received: by 2002:a05:600c:4f55:b0:4a3:d327:6ed with SMTP id 5b1f17b1804b1-4ac182dcba3mr300909185e9.17.1793686931597; Mon, 02 Nov 2026 22:22:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793686931; cv=none; d=google.com; s=arc-20260327; b=UcG6oayAeo/Zb0CpyxUZR6Ym5bDk+0UY7tHn//rnGP+GhdAEeWKzGAfDFB5uGKvZ7N SKMzYSUlZlOBPxxqXPRECpwWMQGIKqXlReQUzs9H8jylxoNr1gQlwxAAyEjyqEwpWkgc tBSnfGOmYebdPd/V8/l8P2fN8ibsgfjSoBYxIAuGctkCdAkSh/riqMmsIvkT2o977NGt Ju08K4n5FZncruBKxMDGnI3uZNvDnZ4v24BRpJYyNX8KMJwMgRhrZ08zwVAv/keh5lxu NiyylaHN1OfW1aKu/n43+MO+cOUJfYnJwEKJRECTDFRU+bonhbfinyd1XOHYrdqEOriy 4E0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=+H8uwaTfV3gAhuRWMXMeS7GAXZhVW6iTh16W8NKPiKY=; fh=1tuYsFJiQCT5Wkm/n4xHdwYbo1LrtdB1ozKduz9MEDE=; b=QqlZoZ3GSBTrjv5iEC6GFt13hhscmZ3nUeCMmzdN1yebY+yhqKMIPR9guxraXqyG3C LBSvuorKEmbscahkkiLcax9Nrvaw97lQNLkU2SITTqhqpIkSpnVcBrsjibelS8O/xExB pHy5L5UTfLk6jUPN3mMd4j+Pa4m5kntkDqv6ybHOVDf18j1AMZr8Ptq8k2RyF9e/69CE K7HDrqJHLXaFTG/rofEoAnnWcaP4l925s42m/t0ZQ0lZEyMoPiL2SoM9aHIQeoFtdUZ5 Xo3wpQf1iJWihF2hHTM+d8aLGZt1oKkHjKyQzOegxfqMSVss6F9ktrw15jFpC3WYtrnw eK1w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=DhtYH8I5; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bbf22fsi21337712f8f.277.2026.11.02.22.22.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 22:22:11 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=DhtYH8I5; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=+H8uwaTfV3gAhuRWMXMeS7GAXZhVW6iTh16W8NKPiKY=; b=DhtYH8I5NtYE FDI6VHlKOmZLv2/xF0tPe6gHyp6BqllC4WSA8Oe0a6V0GyXbXBGoJlDNG3NJKGBNAK6tPbaRGaCt2 e7JQ1wphzZr+ulEhjMu9e5gp7G1UiVrlac9uJqErlLBRG/sihl/QUKLWEd6Ac17YNSEiRt8XmwCWQ DX7c3qEUx81LLyP2xyPDM1cGXHBNJKkvK9Ye+Oe72YFPvnwvpAGZ8SGAYluiWX73hxdKqGFBQaNQG EOL1nRYPflFVlUWxKfvzoKW3VZVnRuRgR8EDr51c+MIUQXgPFwgO665iH7Fj/6GEi6HzzVmufoM2L WKYS2eiPsipxlwGCsa6jAQ==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO7qS-005EVh-1O; Tue, 03 Nov 2026 07:22:01 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 09:17:47 +0300 Message-ID: <20261103061752.720813-2-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103061752.720813-1-andrey.zhadchenko@virtuozzo.com> References: <20261103061752.720813-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 1/6] drivers/md/push_backup: correct initialization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Allocate pool and htable after lock, waitqueue and deadline timer init so we are sure that pb_destroy() can be called from anywhere. Otherwise we risk timer_delete_sync_try on zeroed timer struct (currently luckily fine). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- v2: no changes v3: no changes drivers/md/dm-push-backup.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 885ea7b31cf67..9a6252f2b21e2 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -658,24 +658,22 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb = kzalloc(sizeof(*pb), GFP_KERNEL); if (!pb) goto err; - - pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, - pbio_cache); - pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, - sizeof(struct hlist_head), - GFP_KERNEL); - if (!pb->pbio_pool || !pb->pending_htable) - goto err; - spin_lock_init(&pb->lock); init_rwsem(&pb->ctl_rwsem); bio_list_init(&pb->deferred_bios); INIT_LIST_HEAD(&pb->pending); timer_setup(&pb->deadline_timer, pb_timer_func, 0); - init_waitqueue_head(&pb->waitq); INIT_WORK(&pb->worker, do_pb_work); + pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, + pbio_cache); + pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, + sizeof(struct hlist_head), + GFP_KERNEL); + if (!pb->pbio_pool || !pb->pending_htable) + goto err; + ti->private = pb; pb->ti = ti; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel