From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 816E08017D for ; Tue, 3 Nov 2026 06:23:34 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36MNJL001121; Tue, 3 Nov 2026 09:22:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36MNJL001121 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="W7YkbvNZ" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36MCA6001079 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 09:22:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36MCA6001079 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4ad3d35e899so20506905e9.1 for ; Mon, 02 Nov 2026 22:22:12 -0800 (PST) X-Gm-Message-State: APuU4Z9hX6wyEtHBunp4xYz5SZgBvdCSSfOMB8XHOECHoZUvg9TSxCyY 5qTLNAAOsaRB1/o7bfgHzqSY8psM/P+iD2AijrKwl6jzcwWANaZnO8W6ITbDRmZARBx0L93kr/W EwkAiOD1KsNrC08fYvqA6aw1znrwjvB9pchLSau4+DcFGhjWFIXzu/A== X-Gm-Gg: AYBFou0qITQQuwOWX0V3r4OfbnfXK17tLOwpXbzHS0ume2gqZRZ5ymZQdgTspb0D2T4 TkqisP5ostwRLFQw8r3eixvHHW39EQK/iSCml0VeSo6J2YeBhH6znqO0ppBu5pBfG91CydcJYo2 lFj8Do88wceyNYffGPg6eXeYwa+sYob1535VeuGzg2Fg+g/HH90Qzy0ENnJ/f1o57Sa/7IUFpzz h7iHM3pe+XdflHiM9RZtx/aSqU69xRe59I/kealYHEm8nmEcN9RwLGJyr7d1P7fumn9wQnJV8g0 UdDLtbF5g+F78oR7f5JTSxpPCbB9ZZhTIJh6upoVTaMjrDtuTdu/ko59bzWdKW0xYDOQ1t/wPSP 3iOaDigOeGZ6lO90xl1kwaAttpBgpCA== X-Received: by 2002:a05:600c:6387:b0:4a2:150f:1605 with SMTP id 5b1f17b1804b1-4ac1904a81amr278464205e9.24.1793686932066; Mon, 02 Nov 2026 22:22:12 -0800 (PST) X-Received: by 2002:a05:600c:6387:b0:4a2:150f:1605 with SMTP id 5b1f17b1804b1-4ac1904a81amr278463925e9.24.1793686931593; Mon, 02 Nov 2026 22:22:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793686931; cv=none; d=google.com; s=arc-20260327; b=GT2p4LZiGou/1P5XRBAySJgnxM+cp4lhWNq9Q0cIb5G2hFhRbjLRRGsCk+HY8GlWev ep4G6tBMOcv5SPHsF/2B32uWMkv3Ip9pMRYUggcujI+gBr57DR5g5ke/cVXVIIgcWfWy wsq91ekCWImrPgFnoZUxcel6Qrb7hKfbMU7ZeHq/EgklJIx2yyXQ/vix4WKLHYc3E5Bj Z/vj3NSvPetlhkr629A2T5Um+XkXP9yKb6ZcrkzVl19nmoJ24YL7tJ+LL2bqrvK8GPjz 7YVSBT7VQx6TNSe8hHCjNyUoTp+vEexb0coQ8KQOlo3aCzALSRMJ84TOPwgnPiGQuC+i eIVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AXdTAmovH0+E/sfhH7+ojRWB6Xmf0mKFGlVPPa6DVqc=; fh=1tuYsFJiQCT5Wkm/n4xHdwYbo1LrtdB1ozKduz9MEDE=; b=nyOXf+/ZKLT7UZDRByTcjjnJGuai6+BTkGePPu5Z9MQbFYgxxjA3OIBz6YSYPkLgHM XeFTm3IeOGVBpushc0OTr5LCCQlJ0Vp1IosSHcYBZeBBRqCheOQcgD9Db0ma58dpVA13 NCKLgren4SLqmjEiMgWteurNKx6kgOry3qh3f1ZT4ZlbjWUf0+f+T4j+CZEghIRdcT33 G9s3YF2kWUcqtFjNiaLmzfy0iXY4j4m5j4BMkHhYzL19voSCuhsfgrVQVgYZ7CDwj4V0 sn6/fsyZkhQIgcQlwxRlqdotmqmStYuSBoYy63nG7bOQBSoJdViEGvyGCHjA90tqL3d3 APPA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=W7YkbvNZ; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71ba485bsi23548644f8f.119.2026.11.02.22.22.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 22:22:11 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=W7YkbvNZ; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=AXdTAmovH0+E/sfhH7+ojRWB6Xmf0mKFGlVPPa6DVqc=; b=W7YkbvNZMNqZ rf9ucfkiCWkQeWM+yc/TgMMfys2nUti+aSv/Keh38ZPEuP6HHiga/YrusrUPTZ6KhdtMKKKkaFw2e eE1TtRP6qvHw/PIZEz3pLZhf1s6q/1nZm+6krZ3iNhnabq94znLVCJqWXlDyXGdq+S1LUt1xnfUb6 /ZHran3pBqiR915MJF7s7ReW+3LmpFpaenN/vNdCw8AwYFVBrQmTZhSeNJJmW2Cc89pkFOKTLayEZ 5bgtVz3zuDB+WzGaoa04l9YxTL3tUHUZq/0/vdBQzSBdnFLE3gv+WF35TGrqORIGJpJSQ+jrX+00k 1yR3O5APmiCbLSa9BKDweQ==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO7qS-005EVh-1b; Tue, 03 Nov 2026 07:22:02 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 09:17:49 +0300 Message-ID: <20261103061752.720813-4-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103061752.720813-1-andrey.zhadchenko@virtuozzo.com> References: <20261103061752.720813-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 3/6] drivers/md/push_backup: do not re-arm deadline timer in push_backup_write() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org pb_timer_func() checks pb->deadline_jiffies every time it fires, so we actually don't need to re-arm the timer after setting the filed. This is also the only place that arms the timer outside the window push_backup_stop() waits for with synchronize_rcu(). Today it is harmless because write and stop are serialized by pb->ctl_rwsem, but it would re-arm the timer behind timer_delete_sync_try() once the write path is reachable without the rwsem (next patches). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- v2: no changes v3: no changes drivers/md/dm-push-backup.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 1ae4ccc208ffa..8ce84a1a696e5 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -467,8 +467,8 @@ static int push_backup_write(struct push_backup *pb, unsigned int clu, unsigned int nr) { u64 i, key, nr_clus = pb->nr_clus; - bool finished, has_more = false; LIST_HEAD(pbio_list); + bool finished; struct pb_bio *pbio; if (!pb) @@ -519,8 +519,7 @@ static int push_backup_write(struct push_backup *pb, } } - has_more = (pb->nr_delayed != 0); - if (has_more) + if (pb->nr_delayed) pb->deadline_jiffies = get_jiffies_64() + pb->timeout_in_jiffies; else pb->deadline_jiffies = S64_MAX; @@ -529,11 +528,8 @@ static int push_backup_write(struct push_backup *pb, if (finished) wake_up_interruptible(&pb->waitq); - if (!list_empty(&pbio_list)) { + if (!list_empty(&pbio_list)) resubmit_pbios(pb, &pbio_list); - if (has_more) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); - } return 0; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel