From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 192B88017D for ; Tue, 3 Nov 2026 06:23:40 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36MROH001129; Tue, 3 Nov 2026 09:22:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36MROH001129 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="C+TJycU+" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36MCC5001085 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 09:22:12 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36MCC5001085 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48e1291432aso2905074f8f.2 for ; Mon, 02 Nov 2026 22:22:12 -0800 (PST) X-Gm-Message-State: APuU4Z/Sw+DakOwpXOIjZKm77nzkrgdNY0hcOU0CTa8uTSu2P2nGj0+L 0exrNBvgwwDzs0dxBCECkNJUPFprjULV99F3AbSF7oMI/og26JyElndmOuAIc3kl1rjnAOnJq3c uB9NS01Zx4Otg0mUKR+Lpp+FoKGL2LaN0GulPlBoQxB4xaQGdYEHqpA== X-Gm-Gg: AYBFou0jrainv6HDAA0Ir0kicVFcoF+oHIrmMTfXky5nc3mGa0bvGGKIc3gBSdjJSkQ rckuPUnZQhvaYuJJiD9PnszYV2+JvDtkjryj4oM1qdtKsefK8Bp4SqYIkprwHXELkOXZGZK/3WA aSQ3Rr6lxirk3AmJONdS7vOXRnh41pP6poNaheCUylSEbXbfJGoxUIkrryPJPx7w6IRQuxP8f+1 iuaxJTnda1vcVDzjthJbh4Sh9Qbb0lAESlUBvVpG/TxpRFMQaODoPq90KlUphqExGOtmsVch8+p zQ9WHsFX1VtKhKxC3JIJARZ+7CJSz6Z+Vog+BUlRZ8/bZcPrpHQRXrOS4otMnpnqIkVCjvzWXLf JUNx8xGszgAWbS3SkDHWCxaGwUhwW X-Received: by 2002:a05:6000:468f:b0:48e:5444:a1d3 with SMTP id ffacd0b85a97d-48e6e2fa548mr16563677f8f.11.1793686932114; Mon, 02 Nov 2026 22:22:12 -0800 (PST) X-Received: by 2002:a05:6000:468f:b0:48e:5444:a1d3 with SMTP id ffacd0b85a97d-48e6e2fa548mr16563662f8f.11.1793686931636; Mon, 02 Nov 2026 22:22:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793686931; cv=none; d=google.com; s=arc-20260327; b=p9lG9PwUmQj/QC1GLF0EZDzOMnD2ahEva3KgV+tk0MfXm1LDrDWhJ0eng3fW7QIjlg jij7WF1wS2QV6ofJFNPgHn+haUZr2vlzuKmu70cK9bnNjh4FZ0rYx+UTe/n5kFL9xqhH nVlrMhuDEPBZbKLOKnebD7bl88CKj3ILBx0yI0a81lja4Sd6BA4JmiXL9ZuKikz4ibCc ZmfL8HO6KEsztq7JEzYreoJbHfWdFOy4NdYG4XeL7wj3+usdvPAbiM3sPg5/TziHBPxv h8ubpF2PdaaRAKuWlLkU8H5jBUqdHLGMVFxHUQmMJRE+SalmPrPSo62NPBHWT/bm6p0q Zg6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=KPOZi1Q4sHLDbUVgwaV6ro3CF063F3VlTGESeADWBpY=; fh=1tuYsFJiQCT5Wkm/n4xHdwYbo1LrtdB1ozKduz9MEDE=; b=pn1qmGw2EDRNi4ayH1pCNsKx1qoSnbDfXV5Lu6glZE1asaW3q9Y7upftC3xHyK0s/S doHHl1UWcsUGSjdocLSXA4BS4u+K8illPF782osamCddXzf9ZHjJFohugF+v3lVRUYWz vw2YiaKdXGRqOpCVN7CFP2nV8HfJIwzem+KfRKWw7A+CkABqB5nc4NLH8TMY+bdA5DtU mX2xEX0f1s3Qxx3VRnRbVHpqZyQ5XpQHB3TQ4d6STvjzq2KUR6mAcpiKfxTdbfL9tHuD 6vG+CEGg9QH54fOm433FRzcT49+xYiPiYlwdenUD4251PzH/LJmoYAeZZ4jHGsyrCveY EGLA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=C+TJycU+; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bc9e50si22047395f8f.369.2026.11.02.22.22.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 22:22:11 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=C+TJycU+; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=KPOZi1Q4sHLDbUVgwaV6ro3CF063F3VlTGESeADWBpY=; b=C+TJycU+uxd0 V1S52yorylr7sMXjOTpobks8AGjdQ4NOGYFSlaARO/4dM/0s8KVdny9V0TOPHgFtTL9XhIYBsoax6 D8lfMKPepvqrMIAzasfyF48Zv4slvh4HzoEzLII1H0WOwHYSZjsXA1X1rpG/iwlCT6IfwSaadIaoH 5ZNPAAEvTrN4yGwFEzTVDBLQs7M6fauuYNiLTYrsBY9LzvFEo0wQzkftY+Rp0PZB9SwG8osjLNh9S DqCUiMXAsrTK5UMNrPjb4WpjBP57gU63Bjof1BobibXq+MiSz06iHShfVzy1InsP2vsdBXOf4KBTB Cxor8uptSkkPO2kxAUj0ag==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO7qS-005EVh-1m; Tue, 03 Nov 2026 07:22:02 +0100 From: Andrey Zhadchenko To: alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 09:17:50 +0300 Message-ID: <20261103061752.720813-5-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103061752.720813-1-andrey.zhadchenko@virtuozzo.com> References: <20261103061752.720813-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 4/6] drivers/md/push_backup: fix mod_timer() usage X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org mod_timer() takes an absolute jiffies value, but both callers pass a relative one. After about 5 min uptime this causes the timer to fire and re-arm on every tick. This has not exploded because we still have checked pb->deadline_jiffies each time. https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko --- v2: no changes v3: no changes drivers/md/dm-push-backup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 8ce84a1a696e5..b1861204f6e3e 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -244,7 +244,7 @@ static void pb_timer_func(struct timer_list *timer) spin_unlock_irqrestore(&pb->lock, flags); if (unlikely(time_before64(now, deadline))) - mod_timer(timer, deadline - now + 1); + mod_timer(timer, jiffies + (deadline - now) + 1); else queue_work(pb->wq, &pb->worker); } @@ -278,7 +278,7 @@ static int postpone_if_required_for_backup(struct push_backup *pb, spin_unlock_irqrestore(&pb->lock, flags); if (queue_timer) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); rcu_read_unlock(); if (queue_timer) -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel