From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DBDE980E7E for ; Tue, 3 Nov 2026 08:09:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A388aZ5002197; Tue, 3 Nov 2026 11:08:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A388aZ5002197 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ktlz2vXn" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A388Jc9002151 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 11:08:19 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A388Jc9002151 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a20fd059ddso26732595e9.0 for ; Tue, 03 Nov 2026 00:08:19 -0800 (PST) X-Gm-Message-State: APuU4Z8wTA53yIVs1MfkEhG6phFnYMFNIZW1TrbRgCWxdmUqXa6qhbsa ioIKU0jHPxAeGNQpwIk70QGL4+U0EwlGay+0HPCn6jJG+Mf9FZCUWWEOOsiSig7OrczZQitTbPc bFG/ikyZFo9mHjsp0LoCNYQIAq1V3RtCFDmIwv08dGTDzCSU5yRdj0g== X-Gm-Gg: AYBFou2j6sWNEgoq9ruQe69uVHWfrqA9CXvE5lgrVEdgBEl09zSkrJnXkfP17iIC1vz fUe/5t1H1aNHh/j/AveZaM+Z5E5WF2qCm4EcD09CU7vApJq9xbiN/u+Fs0JuLbWfmr8e44ZFVAa wBu4jU3A6zwEiHT/2sp5q5cJ/VqPbDiNUJv0AHxRPZwY5na8E5tm9JIcuUdvLfi5QFCA4y+XvAR KnWqXCyXHbzaDelv/x3biG2F5UYNtftHq9om/014QZaYlFg3Ruvs7+1QYlbix5XCKj6pTPhVf4k 0t71OulGqbZvu2Rlo8ZPYs2PLqOAdamvJkPm1zHYapliCB68CiT0o1fJu5zeVZ1C4qdrZgiJ3t/ V3Z/lPfN9jcHeyfmC+9pKE1mWEkFx X-Received: by 2002:a05:600c:800c:b0:4a2:d99:3171 with SMTP id 5b1f17b1804b1-4ac17753c13mr291375495e9.23.1793693298922; Tue, 03 Nov 2026 00:08:18 -0800 (PST) X-Received: by 2002:a05:600c:800c:b0:4a2:d99:3171 with SMTP id 5b1f17b1804b1-4ac17753c13mr291374745e9.23.1793693298314; Tue, 03 Nov 2026 00:08:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793693298; cv=none; d=google.com; s=arc-20260327; b=oL6nYxEZ7NaKGOp508HLfxuANIF/+y4n/Xi9oVaJZIp3I/hpYMIZrjc34c+3drvXH5 XAUS4z8jqrv44cPk2zljexroBUk/edRSQZVNa1rAPCR3WrrCXEJ66IjXWRBVKFZBcTQU yBvr4I3ApXTEsrpeAdCBAVF0LlL6PuhC8hdhS+rK4Oq3Um3DOc61ZL5bgdeQOfUA+OsY xS7+VesXlS2jdKxo6nC3feih/VtG06XQ8xn/IzWkPilZh00b4L0El+fdj67bw0YvhwO7 58e2Sr44rQ1vvh6dzYdDPyh/y4Ub3WCyh8eLegY2tLHvOzVlYlTuGvXzrDEaBxTV2gbu KABQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SlJ62xZdxFUdZM/pYTZyj0uKo4Q1K1MsksBuZkTSBUU=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=qI6UMJdWNlrEKuPHoGyCeHr/lRyhRiLf7mP0CydOTyTwCkY3AL4+OtZxwtEZRGWjJM 22OsNvza4znGKoT22arURCoaSJTyUmThwutTjv/Ty2SAWYG7fK8Hg7KX98Zwio00OJwk 7sN41LgJCcxL9jiu272dHNqg2aOPPwFW+5lMN1Yf8OOSIlP2HVpdwhJ2YQzdX+yII9bj pv/HtTalNL4T7e1Phvp+GnO5lbNH5et6Ex71N2UYICVVlwDhkLo7YBAWQPP07wRq7Y8r BLxKVcWGdLPBak1cbni5GgXjdeFF9PJR/Lnd0xscV4UGpWLhGS6GdAfiiTcRYQeRqqpD CSbg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ktlz2vXn; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bd1a37si21781382f8f.420.2026.11.03.00.08.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 00:08:18 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ktlz2vXn; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=SlJ62xZdxFUdZM/pYTZyj0uKo4Q1K1MsksBuZkTSBUU=; b=ktlz2vXnLmOF M8m8RPrDz1JvWjIyUYwwMVpxtMC9QTi2BSEpx2/Ab6fMjeT35WbwJnEGmMtlbMUD4pRqfmVKxw7RE AMiBa06wXJuBGwbX9TRhw/OJ+avJDYeTcgq1/jOSNX1kn+zYIipns87sbzTwFkkh42UpdEXSSQM3+ /VXmGzHewup32XVbD9VfyLj1o6r1n78e/i2z4o3Iz77t4/ImhD/HuIxykFMdnEGXwtrhN3gpyEncc YuXR0Pz7LjwZrRMV/+zkIYSXWw/8wbcWBh8hOPPXMqxi1ea9MliV9rOZLUycG27dQybbeFbrHKF6y fGm2ZmCBeN1MvoldFfHc1w==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO9V8-0086OY-3A; Tue, 03 Nov 2026 09:08:08 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 11:03:53 +0300 Message-ID: <20261103080358.723186-2-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> References: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v4 1/6] drivers/md/push_backup: correct initialization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Allocate pool and htable after lock, waitqueue and deadline timer init so we are sure that pb_destroy() can be called from anywhere. Otherwise we risk timer_delete_sync_try on zeroed timer struct (currently luckily fine). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: no changes drivers/md/dm-push-backup.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 885ea7b31cf67..9a6252f2b21e2 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -658,24 +658,22 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb = kzalloc(sizeof(*pb), GFP_KERNEL); if (!pb) goto err; - - pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, - pbio_cache); - pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, - sizeof(struct hlist_head), - GFP_KERNEL); - if (!pb->pbio_pool || !pb->pending_htable) - goto err; - spin_lock_init(&pb->lock); init_rwsem(&pb->ctl_rwsem); bio_list_init(&pb->deferred_bios); INIT_LIST_HEAD(&pb->pending); timer_setup(&pb->deadline_timer, pb_timer_func, 0); - init_waitqueue_head(&pb->waitq); INIT_WORK(&pb->worker, do_pb_work); + pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, + pbio_cache); + pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, + sizeof(struct hlist_head), + GFP_KERNEL); + if (!pb->pbio_pool || !pb->pending_htable) + goto err; + ti->private = pb; pb->ti = ti; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel