From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6E8BD8045D for ; Tue, 3 Nov 2026 08:09:58 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A388jUb002211; Tue, 3 Nov 2026 11:08:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A388jUb002211 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="jH6w42mH" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A388JxF002153 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 11:08:19 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A388JxF002153 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a35db2d6b3so27507485e9.3 for ; Tue, 03 Nov 2026 00:08:19 -0800 (PST) X-Gm-Message-State: APuU4Z9Zs83RUbOPwLolPWwAI3la37SS4BJ2J1yZFWEh6Cft8ePTFHIt zxVbNYD07znOlB7WrHoXHZCLbSiijq8GpYIA+KYrGsLkYffC2unVD3tzXq3THZzgnqwQiiMRR6t bdwNGl0QPVms9qfCg7eC0ADgbLX/Vy0UynZiPmtmKhUelx0E4j1faZA== X-Gm-Gg: AYBFou2on+3a8+B3cihnnLQUQGSgXbX89ISPNLPn/V0UI3Z6ny8PVW2ykCwF/ELanUt vjJvlnpTzPHFhqk1IW8P5YttE03f4AaD9orrvSGTXjeDv8puvClb8i9UPJWSm5tbgiPdHf8qIM8 RmIz8tQhoj88bVBtN1tIt/d54TT64lO+tgzdoRzPz+bjJ0rFdgNoJryWUWFdoBbokJhtmKGGBWk 4pfKed2oPO+A1kK8Dqpqn1Pzq+Pyaqm2Ayg8h2HvAEnVCYuV+zCvrRfpgBS84HWqvOEFiFC7Cxu UrUZDEewsN2UrjN0NjQNnTTmQCk2zz28pnDFOoDEDg4K91ik+g0YHx7pqYVK2jrU2mO9GabyLPe pbGxh7iVcgx2GEFpI0KHkCSU08TjNZw== X-Received: by 2002:a05:600c:4e41:b0:4a6:42cc:bf6c with SMTP id 5b1f17b1804b1-4ac16acfbd0mr257573035e9.7.1793693299040; Tue, 03 Nov 2026 00:08:19 -0800 (PST) X-Received: by 2002:a05:600c:4e41:b0:4a6:42cc:bf6c with SMTP id 5b1f17b1804b1-4ac16acfbd0mr257572305e9.7.1793693298403; Tue, 03 Nov 2026 00:08:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793693298; cv=none; d=google.com; s=arc-20260327; b=BcjE0guQCccCumzGrnIIsg8yY8U5HnK2A41pzxqIkGQPr8rT1DaQIhDQ+RQhFMPJuV 46hPmLg8s9wxtfyEM0U3W30RC7P/vDrIAS5c1UsCSO6l5J0VmN+A/oCioK23FHGTwRlT jyZ5dFcDoIwg390iVN3ukO2PPBJgAdB18a5p2e+Gbqn17M2Fj4CrtRBsWa4FMyMB19Ff 6F99m6U/o1wYhj8gdDjqN7w86xwGJaYSoGYcfG5dHJxbxWZjYIntXiZmvXDQWh3o2NEq JStZqE7HfqLpsij26VKpWIVzP4/0ivt6rEgzFL4SnKBVAKoyf32FoIGstfCzY9exKSSw UscQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=QdjUzQq4rZgjpvi6O2pDafcsCZqwjUPfAGhQZm2UQpk=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=MOZxPfQI2IeugUs0DxZUUQ6bwWeqg4H2xNJVZry1nWKscBa6LeV3UmInMdzwrG5uJj gxRkg01hHBPUAhiMaJyEAyaN2nw/qALfMjLw884yN2U3izt+0VH0qb36NIlRUZvQ4aD+ WdAkkP6fqmnCZD/JW4GnReQ+fTMmDuM6DTuCJ7eDLoQoVD1gYIidpAhG2Oq2fx2SOdCL fOdhBXI82ZObYFJQHtdwmAytbVBxPEcLcYL0TpGDumgZquuW/mTUR3jPRmI9Nk1XWZbC T/r6xreYNRXbU+5xUD4M6dAI30lndS7jN8fcDNsqWVbk+VbwBtfZpGAq1kueGqfNxieE Wi6Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=jH6w42mH; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4b2a95100a4si31765375e9.21.2026.11.03.00.08.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 00:08:18 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=jH6w42mH; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=QdjUzQq4rZgjpvi6O2pDafcsCZqwjUPfAGhQZm2UQpk=; b=jH6w42mHYzHj FLcB9anv314fnMN7pVZPMAWhrGlILvYac+mPqQZ7LsZAKLf9vSwOIr/OQkgWQOiIJuMyz+jUTsYjJ oenoJ7ZR/Mv+jPKGb93Y5bZP60WeYBGB56z4BiimgRQHnKstr9+EyCdgOJYTFs/7fHYTJarJe2t25 FbaJcOazXtwwcQngbaxwGxROx/4fhuaTOk7O+r26sK4fb6ZFaZrys2M7LGttSOEPywScYrPkQ63Zf x+l7+25IgXNNE8z3O7nuUhOvVtsE26dQDIsfHfhF8H1vXxkFYpxquTwVthgi2kAkWP5ODJf6StR19 F/hTbPPJQSNeGHaW3SAIWQ==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO9V9-0086OY-0K; Tue, 03 Nov 2026 09:08:08 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 11:03:55 +0300 Message-ID: <20261103080358.723186-4-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> References: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v4 3/6] drivers/md/push_backup: do not re-arm deadline timer in push_backup_write() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org pb_timer_func() checks pb->deadline_jiffies every time it fires, so we actually don't need to re-arm the timer after setting the field. This is also the only place that arms the timer outside the window push_backup_stop() waits for with synchronize_rcu(). Today it is harmless because write and stop are serialized by pb->ctl_rwsem, but it would re-arm the timer behind timer_delete_sync_try() once the write path is reachable without the rwsem (next patches). https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: commit message typo drivers/md/dm-push-backup.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 1ae4ccc208ffa..8ce84a1a696e5 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -467,8 +467,8 @@ static int push_backup_write(struct push_backup *pb, unsigned int clu, unsigned int nr) { u64 i, key, nr_clus = pb->nr_clus; - bool finished, has_more = false; LIST_HEAD(pbio_list); + bool finished; struct pb_bio *pbio; if (!pb) @@ -519,8 +519,7 @@ static int push_backup_write(struct push_backup *pb, } } - has_more = (pb->nr_delayed != 0); - if (has_more) + if (pb->nr_delayed) pb->deadline_jiffies = get_jiffies_64() + pb->timeout_in_jiffies; else pb->deadline_jiffies = S64_MAX; @@ -529,11 +528,8 @@ static int push_backup_write(struct push_backup *pb, if (finished) wake_up_interruptible(&pb->waitq); - if (!list_empty(&pbio_list)) { + if (!list_empty(&pbio_list)) resubmit_pbios(pb, &pbio_list); - if (has_more) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); - } return 0; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel