From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8908E8045D for ; Tue, 3 Nov 2026 08:10:04 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A388nL0002218; Tue, 3 Nov 2026 11:08:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A388nL0002218 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="koPNiudm" Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A388Jts002147 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 11:08:19 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A388Jts002147 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-c49df8fe86eso244336966b.2 for ; Tue, 03 Nov 2026 00:08:19 -0800 (PST) X-Gm-Message-State: APuU4Z+TA+zVcSgRAPs4BVWkrtl9Eicxbiu/llpnN+GlptXlFFmA7Ce/ gb4Uw7qLygQaVhLVOcZRJJschf8J0fpLVWuz1RInawmDXMbeskPTAoLlDlbEHFS6jbIEfqY0hG9 98Z1gdn/cXmk2Gf2/9o93OGI4HndWCoq82PzCjHJ4Ucg7jYXJ9C8B+A== X-Gm-Gg: AYBFou2tfvXy7bGGDIyuR1MUdjliEFbHwy9KRYC3GPAP8yb0eqQP1Tkvn/hYcPwgrgl ALuXqB0Y36LZKuhmdWRlvbdNx3e+RLP6C36MpdoD4yDXQ1nt8lBZ15jysaXbKXckXOlcKlc5j7/ oGjuWQugMKd8PH9P+8XsQw3LROZ+t6UaGJz+jEfj99vwuon86/vUb5po6DHLwmn6g4o+5P/E9nU B1RSQ0/DOH4z/N0+8gzHPoqJimu1uLANmmUSOug2vXgNhGijI2LJBu3SJvBWVJMwY5LdeesuBeP xZjMVXHala6ezfhRNaQgNOrzbS43D4DKz+r1Fsh99bOZD8Dzve6nMYWRTPUB6MLHGvmsxkiahiT sOSi9XaLtfwPUAlor9VHZD4nCVgMHfA== X-Received: by 2002:a17:907:6d20:b0:c46:75e7:25af with SMTP id a640c23a62f3a-c4ca7a0dcb0mr1015305666b.11.1793693298865; Tue, 03 Nov 2026 00:08:18 -0800 (PST) X-Received: by 2002:a17:907:6d20:b0:c46:75e7:25af with SMTP id a640c23a62f3a-c4ca7a0dcb0mr1015303766b.11.1793693298361; Tue, 03 Nov 2026 00:08:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793693298; cv=none; d=google.com; s=arc-20260327; b=EP3H1//Y8QoSSFLEI9PrFkgU2KPejlmQQVOkCcDBRrR5Fj38yS+Ko7ZeKhiiTVgxKx cjuuInLYL1tL3CoHNsn0nwhgWnBLc63dcpOQ36sEH8mvE1km9QBKTOA2r+Ht2IRrfXlh UZGcMfpuKTVebcyKXi/0n1e8Yat5X4eWkut7pmFtxQVrM1EeN4wDN4El3fT7iZxspB7M cMwS61mJomX464TsQndEeHyEZSy+Olv34wQrfFY96u6toXFW2fVAfqMl+MIZancXPyLZ p7vRnsTMy1gvfpSJbpbmdqdnuFvpTX+Wj3gHN5TXjGykLieIeWUJGH728QL4kTcddJXS BBpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=go53/02llSxQ2j5mde9UP4ZN9lvbS/SJvTxMb5b2ILI=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=h1I9A3+Cc/M8BqE27A8VUEqYCV4Dc2gTCIfOCE3N4vdW2oWGyO3XVVt3WrgZbLKDT8 nhPZSE1B5t5+aWkVt2oDN8ZtpwuLqGiJwqvdjZ4HATZnUi1iO8CKTIzYOuHesUdCnGEK G9I7utDGmaZx/WC79HTX+r+3kjLNoJW6bKEiKoTA4NqSC3waMrZ65Ru3Jpg40wYAv/i6 o71XcEpoNpe3z+NQWZUJP4ZbvXuwt7DzRetORtSZtD7J1ifLP9AUm4KMHb8YdM+9knQz L/7Nk/1QG/G3D95SnZITOoEJRQXfR9T0Q5zSVbDYNq9syXC8ypV0Zg0iSCDT26BOQxJw ynvQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=koPNiudm; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bc13e0si22443616f8f.299.2026.11.03.00.08.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 00:08:18 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=koPNiudm; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=go53/02llSxQ2j5mde9UP4ZN9lvbS/SJvTxMb5b2ILI=; b=koPNiudma2Q3 NGy6kGm1amUOzZ/ZDDzm+eAkiqMzruKw+voV8hB+sGmrpOQEWaoqSFk2Y/72RsX6CUp9ZNTRQfjFY xPnEe6S3K3XCcIul4M9silBk81oZHmj6dNYnZGGdr4KUlYhpWw8omkCE3eueqPqWKL/OO8fms+0Pu 9YwH1YbCMHYIFn4OUWRiTqJtvcQSxm3lmD1FP2YyV1lUsTGNf3GycO7vl3Ip2w2oBYG4xuHdPw8Qd 7ZNjKeXvAdXc1Fj7tcC9k1nEy6S9ybvYi7ZoZ8azrn3EnD8GajqE75GyF8IUTwMbZ1NkulqGFRXPI uCMclAxH71c1hHyKSOsCmg==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xO9V9-0086OY-0W; Tue, 03 Nov 2026 09:08:08 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 11:03:56 +0300 Message-ID: <20261103080358.723186-5-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> References: <20261103080358.723186-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v4 4/6] drivers/md/push_backup: fix mod_timer() usage X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org mod_timer() takes an absolute jiffies value, but both callers pass a relative one. After about 5 min uptime this causes the timer to fire and re-arm on every tick. This has not exploded because we still have checked pb->deadline_jiffies each time. Fixes: 62e07487348e ("dm: Add push backup driver") https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: added Fixes: tag drivers/md/dm-push-backup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 8ce84a1a696e5..b1861204f6e3e 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -244,7 +244,7 @@ static void pb_timer_func(struct timer_list *timer) spin_unlock_irqrestore(&pb->lock, flags); if (unlikely(time_before64(now, deadline))) - mod_timer(timer, deadline - now + 1); + mod_timer(timer, jiffies + (deadline - now) + 1); else queue_work(pb->wq, &pb->worker); } @@ -278,7 +278,7 @@ static int postpone_if_required_for_backup(struct push_backup *pb, spin_unlock_irqrestore(&pb->lock, flags); if (queue_timer) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); rcu_read_unlock(); if (queue_timer) -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel