From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1575D811C9 for ; Tue, 3 Nov 2026 12:43:44 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CgPbA005175; Tue, 3 Nov 2026 15:42:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CgPbA005175 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="PUdkOz7S" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A3CgOEc005143 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 15:42:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A3CgOEc005143 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e29c25101so2219938f8f.3 for ; Tue, 03 Nov 2026 04:42:24 -0800 (PST) X-Gm-Message-State: APuU4Z/TB/2c6FpWhajBRcqrOMSX8LkT5nJeLdzwo9X1JA76IsPo3QEi KN3igPf0Atxc4jphs/bl2JQMhSWaOr7vQI/Ecfrp87Nay1FYv4On1k69xWlg5mNZRvKlU2EnYkH QyTXxamqdXpPuIVnWTqz90qTKyceSnl06ZBsoGkUp1DmHiyORkfZZXA== X-Gm-Gg: AYBFou2qDf/4GGWNf1g5o2UG9LytO+mX5oGjq00BZYq7NEiPGgA2gNOWWZG2CpnozFD fszkNX9nMCItq4gNY4pFotOhTRNq0WC3ZP/ql5YvKNMN+XCLeARKkG2H0qNp8y7DsnzD8pjRXcs VtSuipHmyrY1CFLZ5Z8j+G2XFKpDbmBxJAPXX+hyZvPZG55/KyUPm/WPfDQjL+2tTRWLjYraM9z 5UuiBW9ymw+vdD/sfkssPPtU/D+0Ox/v209Ylfm8wG8cSBpP/0UA/bt5YnXxJwrQg0/YD/R+9js s7lmgCs6z6PMGvwLT0X33oLQ9h7fcaZ7rWMAxvyEoRZpbaTv9dAM9/uSK/iEDCZnMAopuiVbvPC n31Rlvmf/DBfu2/mzhdZKC62+3clm X-Received: by 2002:a05:6000:178f:b0:48d:f56d:be56 with SMTP id ffacd0b85a97d-48e6e2f6766mr27631678f8f.13.1793709743923; Tue, 03 Nov 2026 04:42:23 -0800 (PST) X-Received: by 2002:a05:6000:178f:b0:48d:f56d:be56 with SMTP id ffacd0b85a97d-48e6e2f6766mr27631626f8f.13.1793709743428; Tue, 03 Nov 2026 04:42:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793709743; cv=none; d=google.com; s=arc-20260327; b=GgtEDheQGzxLbFES5PpWUGeABOxpZrBEJ0kExU7pBd5kZrIutXKHjjLwbWm1RKVZUK h7m8U8Z0jocmEJCZ+Ao+Wc8/Q1iCCpyOiLNP1pjBABZ+PCtwz/BIrzlW9fU5Kn4gvcT2 8SIQ0fejCfg3LwbGnAt0zS873aR1Rl0HXjLWxV3IDnda5ifzAaNFFc/pWADWsCb0KDVn /OaMOy0adVdM/VMiGsH7Qnfyti0fBO64PJg7aX4gS9bQ6D6eTOJD3wcbPo0LjvR9D2/j +kJdSPqXRScLoWJH5u+ssWGfkrkIbmAAjrqhvQ6rOCzrgJ7Hwr4QUX6YkNlFS4hW1u6I Cg2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=wsTI5ITeQN3fD8XyC7xcnQ94xTwN5kXBc2c7GOjgVWk=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=QAxfgfK2lOj/LgqXo+l2mQcWS85rekfnbyYpIxHf9z35t/ItrVSi2YGZfeRNe0XZO3 h0gAR85mBFTqcSObQ6Y0y8rFcoRg0MJvZxEL3kFjryHZ3d58HYnv/bRfj4Q8qaZZmoVs 2qE/cv6GHHuDKVvyez06eTTbXNAgg+PhoFqdYaoyfW31PhCIU4EhDqfnVNd6bBklm8yI R7zkqbs7PzOBJQa4pmQ6zcSm6ICKBqCWqd+rhIwE+DtXkreFOgVV/luchMXGH0qBspTa FtCTJgafAkZlSk996YumsTSauSCGEUe4xQdsYxNfAP90lFCYgCReUNAwGtZoz6oUVGFW w6fA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=PUdkOz7S; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48e71bc5e04si24805849f8f.333.2026.11.03.04.42.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2026 04:42:23 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=PUdkOz7S; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=wsTI5ITeQN3fD8XyC7xcnQ94xTwN5kXBc2c7GOjgVWk=; b=PUdkOz7SPMHQ h0OXWo9eOYb8b3HXyamx7rfCWCLi21Kn41l51ycnkCDQSLkR+qLM+ANbIjTfCi5cN2xqkBVAu4rF1 PrxqSDuPujFutG5ZU+QcZrAU/V+wgpjCteQaUGBlxJQjBNkzBmd/+cb7agq6+FwGCgvYfhFV0Frxg 8k3wxgIJbclncN9ffqTbn1ZfuGFY2/8eMms+y5fEu1mjV7p2+4IO2LalHDbJuzZZsgv4fAVMfJrIT 46oHOPX6vp5SZjI3rNCTSd8Z52D4tCn6VWXX7gNJBMKrWxEElrFvaWAbqVVZBysUbhTl8xQ8p7VS1 HuepQRjE4YboxD/ijRO8jg==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xODmN-00FAc4-2z; Tue, 03 Nov 2026 13:42:13 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 3 Nov 2026 15:37:59 +0300 Message-ID: <20261103123802.846676-5-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> References: <20261103123802.846676-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 4/7] drivers/md/push_backup: fix mod_timer() usage X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org mod_timer() takes an absolute jiffies value, but all callers pass a relative one, which is always in the past. The timer fires and re-arms on every tick while a write is delayed. It has worked so far because pb_timer_func() checks pb->deadline_jiffies each time. Fixes: 62e07487348e ("dm: Add push backup driver") https://virtuozzo.atlassian.net/browse/VSTOR-152912 Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: added Fixes: tag v5: moved before "do not re-arm deadline timer", so it also fixes the mod_timer() in push_backup_write(); commit message: the relative expiry is always in the past, not only after 5 min drivers/md/dm-push-backup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 5c4f3d625fb82..b6d1629245235 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -244,7 +244,7 @@ static void pb_timer_func(struct timer_list *timer) spin_unlock_irqrestore(&pb->lock, flags); if (unlikely(time_before64(now, deadline))) - mod_timer(timer, deadline - now + 1); + mod_timer(timer, jiffies + (deadline - now) + 1); else queue_work(pb->wq, &pb->worker); } @@ -278,7 +278,7 @@ static int postpone_if_required_for_backup(struct push_backup *pb, spin_unlock_irqrestore(&pb->lock, flags); if (queue_timer) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); rcu_read_unlock(); if (queue_timer) @@ -532,7 +532,7 @@ static int push_backup_write(struct push_backup *pb, if (!list_empty(&pbio_list)) { resubmit_pbios(pb, &pbio_list); if (has_more) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); } return 0; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel